https://bugzilla.redhat.com/show_bug.cgi?id=1646344
Bug ID: 1646344 Summary: Review Request: earlyoom - Early OOM Daemon for Linux Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: vitaly@easycoding.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/EasyCoding/earlyoom/raw/master/earlyoom.spec SRPM URL: https://xvitaly.fedorapeople.org/for-review/earlyoom-1.2-1.fc29.src.rpm Description: Early OOM Daemon for Linux Fedora Account System Username: xvitaly
https://bugzilla.redhat.com/show_bug.cgi?id=1646344
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vascom2@gmail.com Assignee|nobody@fedoraproject.org |vascom2@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1646344
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #1 from Vasiliy Glazov vascom2@gmail.com --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Header files in -devel subpackage, if present. Note: earlyoom-debugsource : /usr/src/debug/earlyoom-1.2-1.fc30.x86_64/kill.h earlyoom-debugsource : /usr/src/debug/earlyoom-1.2-1.fc30.x86_64/meminfo.h earlyoom-debugsource : /usr/src/debug/earlyoom-1.2-1.fc30.x86_64/msg.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 25 files have unknown license. Detailed output of licensecheck in /home/vascom/1646344-earlyoom/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/default [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/default [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in earlyoom-debuginfo , earlyoom-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: earlyoom-1.2-1.fc30.x86_64.rpm earlyoom-debuginfo-1.2-1.fc30.x86_64.rpm earlyoom-debugsource-1.2-1.fc30.x86_64.rpm earlyoom-1.2-1.fc30.src.rpm earlyoom.x86_64: W: spelling-error %description -l en_US oom -> um, moo, pom earlyoom.src: W: spelling-error %description -l en_US oom -> um, moo, pom 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (debuginfo) ------------------- Checking: earlyoom-debuginfo-1.2-1.fc30.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory earlyoom.x86_64: W: spelling-error %description -l en_US oom -> um, moo, pom earlyoom.x86_64: W: invalid-url URL: https://github.com/rfjakob/earlyoom <urlopen error [Errno -2] Name or service not known> earlyoom-debuginfo.x86_64: W: invalid-url URL: https://github.com/rfjakob/earlyoom <urlopen error [Errno -2] Name or service not known> earlyoom-debugsource.x86_64: W: invalid-url URL: https://github.com/rfjakob/earlyoom <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Requires -------- earlyoom (rpmlib, GLIBC filtered): /bin/sh config(earlyoom) libc.so.6()(64bit) rtld(GNU_HASH) systemd
earlyoom-debuginfo (rpmlib, GLIBC filtered):
earlyoom-debugsource (rpmlib, GLIBC filtered):
Provides -------- earlyoom: config(earlyoom) earlyoom earlyoom(x86-64)
earlyoom-debuginfo: debuginfo(build-id) earlyoom-debuginfo earlyoom-debuginfo(x86-64)
earlyoom-debugsource: earlyoom-debugsource earlyoom-debugsource(x86-64)
Source checksums ---------------- https://github.com/rfjakob/earlyoom/archive/v1.2.tar.gz#/earlyoom-1.2.tar.gz : CHECKSUM(SHA256) this package : ce4e8b435eda9bd1427b6606558356249486a405850b9869c0006e7fbd454c5f CHECKSUM(SHA256) upstream package : ce4e8b435eda9bd1427b6606558356249486a405850b9869c0006e7fbd454c5f
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1646344 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1646344
--- Comment #2 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/earlyoom
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com