[Bug 2284289] New: Review Request: rust-apple-dmg - Library for reading and writing dmg images
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Bug ID: 2284289 Summary: Review Request: rust-apple-dmg - Library for reading and writing dmg images Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-dmg/rust-apple-dmg.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-dmg/rust-apple-dmg-0.4.0...
Description: Library for reading and writing dmg images.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118460839
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/ap | |ple-dmg
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7522383 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- The assets/example.dmg file is pretty large (2.1MB vs. 42KB in the rest of the crate). Not sure if this is used (or only used for tests). If this is permissible content, please exclude it from getting installed into the -devel subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #4 from Davide Cavalca davide@cavalca.name --- Looks like it's only used in a test: https://github.com/indygreg/apple-platform-rs/blob/main/apple-dmg/src/lib.rs...
From inspection is looks like the dmg for the macOS app "raquote-winit", which seems to be some kind of example app using https://github.com/rust-windowing/winit. I can't find its sources anywhere, so I'm just going to strip this in %prep and disable the test to be on the safe side.
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #5 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-dmg/rust-apple-dmg.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-dmg/rust-apple-dmg-0.4.0...
Changelog: - strip DMG asset
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #6 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [scripts] # Remove bundled DMG image of unclear origin prep.pre = ["rm -r assets"]
[tests] comments = ["Tests require the DMG we're stripping"] run = ["none"]
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Looks like a good solution to me, thanks!
===
Package was generated with rust2rpm, simplifying the review.
✅❌❓🫤
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-apple-dmg
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-23573869b1 (rust-apple-dmg-0.4.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-23573869b1
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-06 00:23:27
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-23573869b1 (rust-apple-dmg-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-11daf1f1cb (rust-apple-dmg-0.4.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-11daf1f1cb
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5711d6b0a7 (rust-apple-dmg-0.4.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5711d6b0a7
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5711d6b0a7 (rust-apple-dmg-0.4.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2284289
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-11daf1f1cb (rust-apple-dmg-0.4.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com