[Bug 1012337] New: Review Request: cajun-jsonapi - cross-platform C++ header library for JSON - package-review

List overview All Threads
Download

newer

[Bug 1012337] New: Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

older

[Bug 1208738] New: Review Request:...

[Bug 1311045] Review Request:...

Red Hat Bugzilla

26 Sep 2013 26 Sep '13

11:04 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Bug ID: 1012337 Summary: Review Request: cajun-jsonapi - cross-platform C++ header library for JSON Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: daniel@pocock.com.au QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: https://raw.github.com/cajun-jsonapi/cajun-jsonapi/master/cajun-jsonapi.spec SRPM URL: http://www.readytechnology.co.uk/srpms/cajun-jsonapi-2.0.3-1.fc19.src.rpm Description: cross-platform C++ header library for JSON Fedora Account System Username: pocock

CAJUN JSON API is a build dependency for the next version of reSIProcate

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6V11Bf0XTE&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

21 Nov 21 Nov

3:27 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Bill Nottingham notting@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

24 Dec 24 Dec

5:53 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Peter Lemenkov lemenkov@gmail.com changed:

--- Comment #1 from Peter Lemenkov lemenkov@gmail.com --- I'll review it.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

6:04 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is almost silent

sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/cajun-jsonapi-devel-2.0.3-1.fc21.ppc.rpm ../SRPMS/cajun-jsonapi-2.0.3-1.fc21.src.rpm cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding /usr/share/doc/cajun-jsonapi-devel/Readme.txt cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding /usr/share/doc/cajun-jsonapi-devel/ReleaseNotes.txt

^^^ Please convert these files to UTF-8.

2 packages and 0 specfiles checked; 0 errors, 2 warnings. sulaco ~/rpmbuild/SPECS:

+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec.

+/- The package almost meets the Packaging Guidelines. I see few things that should be improved.

1. First of all - this package should be marked as noarch since it doesn't depend on any arch-specific entity. So please remove

%define debug_package %{nil}

and add the following line instead:

BuildArch: noarch

2. Also you may remove unneeded "%defattr(-,root,root,-)" in the %files section. It becomes obsolete since Fedora Core 6 or RHEL 5.

+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The spec file is written in American English. + The spec file for the package is legible. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8.

So please fix/comment the issues mentioned above and I'll finish it.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

6:17 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

--- Comment #3 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Peter Lemenkov from comment #2)

...

REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

rpmlint is almost silent

sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/cajun-jsonapi-devel-2.0.3-1.fc21.ppc.rpm ../SRPMS/cajun-jsonapi-2.0.3-1.fc21.src.rpm cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding /usr/share/doc/cajun-jsonapi-devel/Readme.txt cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding /usr/share/doc/cajun-jsonapi-devel/ReleaseNotes.txt

^^^ Please convert these files to UTF-8.

I mean Unix. Unix line endings.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

6:18 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #4 from Peter Lemenkov lemenkov@gmail.com --- Ok, I see that Daniel fixed everything. I don't see any other issues so this package is

APPROVED.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

10 Jan 10 Jan

11:22 a.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Peter Lemenkov lemenkov@gmail.com changed:

--- Comment #5 from Peter Lemenkov lemenkov@gmail.com --- Ping, Daniel! You didn't requested fedora-cvs flag yet.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

11:25 a.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Daniel Pocock daniel@pocock.com.au changed:

--- Comment #6 from Daniel Pocock daniel@pocock.com.au --- Sorry, I didn't realise, the flag is set to "?" now

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

11:36 a.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

--- Comment #7 from Peter Lemenkov lemenkov@gmail.com --- (In reply to Daniel Pocock from comment #6)

...

Sorry, I didn't realise, the flag is set to "?" now

Daniel, that's still not enough :). You need to fill this template and post it as well:

https://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

12:19 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Daniel Pocock daniel@pocock.com.au changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo+ |needinfo-

--- Comment #8 from Daniel Pocock daniel@pocock.com.au --- New Package SCM Request ======================= Package Name: cajun-jsonapi Short Description: cross-platform C++ header library for JSON Owners: pocock Branches: f19 f20 el6 InitialCC:

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

12:41 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo- |

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

1:15 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

1:16 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

14 Jan 14 Jan

8:40 a.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

--- Comment #10 from Peter Lemenkov lemenkov@gmail.com --- Daniel, it looks that you forgot to submit cajun-jsonapi package for EL6:

https://admin.fedoraproject.org/updates/search/cajun-jsonapi

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

9:04 a.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

--- Comment #11 from Daniel Pocock daniel@pocock.com.au ---

I had tried to but I get an error from

https://admin.fedoraproject.org/updates/new/

it says

"cajun-jsonapi-2.0.3-1.el6 not tagged as an update candidate"

Do I need to make some extra tag? It already appears to be tagged. Do I need to wait for it to be stable in Fedora before it can propagate to EPEL or do I need to request some additional approval for it?

It is in the repository for EPEL6

http://pkgs.fedoraproject.org/cgit/cajun-jsonapi.git/tree/?h=el6

and it is built on EPEL6:

http://koji.fedoraproject.org/koji/buildinfo?buildID=489563

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

3 Mar 3 Mar

4:28 p.m.

New subject: [Bug 1012337] Review Request: cajun-jsonapi - cross-platform C++ header library for JSON

https://bugzilla.redhat.com/show_bug.cgi?id=1012337

Peter Lemenkov lemenkov@gmail.com changed:

--- Comment #12 from Peter Lemenkov lemenkov@gmail.com --- Ok, closing this - the package was built long time ago.

-- You are receiving this mail because: You are always notified about changes to this product and component

3542

Age (days ago)

4431

Last active (days ago)

package-review@lists.fedoraproject.org

15 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla