[Bug 1701779] New: Review Request: la-capitaine-icon-theme - Icon pack designed to integrate with most desktop environments
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
Bug ID: 1701779 Summary: Review Request: la-capitaine-icon-theme - Icon pack designed to integrate with most desktop environments Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ego.cordatus@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://atim.fedorapeople.org/for-review/la-capitaine-icon-theme.spec SRPM URL: https://atim.fedorapeople.org/for-review/la-capitaine-icon-theme-0.6.1-1.201...
Description: La Capitaine is an icon pack — designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design through the use of visually pleasing gradients, shadowing, and simple icon geometry.
Fedora Account System Username: atim
Working COPR: https://copr.fedorainfracloud.org/coprs/atim/la-capitaine-icon-theme/
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Remove the executable permissions in %prep for these svg files:
la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/apps/scalable/goland.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/apps/scalable/meld.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/status/symbolic/notification-disabled-symbolic.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/status/symbolic/notification-new-symbolic.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/status/symbolic/notification-symbolic.svg
Please send a PR upstream to fix it too.
Package approved. Please fix the aforementioned issue before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: la-capitaine-icon-theme-0.6.1-1.20190418gitbc48265.fc31.noarch.rpm la-capitaine-icon-theme-0.6.1-1.20190418gitbc48265.fc31.src.rpm la-capitaine-icon-theme.noarch: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/archlinux.svg distributor-logo-archlinux.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/configure-debian.svg distributor-logo-debian.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/debian-logo.svg distributor-logo-debian.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/debian-plymouth-manager.svg distributor-logo-debian.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/debian.svg distributor-logo-debian.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/distributor-logo-eos.svg distributor-logo-elementary.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/gnome-debian.svg distributor-logo-debian.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/apps/scalable/goland.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/apps/scalable/kubuntu.svg distributor-logo-kubuntu.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/apps/scalable/meld.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/places/scalable/distributor-logo-lubuntu.svg distributor-logo-lxde.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/places/scalable/distributor-logo-unity.svg distributor-logo-ubuntu.svg la-capitaine-icon-theme.noarch: W: dangling-relative-symlink /usr/share/icons/La-Capitaine/places/scalable/windows.svg distributor-logo-windows.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/status/symbolic/notification-disabled-symbolic.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/status/symbolic/notification-new-symbolic.svg la-capitaine-icon-theme.noarch: E: script-without-shebang /usr/share/icons/La-Capitaine/status/symbolic/notification-symbolic.svg la-capitaine-icon-theme.src: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS la-capitaine-icon-theme.src: W: no-%build-section 2 packages and 0 specfiles checked; 5 errors, 14 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
--- Comment #2 from Artem ego.cordatus@gmail.com --- Spec URL: https://atim.fedorapeople.org/for-review/la-capitaine-icon-theme.spec SRPM URL: https://atim.fedorapeople.org/for-review/la-capitaine-icon-theme-0.6.1-2.201...
(In reply to Robert-André Mauchin from comment #1)
- Remove the executable permissions in %prep for these svg files:
Done. I waited for hours when my *package-review* tool finish check this package and then i terminated it.
Please send a PR upstream to fix it too.
OK.
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/la-capitaine-icon-theme
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- la-capitaine-icon-theme-0.6.1-2.20190418gitbc48265.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ff9b1dba21
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- la-capitaine-icon-theme-0.6.1-2.20190418gitbc48265.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ff9b1dba21
https://bugzilla.redhat.com/show_bug.cgi?id=1701779
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-05-02 03:33:20
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- la-capitaine-icon-theme-0.6.1-2.20190418gitbc48265.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com