https://bugzilla.redhat.com/show_bug.cgi?id=1377733
Bug ID: 1377733 Summary: Review Request: systemd-bootchart - Boot performance graphing tool Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fale@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fale.fedorapeople.org/rpms/systemd-bootchart.spec SRPM URL: https://fale.fedorapeople.org/rpms/systemd-bootchart-231-1.fc24.src.rpm Description: Boot performance graphing tool Fedora Account System Username: fale
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ignatenko@redhat.com
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com --- - Use %{_unitdir} - Use %make_build - Add special systemd macro in %post* triggers - Use %{?systemd_requires}
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #2 from Fabio Alessandro Locati fale@redhat.com --- Thanks Igor :).
SRPM: https://fale.fedorapeople.org/rpms/systemd-bootchart-231-2.fc24.src.rpm SPEC: https://fale.fedorapeople.org/rpms/systemd-bootchart.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #3 from Igor Gnatenko ignatenko@redhat.com ---
BuildRequires: systemd-units BuildRequires: systemd-devel
BuildRequires: pkgconfig(libsystemd)
%config(noreplace) /etc/systemd/bootchart.conf
%config(noreplace) %{_sysconfdir}/systemd/bootchart.conf
/usr/lib/systemd/systemd-bootchart
%{_unitdir}/../%{name}
%{_mandir}/man1/systemd-bootchart.1.gz
%{_mandir}/man1/%{name}.1*
%{_mandir}/man5/bootchart.conf.5.gz
%{_mandir}/man5/bootchart.conf.5*
%{_mandir}/man5/bootchart.conf.d.5.gz
%{_mandir}/man5/bootchart.conf.d.5*
* Missing BuildRequires: gcc
All this issues are easy to fix during import, so approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Also: BuildRequires: systemd-units → not necessary, you have BR:systemd-devel already
Please put something in description that explains to newcomers what this package does: e.g. "This package provides a binary which can be started during boot early boot to capture informations about processes and services launched during bootup. Resource utilization and process information are collected during the boot process and are later rendered in an SVG chart. The timings for each services are displayed separately."
Looks great otherwise.
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/systemd-bootchart
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f0fcabe02
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Sorry, yet another request: Please add Obsoletes: systemd < 231, so that this package is automatically installed when upgrading both packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=f25&id=325...
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #9 from Fabio Alessandro Locati fale@redhat.com --- Speaking in fedora-devel channel, the consensus was that it's probably better and safer to have a soft dependency like Recommend on systemd pointing to this package. I'll open a bug against systemd to discuss this point tomorrow (bugzilla is "not great" from the smartphone).
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #10 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Hi, I was travelling the last few days, I couldn't participate in the conversation.
I'm fine with adding a Recommend. This package is tiny, so this shouldn't be an issue. I'll add it on systemd-udev, since this is useful on "real" systems.
http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=master&id=...
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
--- Comment #11 from Fabio Alessandro Locati fale@redhat.com --- Sorry, I lost your comment :/. Nice, thanks :)
https://bugzilla.redhat.com/show_bug.cgi?id=1377733
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-10-08 22:53:39
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla