https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Bug ID: 2051854 Summary: Review Request: oneVPL-intel-gpu - Intel oneVPL GPU Runtime Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: negativo17@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://slaanesh.fedorapeople.org/oneVPL-intel-gpu.spec SRPM URL: https://slaanesh.fedorapeople.org/oneVPL-intel-gpu-22.2.0-1.fc35.src.rpm Description: Intel® oneVPL GPU Runtime is a Runtime implementation of oneVPL API for Intel Gen GPUs. Runtime provides access to hardware-accelerated video decode, encode and filtering.
Fedora Account System Username: slaanesh
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |ngompa13@gmail.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|NEW |POST
--- Comment #2 from Neal Gompa ngompa13@gmail.com ---
Intel® oneVPL GPU Runtime
We don't use (R)/(C)/(TM) or their unicode equivalents: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_su...
Please drop them on import.
Other than that...
Review notes:
* Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
--- Comment #3 from Simone Caronni negativo17@gmail.com --- (In reply to Neal Gompa from comment #2)
Intel® oneVPL GPU Runtime
We don't use (R)/(C)/(TM) or their unicode equivalents: https://docs.fedoraproject.org/en-US/packaging-guidelines/ #_trademarks_in_summary_or_description
Please drop them on import.
Ah! I missed that. I will do.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oneVPL-intel-gpu
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2022-02-10 16:37:55
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Dave Airlie airlied@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |airlied@redhat.com
--- Comment #5 from Dave Airlie airlied@redhat.com --- Did this have any legal review? there is definitely some possible patented stuff that could be linked to this.
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
--- Comment #6 from Simone Caronni negativo17@gmail.com --- Nope, I was not aware sorry. How to trigger a legal review after the package is already available?
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Dave Airlie airlied@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |182235 (FE-Legal)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Dave Airlie airlied@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|CURRENTRELEASE |--- Keywords| |Reopened
--- Comment #7 from Dave Airlie airlied@redhat.com --- I'm reopening this for legal review, based on it seems to enable APIs for h264/5 decoding from what I understand of the package.
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review+ |fedora-review? CC| |ppisar@redhat.com
--- Comment #8 from Petr Pisar ppisar@redhat.com --- Reverting review state back to "fedora-review?".
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- (In reply to Dave Airlie from comment #7)
I'm reopening this for legal review, based on it seems to enable APIs for h264/5 decoding from what I understand of the package.
As far as I know this thing can't do anything without a functioning driver component, which is being reviewed in bug 1942132 with the encumbered codecs stripped.
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- For some additional protection, we could also add "-DMFX_ENABLE_H264_VIDEO_DECODE=OFF -DMFX_ENABLE_H265_VIDEO_DECODE=OFF -DMFX_ENABLE_VC1_VIDEO_DECODE=OFF -DMFX_ENABLE_H264_VIDEO_ENCODE=OFF -DMFX_ENABLE_H265_VIDEO_ENCODE=OFF" to the cmake option list to forcibly disable those runtime paths entirely.
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Richard Fontana rfontana@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|182235 (FE-Legal) | CC| |rfontana@redhat.com
--- Comment #11 from Richard Fontana rfontana@redhat.com --- Lifting FE-Legal.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2051854
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Flags|fedora-review? |fedora-review+ Resolution|--- |ERRATA Last Closed|2022-02-10 16:37:55 |2022-11-17 19:07:47
package-review@lists.fedoraproject.org