[Bug 2055602] New: Review Request: colortest - Bash script to display terminal colors

https://bugzilla.redhat.com/show_bug.cgi?id=2055602

Bug ID: 2055602
           Summary: Review Request: colortest - Bash script to display
                    terminal colors
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/glaringgibbon/colortest/f...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/glaringgibbon/colortest/f...
Description: Quickly show all your terminal colours
Fedora Account System Username: glaringgibbon

[Bug 2055602] Review Request: colortest - Bash script to display terminal colors

https://bugzilla.redhat.com/show_bug.cgi?id=2055602

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Jakub Kadlčík  ---
Thank you for the package!
Overall, it looks good, but I think a couple of things should be fixed.
> Tue Feb 15 2022 glaringgibbon   - 3.0.4-1

I am not sure if it is an enforced policy or not but it is common to
put a full name into the changelog entries. See the guidelines for an
example
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
> Version:        3.0.4
> Source0:        https://github.com/pablopunk/%%7Bname%7D/archive/refs/heads/master.zip

You are packaging 3.0.4 version, which is what I would expect but the
problem is that you are using different a source tarball. If you look at
https://github.com/pablopunk/colortest/commits/master
you can see that since the actual 3.0.4 version, multiple commits 
(9 if I count correctly) have happened.

Also, packaging sources from the `master` branch is problematic in
another way - each time we would rebuild the package, the sources
tarball could be different (if the author pushed some changes in the
meantime).

You actually want to download the Source0 like this
%{URL}/archive/%{version}/%{name}-%{version}.tar.gz
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_ta...

I understand why you needed to package `master` instead of the actual
version, which is the added LICENSE file. You will probably have to ask
upstream to release 3.0.5 version.

A few really nitpicky notes - There are two blank lines between
sections but between %files and %changelog, there is just one. Also
between the email in the changelog and the dash, there is a double space.

Otherwise, I tried the package and it works, so cheers!

[Bug 2055602] Review Request: colortest - Bash script to display terminal colors

https://bugzilla.redhat.com/show_bug.cgi?id=2055602

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]

[Bug 2055602] Review Request: colortest - Bash script to display terminal colors

https://bugzilla.redhat.com/show_bug.cgi?id=2055602

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #2 from Michel Alexandre Salim  ---
Will sponsor once the review is done

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 2055602] Review Request: colortest - Bash script to display terminal colors

https://bugzilla.redhat.com/show_bug.cgi?id=2055602

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

--- Comment #3 from Jakub Kadlčík  ---
Thank you very much Michael,
I became a sponsor in the meantime as well.

But we shall first see how the review turns out.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

needinfo canceled: [Bug 2055602] Review Request: colortest - Bash script to display terminal colors

Product: Fedora
Version: rawhide
Component: Package Review

Jakub Kadlčík  has canceled Package Review
's request for Jakub Kadlčík
's needinfo:
Bug 2055602: Review Request: colortest - Bash script to display terminal colors
https://bugzilla.redhat.com/show_bug.cgi?id=2055602

--- Comment #5 from Jakub Kadlčík  ---
I am interested in reviewing this ticket but there is no response from the
contributor.

[Bug 2055602] Review Request: colortest - Bash script to display terminal colors

https://bugzilla.redhat.com/show_bug.cgi?id=2055602

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jkadlcik@redhat.c |
                   |om)                         |

--- Comment #5 from Jakub Kadlčík  ---
I am interested in reviewing this ticket but there is no response from the
contributor.