[Bug 1580025] New: Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings
4:45 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Bug ID: 1580025
Summary: Review Request: rubygem-jekyll-email-protect - A
simple liquid filter which converts emails into
percent-encoded strings
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: jar.prokop(a)volny.cz
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://gitlab.com/jackorp/rubygem-jekyll-email-protect/raw/2dbe9338facb5...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-jekyll-em...
Description: Email protection liquid filter for Jekyll.
Fedora Account System Username: jackorp
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=27061523
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:25 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Pavel Valena <pvalena(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |pvalena(a)redhat.com
Assignee|nobody(a)fedoraproject.org |pvalena(a)redhat.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:40 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
--- Comment #1 from Pavel Valena <pvalena(a)redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [n] = Note
Issues:
=======
[!]: Linked file: rubygem-jekyll-email-protect-1.1.0-1.fc29.noarch.rpm is not a
SRPM, please provide a valid one.
[n]: I'd suggest the following changes to simplify the SPEC file(generated by
newer gem2rpm):
```
diff --git a/rubygem-jekyll-email-protect.spec
b/rubygem-jekyll-email-protect.spec
index c481c9a..12b1276 100644
--- a/rubygem-jekyll-email-protect.spec
+++ b/rubygem-jekyll-email-protect.spec
@@ -29,11 +29,15 @@ BuildArch: noarch
Documentation for %{name}.
%prep
-%setup -q -n %{gem_name}-%{version}
+gem unpack %{SOURCE0}
+
+%setup -q -D -T -n %{gem_name}-%{version}
+
+gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
%build
# Create the gem as gem install only works on a gem file
-gem build ../%{gem_name}-%{version}.gemspec
+gem build %{gem_name}.gemspec
# %%gem_install compiles any C extensions and installs the gem into
./%%gem_dir
# by default, so that we can move it into the buildroot in %%install
```
(not a blocker)
[n]: If it's really not needed you could create a PR upstream for:
```
# We do not need whole jekyll,
# using just liquid is sufficient.
sed -i "/require 'jekyll'/ s/'jekyll'/'liquid'/"
spec/spec_helper.rb
```
(and link it in comment; not a blocker)
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[-]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
===== SHOULD items =====
Generic:
[-]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Ruby:
[x]: Gem should use %gem_install macro.
[x]: Gem package should exclude cached Gem.
[x]: gems should not require rubygems package
[x]: Specfile should use macros from rubygem-devel package.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.
===== EXTRA items =====
Rpmlint
-------
Checking: rubygem-jekyll-email-protect-1.1.0-1.fc29.noarch.rpm
rubygem-jekyll-email-protect-doc-1.1.0-1.fc29.noarch.rpm
rubygem-jekyll-email-protect-1.1.0-1.fc29.src.rpm
rubygem-jekyll-email-protect.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
rubygem-jekyll-email-protect-doc.noarch: W: invalid-url URL:
https://github.com/vwochnik/jekyll-email-protect <urlopen error [Errno -2] Name
or service not known>
rubygem-jekyll-email-protect.noarch: W: invalid-url URL:
https://github.com/vwochnik/jekyll-email-protect <urlopen error [Errno -2] Name
or service not known>
rubygem-jekyll-email-protect.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires
--------
rubygem-jekyll-email-protect-doc (rpmlib, GLIBC filtered):
rubygem-jekyll-email-protect
rubygem-jekyll-email-protect (rpmlib, GLIBC filtered):
ruby(rubygems)
Provides
--------
rubygem-jekyll-email-protect-doc:
rubygem-jekyll-email-protect-doc
rubygem-jekyll-email-protect:
rubygem(jekyll-email-protect)
rubygem-jekyll-email-protect
Source checksums
----------------
https://rubygems.org/gems/jekyll-email-protect-1.1.0.gem :
CHECKSUM(SHA256) this package :
00d620939c710788ae3f71188ef913e0aa7ff0a5a39f48249213ea6215558c8d
CHECKSUM(SHA256) upstream package :
00d620939c710788ae3f71188ef913e0aa7ff0a5a39f48249213ea6215558c8d
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:33 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
--- Comment #2 from Jaroslav Prokop <jar.prokop(a)volny.cz> ---
Thanks for taking the review.
I have opened PR, linked it in the comment and simplified spec file as you
suggested.
new files:
spec URL:
https://gitlab.com/jackorp/rubygem-jekyll-email-protect/raw/e243d11a97bb1...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-jekyll-em...
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28367834
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:21 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vondruch(a)redhat.com
Blocks| |1629487
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1629487
[Bug 1629487] Review Request: rubygem-jekyll-git-authors - Jekyll plugin
that adds git authors into your page
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:17 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
Flags| |needinfo?(pvalena(a)redhat.co
| |m)
--- Comment #3 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
ping Pavel Valena: if you do not have time to finish this review, I can take
over.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:20 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Pavel Valena <pvalena(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
|needinfo?(pvalena(a)redhat.co |
|m) |
--- Comment #4 from Pavel Valena <pvalena(a)redhat.com> ---
Sorry for the holdup. The spec looks fine now, thanks!
I APPROVE the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:22 a.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Pavel Valena <pvalena(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:53 p.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
--- Comment #5 from Jaroslav Prokop <jar.prokop(a)volny.cz> ---
Thanks for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:37 p.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
--- Comment #6 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-jekyll-email-protect
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:08 p.m.
New subject: [Bug 1580025] Review Request:
rubygem-jekyll-email-protect - A simple liquid filter which converts emails
into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025
Jaroslav Prokop <jar.prokop(a)volny.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Fixed In Version| |rubygem-jekyll-email-protec
| |t-1.1.0-1.fc30
Resolution|--- |RAWHIDE
Last Closed| |2018-09-18 16:08:48
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2069
days inactive
2191
days old
package-review@lists.fedoraproject.org
10 comments
1 participants
participants (1)
-
bugzilla＠redhat.com