[Bug 196379] New: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: rdieter@math.unl.edu QAContact: fedora-package-review@redhat.com
Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeartwork-extras.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeartwork-extras-... Description: KDE Artwork Extras, including xscreensaver-based screensavers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-06-22 16:24 EST ------- Targetted for fc6+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
------- Additional Comments From panemade@gmail.com 2006-06-23 01:18 EST ------- Rex i got error in mock build error: unpacking of archive failed on file /builddir/build/SOURCES/kdegraphics-3.5.3.tar.bz2;449b7b15: cpio: read failed - Invalid argument Error installing srpm: kdegraphics-extras-3.5.3-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From panemade@gmail.com 2006-06-23 01:23 EST ------- oops wrong copy/paste anyway i am not able to download SRPM can you check SRPM link
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-06-23 07:20 EST ------- url got truncated (missed .rpm):
fixed SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeartwork-extras-...
unpacking WORKSFORME.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From panemade@gmail.com 2006-06-23 07:48 EST ------- rpmlint -i kdegraphics-extras-3.5.3-3.src.rpm error checking signature of kdegraphics-extras-3.5.3-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-06-23 07:53 EST ------- WORKSFORME: $rpmlint -i kdegraphics-extras-3.5.3-3.src.rpm
You apparently don't have by gpg key, fetch from http://kde-redhat.sourceforge.net/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From imlinux@gmail.com 2006-07-26 15:19 EST ------- WORKSFORME: and builds in mock.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 12:53 EST ------- Is this targeted for FC6 or FC7?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-09-29 12:56 EST ------- fc6 (and newer)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 13:09 EST ------- Then, where is the newest SPEC file and SRPM?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-09-29 13:15 EST -------
Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeartwork-extras.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeartwork-extras-...
%changelog * Tue Aug 29 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.5.4-2 - used unversioned Requires: kdebase
* Tue Jul 25 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.5.4-1 - kde-3.5.4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-29 14:54 EST ------- I will review this later.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-30 03:09 EST ------- Well,
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* rpmlint is not silent. W: kdeartwork-extras macro-in-%changelog _libdir W: kdeartwork-extras macro-in-%changelog _libexecdir Use %% to avoild having macros expanded.
* Requires: - Does this package (kdeartwork-extras) really require xscreensaver related packages? It is someting like "optional", isn't it? Perhaps there are some users who don't want to install xscreensaver-gl-extras.
I also wonder why this package require xscreensaver-base. Perhaps KDE has its own screensaver mechanism isn't it? (I use GNOME and xscreensave as screensaver, so I don't know well about KDE).
* BuildRequires: - Is xscreensaver-base really required?
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing.
3. Other things I have noticed: A. request: * Desktop files corresponding to the following hacks are missing - glschool (in xscreensaver-gl-extras) - topblock (in xscreensaver-gl-extras) Would you add the desktop files for these hacks?
* IMO, the hacks in the following package can also be used for this package. rss-glx (in extras and maintained by Nils Philippsen) xdaliclock (in extras and maintained by Chris Ricker)
Would you add the corresponding desktop files or ask the maintainers to support this package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-09-30 03:24 EST ------- Another one question.
Does "sourc"ing Qt config files (/etc/profile.d/qt.sh) still needed? At least mockbuild surely "source" all files under /etc/profile.d and explicit "sourc"ing qt.sh is unnecessary.
I can see many packages which use qt for rebuilding and don't "source" qt.sh explicitly under: http://buildsys.fedoraproject.org/logs/fedora-development-extras/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-09-30 13:50 EST -------
Does "sourc"ing Qt config files (/etc/profile.d/qt.sh) still needed?
Strictly speaking, no, not for mock anyway. otoh, it's presence certainly is not wrong nor does it cause any harm.
Does this package (kdeartwork-extras) really require xscreensaver related packages?
Yes, most of the bundled screensavers actually use xscreensaver as the backend.
It is someting like "optional", isn't it? Perhaps there are some users who don't want to install xscreensaver-gl-extras.
Without more package splitting, no. The manual work required to make that work properly simply isn't worth it, imo.
- Is xscreensaver-base really required?
Yes. %%configure checks for the presence of the xscreensaver bits at buildtime.
- Desktop files corresponding to the following hacks are missing
Personally, I'm not interested in adding those by hand. IMO, it's an upstream issue (ie, I'd prefer to let them "fix" it).
- IMO, the hacks in the following package can also be used for
this package.
I'll ping upstream about these too.
W: kdeartwork-extras macro-in-%changelog _libdir W: kdeartwork-extras macro-in-%changelog _libexecdir Use %% to avoild having macros expanded.
Oops, will fix that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-01 02:30 EST ------- (In reply to comment #15)
- Is xscreensaver-base really required?
Yes. %%configure checks for the presence of the xscreensaver bits at buildtime.
Actually I tried mockbuild with xscreensaver-base removed from BuildRequires and * mockbuild suceeded without any failure * the results of "rpm -qlp" and "rpm -ql --requires" make no difference
It seems that configure checks where xscreensaver hacks are installed and does not check if xscreensaver daemon is installed.
I still wonder why this package requires xscreensaver-base (for Requires:). KDE uses its own screensaver daemon, doesn't it? Does this package require xscreensaver daemon or xscreensaver configuration program?
W: kdeartwork-extras macro-in-%changelog _libdir W: kdeartwork-extras macro-in-%changelog _libexecdir Use %% to avoild having macros expanded.
Oops, will fix that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-10-01 08:46 EST -------
Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeartwork-extras.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeartwork-extras-...
%changelog * Sat Sep 30 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.5.4-3 - use %%_foo style macros in %%changelog
I still wonder why this package requires xscreensaver-base (for Requires:).
Because many of the kde screensavers actually use xscreensaver. In the absense of the xscreensaver bits, the screensavers will be listed as being available, but they won't actually work or do anything.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-10-01 08:49 EST -------
Actually I tried mockbuild with xscreensaver-base removed from BuildRequires and
- mockbuild suceeded without any failure
But do all the xscreensaver-based screensavers actually *work*? I'd venture possibly not, because %configure checks for the hacks location at buildtime, and in the absense of that, it may just end up guessing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-01 09:15 EST ------- Umm.. I must explain why I wonder for xscreensaver-base dependency as xscreensaver maintainer in FE.
(In reply to comment #17))
Because many of the kde screensavers actually use xscreensaver
What do you mean by "many of the kde screensavers"?
This means that many KDE screensaver "hacks" (not "daemon") uses xscreensaver "daemon" (i.e. /usr/bin/xscreensaver) ?
(In reply to comment #18)
But do all the xscreensaver-based screensavers actually *work*? I'd venture possibly not, because %configure checks for the hacks location at buildtime, and in the absense of that, it may just end up guessing.
Yes, configure of this package tries to check for the path of xscreensaver hacks, and NO hacks are included in xscreensaver-base. So mockbuild without xscreensaver-base correctly finds correctly all xscreensaver hacks (as all hacks are installed in the two hacks).
xscreensaver-base includes only the files related to xscreensaver "daemon". And all the hacks packaged in xscreensaver-{extras,gl-extras} can actually work without xscreensaver-base because all hacks in xscreensaver does NOT use xscreensaver daemon, they are completely stand-alone. This is why xscreensaver-extras, xscreensaver-gl-extras does not require xscreensaver-base (this is very intentional), and gnome-screensaver can use xscreensaver-related hacks without xscreensaver-base.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-01 09:19 EST ------- Oops..
(as all hacks are installed in the two hacks)
I meant: (as all hacks are installed in the two packages)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-10-01 14:23 EST ------- Thanks for the explanation (though I personally would have named the pkgs differently so that was more clear).
Spec URL: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/kdeartwork-extras.spec SRPM URL: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/kdeartwork-extras-...
%changelog * Sun Oct 01 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.5.4-4 - extras: drop (Build)Requires: xscreensaver-base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-02 10:35 EST ------- Source doesn't seem to have a copy of GPL license. Please ask upstream to include GPL copy.
Other things are okay.
---------------------------------------------------------------------- This package (kdeartwork-extras) is APPROVED by me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
------- Additional Comments From rdieter@math.unl.edu 2006-10-02 10:49 EST ------- Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From rdieter@math.unl.edu 2006-10-02 11:13 EST ------- imported...
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla