[Bug 466223] New: Review Request: perl-Sysadm-Install - Typical installation tasks for system administrators
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Sysadm-Install - Typical installation tasks for system administrators
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Summary: Review Request: perl-Sysadm-Install - Typical installation tasks for system administrators Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: paul@city-fan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.city-fan.org/~paul/extras/perl-Sysadm-Install/perl-Sysadm-Install... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Sysadm-Install/perl-Sysadm-Install... Description:
Have you ever wished for your installation shell scripts to run reproducably, without much programming fuzz, and even with optional logging enabled? Then give up shell programming, use Perl.
"Sysadm::Install" executes shell-like commands performing typical installation tasks: Copying files, extracting tarballs, calling "make". It has a "fail once and die" policy, meticulously checking the result of every operation and calling "die()" immediately if anything fails.
"Sysadm::Install" also supports a *dry_run* mode, in which it logs everything, but suppresses any write actions.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |466237
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2008-10-09 15:51:57 EDT --- I don't really object to it, but I think the first paragraph of %description is content-free in the context of a package description.
/usr/bin/one-liner probably should not be shipped; it seems completely pointless, has a generic name, and is already shipped as documentation.
My checklist: * source files match upstream: 8cadfb192f92b12d18c0123472924dfe779fefb027051adbff8c7fdcae246778 Sysadm-Install-0.27.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Sysadm::Install) = 0.27 perl-Sysadm-Install = 0.27-1.fc10 = /usr/bin/perl perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Archive::Tar) perl(Cwd) perl(Expect) perl(File::Basename) perl(File::Copy) perl(File::Path) perl(File::Spec::Functions) perl(File::Temp) perl(LWP::Simple) perl(Log::Log4perl) perl(Log::Log4perl::Util) perl(Sysadm::Install) perl(Term::ReadKey) perl(strict) perl(warnings)
* %check is present and all tests pass: All tests successful. Files=12, Tests=43, 1 wallclock secs
* owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
--- Comment #2 from Paul Howarth paul@city-fan.org 2008-10-09 18:48:38 EDT --- (In reply to comment #1)
I don't really object to it, but I think the first paragraph of %description is content-free in the context of a package description.
OK, I stripped that paragraph and added a few words about logging to the second paragraph.
/usr/bin/one-liner probably should not be shipped; it seems completely pointless, has a generic name, and is already shipped as documentation.
I initially %exclude-d this for those very reasons but changed my mind as I thought it seemed a handy way of running methods from the module quickly from the command line. You're right though, it's very generic and doesn't seem to documented as a feature of the module so I've %exclude-d it again.
The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Getting the sendmail merge review moving again is on my to-do list...
Revised package: http://www.city-fan.org/~paul/extras/perl-Sysadm-Install/perl-Sysadm-Install... http://www.city-fan.org/~paul/extras/perl-Sysadm-Install/perl-Sysadm-Install...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2008-10-16 14:50:03 EDT --- Sorry for not getting back to this sooner.
I wonder why rpmlint is now complaining about the perl depencencies in the documentation files. Obviously these aren't problematic but I wonder why I didn't see them before. So that I mention it, they're pairs of the form: perl-Sysadm-Install.noarch: W: spurious-executable-perm /usr/share/doc/perl-Sysadm-Install-0.27/eg/ask perl-Sysadm-Install.noarch: W: doc-file-dependency /usr/share/doc/perl-Sysadm-Install-0.27/eg/ask /usr/bin/perl one pair for each executable file in the eg directory.
Anyway, everything looks fine to me now.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
--- Comment #4 from Paul Howarth paul@city-fan.org 2008-10-16 18:52:37 EDT --- Thanks for that; I saw those rpmlint warnings when I prepared the package myself and was a bit surprised by the "rpmlint is silent" comment, and put it down to maybe you having a different version of rpmlint. Apparently not then...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Paul Howarth paul@city-fan.org 2008-10-16 18:54:12 EDT --- New Package CVS Request ======================= Package Name: perl-Sysadm-Install Short Description: Typical installation tasks for system administrators Owners: pghmcfc Branches: F-8 F-9 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Kevin Fenzi kevin@tummy.com 2008-10-19 18:56:38 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
--- Comment #7 from Paul Howarth paul@city-fan.org 2008-10-19 19:41:15 EDT --- Built for Rawhide, F-9, and F-8:
Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=889572
F-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=889582
F-8: http://koji.fedoraproject.org/koji/taskinfo?taskID=889596
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #8 from Paul Howarth paul@city-fan.org 2008-10-24 03:07:30 EDT --- F-8 and F-9 packages now available in stable updates repo. We're done here.
Thanks for the review Tibbs (as always).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #9 from Paul Howarth paul@city-fan.org 2010-08-01 12:44:21 EDT --- Package Change Request ====================== Package Name: perl-Sysadm-Install Short Description: Typical installation tasks for system administrators Owners: pghmcfc New Branches: EL-6 InitialCC: perl-sig
This hasn't been in EPEL before due to missing dependencies but they're all there in EL-6.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466223
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2010-08-02 12:25:50 EDT --- GIT done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla