https://bugzilla.redhat.com/show_bug.cgi?id=829733
Bug ID: 829733 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: drupal6-image_resize_filter - Image Resize Filter module for Drupal6 Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: ansilva@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://people.redhat.com/~ansilva/drupal6-image_resize_filter.spec SRPM URL: http://people.redhat.com/~ansilva/drupal6-image_resize_filter-1.13-3.fc16.sr... Description: This filter makes it easy to resize images, especially when combined with a WYSIWYG editor such as tinyMCE or CKeditor. Fedora Account System Username: afsilva
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com Assignee|nobody@fedoraproject.org |shawn.iwinski@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 701896 --> https://bugzilla.redhat.com/attachment.cgi?id=701896&action=edit drupal6-image_resize_filter-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 829733
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 701897 --> https://bugzilla.redhat.com/attachment.cgi?id=701897&action=edit phpci.log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- ===== SHOULD items =====
[!]: Package does not include license text files separate from upstream.
I believe this is because of a license update in the actual license file? Has upstream been made aware of the needed update?
[!]: Packages should try to preserve timestamps of original installed files.
Please consider adding the "-p" (or "--preserve-timestamps") flag to your install command.
Per phpci, after initial import, please add "php-pcre" requirement.
No blockers.
===== APPROVED =====
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Anderson Silva ansilva@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Anderson Silva ansilva@redhat.com --- New Package SCM Request ======================= Package Name: drupal6-image_resize_filter Short Description: This filter makes it easy to resize images, especially when combined with a WYSIWYG editor such as tinyMCE or CKeditor. Owners: afsilva siwinski Branches: f17 f18 f19 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- drupal6-image_resize_filter-1.13-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-image_resize_filter-1.13-3.e...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- drupal6-image_resize_filter-1.13-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal6-image_resize_filter-1.13-3.f...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- drupal6-image_resize_filter-1.13-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/drupal6-image_resize_filter-1.13-3.f...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #9 from Shawn Iwinski shawn.iwinski@gmail.com --- Package Change Request ====================== Package Name: drupal6-image_resize_filter New Branches: el5 Owners: ansilva siwinski InitialCC:
Adding el5 branch to follow most other drupal6 packages.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Done.
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Done.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- drupal6-image_resize_filter-1.13-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-04-01 18:26:27
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- drupal6-image_resize_filter-1.13-3.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829733
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- drupal6-image_resize_filter-1.13-3.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org