Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=352741
Summary: Review Request: tkimg - More Image Formats for Tk Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sergio.pasra@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://sergiopr.fedorapeople.org/tkimg.spec SRPM URL: http://sergiopr.fedorapeople.org/tkimg-1.3-0.2.20071018svn.src.rpm Description: This package contains a collection of image format handlers for the Tk photo image type, and a new image type, pixmaps. The provided format handlers include bmp, gif, ico, jpeg, pcx, png, ppm, ps, sgi, sun, tga, tiff, xbm, and xpm.
This package is needed to build SAOImage DS9 (http://hea-www.harvard.edu/RD/ds9/), an astronomical data visualization application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
sergio.pasra@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |352761 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mmahut@redhat.com Status|NEW |NEEDINFO Flag| |needinfo?(sergio.pasra@gmail | |.com)
------- Additional Comments From mmahut@redhat.com 2007-10-25 14:18 EST ------- [-] source files match upstream:
07afc28f7e1149dad65471f387298052 tkimg-1.3.tar.gz 964a692db8a120dc5ed8779521a70bc8 tkimg-1.3.tar.gz.upstream
* I diffed the tree and I see no changes beside owership. Please make sure you ship the version from sourcefource page.
[+] package meets naming and versioning guidelines. [+] specfile is properly named and cleanly written. [-] dist tag is present.
* Please use dist tag for your release tag. http://fedoraproject.org/wiki/Packaging/DistTag
[+] build root is correct. %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) [+] license field matches the actual license. [+] license is open source-compatible. [+] latest version is being packaged. [+] BuildRequires are proper. [+] rpmlint is silent. [+] no duplicates in %files. [+] file permissions are appropriate. [+] compiler flags are appropriate. [+] %clean is present. [+] package builds in mock (rawhide). [+] package installs properly.
Please, fix these two errors and provide me with new spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
sergio.pasra@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo?(sergio.pasra@gmail| |.com) |
------- Additional Comments From sergio.pasra@gmail.com 2007-10-28 16:55 EST ------- The code is taken directly from the subversion repository. Although the last released tarball is from 2004, the subversion repo has been updated since then.
I have added the dist tag to the specfile:
Spec URL: http://sergiopr.fedorapeople.org/tkimg.spec SRPM URL: http://sergiopr.fedorapeople.org/tkimg-1.3-0.3.20071018svn.fc7.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
------- Additional Comments From mmahut@redhat.com 2007-10-29 03:34 EST ------- APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
sergio.pasra@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From sergio.pasra@gmail.com 2007-10-29 10:20 EST ------- New Package CVS Request ======================= Package Name: tkimg Short Description: More Image Formats for Tk Owners: sergiopr Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From a.badger@gmail.com 2007-10-29 14:13 EST ------- Hi Sergio, when you make a checkout from upstream's revision control system you need to follow these guidelines so that other people can duplicate your checkout: http://fedoraproject.org/wiki/Packaging/SourceURL#RevisionControl
You can make those changes once you've imported the source but please do so before you build the package. Thanks!
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
sergio.pasra@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From sergio.pasra@gmail.com 2007-10-29 19:07 EST ------- I have done as you say, thank you
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
sergio.pasra@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From sergio.pasra@gmail.com 2008-07-16 15:36 EST ------- Package Change Request ====================== Package Name: tkimg New Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tkimg - More Image Formats for Tk
https://bugzilla.redhat.com/show_bug.cgi?id=352741
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-07-16 20:09 EST ------- cvs done.
package-review@lists.fedoraproject.org