[Bug 1223440] New: Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Bug ID: 1223440
           Summary: Review Request: nodejs-string_decoder - The
                    string_decoder module from Node core
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://ralph.fedorapeople.org//nodejs-string_decoder.spec
SRPM URL:
http://ralph.fedorapeople.org//nodejs-string_decoder-0.10.31-1.fc22.src.rpm

Description:
The string_decoder module from Node core.

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #1 from Ralph Bean  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=9806646

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #2 from Parag AN(पराग)  ---
Review:

+ mock build is successful for F23 x86_64

- rpmlint on generated rpms gave output
nodejs-string_decoder.noarch: W: incoherent-version-in-changelog 0.11.10-0.1.1
['0.10.31-1.fc23', '0.10.31-1']
nodejs-string_decoder.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ License is "MIT" which is valid and included in LICENSE file

+ Source verified with upstream as sha256sum
tarball in srpm:
3e6e6ffeafe6157eb2278a909afc0b845234b13446dca8a9518c2b79b9c22086
upstream tarball:
3e6e6ffeafe6157eb2278a909afc0b845234b13446dca8a9518c2b79b9c22086

Suggestions:
1) Group tag is not even needed on EPEL6 so can be removed safely.

2) I have seen missing files in source archive from npm repository. This
package also if using source from npm repository you will not get extra files
like test cases. Either you can ask upstream to include it in and release new
tarball or use github release tarball.

For this package I don't see recent release in 0.10.x series tagged on github.
So, good to ask upstream to include test files or else remove test related
lines in spec file.

3) Maybe you want to drop following macro as we no longer support < F20
releases.
%if 0%{?fedora} >= 19

4) Use %license macro for LICENSE

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #3 from Ralph Bean  ---
I filed an issue with upstream to ask them to include the tests in future
releases:  https://github.com/substack/string_decoder/issues/3

And here's a new release that should take care of everything else:

Spec URL: http://threebean.org/rpm/SPECS/nodejs-string_decoder.spec
SRPM URL:
http://threebean.org/rpm/SRPMS/nodejs-string_decoder-0.10.31-2.fc22.src.rpm

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Parag AN(पराग)  ---
Looks good now.

APPROVED.

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Ralph Bean  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #5 from Ralph Bean  ---
New Package SCM Request
=======================
Package Name: nodejs-string_decoder
Short Description: The string_decoder module from Node core
Upstream URL: https://npmjs.org/package/string_decoder
Owners: ralph
Branches: f21,f20,f19,epel7
InitialCC:

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #7 from Ralph Bean  ---
I somehow forgot f22.  :(

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Ralph Bean  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs+                 |fedora-cvs?

--- Comment #8 from Ralph Bean  ---
Package Change Request
======================
Package Name: nodejs-string_decoder
New Branches: f22
Owners: ralph
InitialCC:

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #9 from Fedora Update System  ---
nodejs-string_decoder-0.10.31-2.fc21 has been submitted as an update for Fedora
21.
https://admin.fedoraproject.org/updates/nodejs-string_decoder-0.10.31-2.fc21

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #10 from Fedora Update System  ---
nodejs-string_decoder-0.10.31-2.fc20 has been submitted as an update for Fedora
20.
https://admin.fedoraproject.org/updates/nodejs-string_decoder-0.10.31-2.fc20

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #11 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #12 from Fedora Update System  ---
nodejs-string_decoder-0.10.31-2.fc22 has been submitted as an update for Fedora
22.
https://admin.fedoraproject.org/updates/nodejs-string_decoder-0.10.31-2.fc22

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

Ralph Bean  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2015-05-23 08:35:03

--- Comment #13 from Ralph Bean  ---
Updates and buildroot overrides created.

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #14 from Fedora Update System  ---
nodejs-string_decoder-0.10.31-2.fc20 has been pushed to the Fedora 20 stable
repository.

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #15 from Fedora Update System  ---
nodejs-string_decoder-0.10.31-2.fc22 has been pushed to the Fedora 22 stable
repository.

[Bug 1223440] Review Request: nodejs-string_decoder - The string_decoder module from Node core

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223440

--- Comment #16 from Fedora Update System  ---
nodejs-string_decoder-0.10.31-2.fc21 has been pushed to the Fedora 21 stable
repository.