[Bug 2028702] New: Review Request: ansible-collection-community-docker - Ansible modules and plugins for working with Docker
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Bug ID: 2028702 Summary: Review Request: ansible-collection-community-docker - Ansible modules and plugins for working with Docker Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: gotmax@e.email QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/main/an...
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9157/79529157/ansible-collect...
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=79529100
Description: ansible-collection-community-docker provides the community.docker Ansible collection. The collection includes Ansible modules and plugins for working with Docker.
Fedora Account System Username: gotmax23
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |kevin@scrye.com
--- Comment #1 from Maxwell G gotmax@e.email --- I have CC'd @kevin, the maintainer of Ansible in Fedora. Kevin, are you able/willing to review this package?
Thanks, Maxwell
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #2 from Maxwell G gotmax@e.email --- Spec URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/main/an...
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9826/79529826/ansible-collect...
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=79529825
Rpmlintrc URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/main/an...
Git repository URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker
Please see https://src.fedoraproject.org/rpms/ansible/pull-request/19#comment-90820 for an explanation from an Ansible developer for why to ignore `E: non-executable-script` in Ansible collections.
Please also ignore the following spurious rpmlintrc warnings:
``` ansible-collection-community-docker.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-community-docker.src: W: invalid-url URL %{ansible_collection_url} ```
This macro is included in `ansible-core` and is expanded at build time.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #3 from Maxwell G gotmax@e.email --- I updated the specfile to the latest upstream version.
Spec URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/main/an...
SRPM URL: https://download.copr.fedorainfracloud.org/results/gotmax23/gotmax23_copr/fe...
Rpmlintrc URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/main/an...
Git repository URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker
Please see https://src.fedoraproject.org/rpms/ansible/pull-request/19#comment-90820 for an explanation from an Ansible developer for why to ignore `E: non-executable-script` in Ansible collections.
Please also ignore the following spurious rpmlintrc warnings:
``` ansible-collection-community-docker.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-community-docker.src: W: invalid-url URL %{ansible_collection_url} ```
This macro is included in `ansible-core` and is expanded at build time.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #4 from Maxwell G gotmax@e.email --- For the reviewer's convenience, here is a link to the output from `fedora-review` from Copr: https://download.copr.fedorainfracloud.org/results/gotmax23/reviews/fedora-r...
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |code@musicinmybrain.net Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |code@musicinmybrain.net
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== Issues =====
- This
BuildRequires: ansible-core >= 2.11.0
would better be written without the version,
BuildRequires: ansible-core
since
Versioned dependencies (build-time or runtime) SHOULD ONLY be used when actually necessary to guarantee that the proper version of a package is present. If a versioned dependency would be satisfied by a version present in three previous Fedora releases then a versioned dependency is not needed and a regular unversioned dependency SHOULD be used instead.
and ansible-core is >= 2.11.0 in F34–F36.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependen...
- Version 2.1.1 was released less than a day ago. Please update to the latest version.
- https://src.fedoraproject.org/rpms/ansible/pull-request/19#comment-90820 explains why it’s correct for the plugin modules to have shebangs even though they are not executable (an incredibly weird situation, but I’ll take it at face value).
However, there is still a problem in that the shebangs all use the unversioned Python interpreter /usr/bin/python. A nice way to fix this is to add
BuildRequires: python3-devel
and then, in %prep,
%py3_shebang_fix .
- If it is possible to run any of the tests, you should do so. If not (for example, because they require network access or administrative privileges), it would be helpful to add a comment where the %check section would be, or above the build conditional, explaining this, so it’s clear that not running the tests isn’t simply an oversight.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 47 files have unknown license. Detailed output of licensecheck in /home/reviewer/2028702-ansible-collection- community-docker/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/ansible/collections/ansible_collections/community(ansible- collection-community-general, ansible-collection-community-kubernetes, ansible-collection-community-mysql)
Appropriate directory co-ownership among packages that do not have dependency relationships.
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines
(except as noted)
[x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged.
Version 2.1.1 is available.
[x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass.
Please verify whether any tests can be run.
[x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/ansible-collections/community.docker/archive/2.0.2/commun... : CHECKSUM(SHA256) this package : a98a6fa0b97d34e824fa72f46f421cffd82f2bdda68ea4f47aaff5b596261fd5 CHECKSUM(SHA256) upstream package : a98a6fa0b97d34e824fa72f46f421cffd82f2bdda68ea4f47aaff5b596261fd5
Requires -------- ansible-collection-community-docker (rpmlib, GLIBC filtered): (ansible >= 2.9.0 or ansible-core >= 2.11.0)
Provides -------- ansible-collection-community-docker: ansible-collection(community.docker) ansible-collection-community-docker
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2028702 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, SugarActivity, R, fonts, Perl, Ocaml, Python, PHP, Java, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
ansible-collection-community-docker.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/current_container_facts.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_compose.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_config.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container_exec.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_host_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image_load.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_login.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_network.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_network_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_node.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_node_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_plugin.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_prune.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_secret.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack_task_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_service.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_service_info.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_volume.py 644 /usr/bin/python ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_volume_info.py 644 /usr/bin/python ansible-collection-community-docker.src: W: invalid-url URL %{ansible_collection_url} ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/doc/ansible-collection-community-docker/CHANGELOG.rst /usr/share/ansible/collections/ansible_collections/community/docker/CHANGELOG.rst ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-community-docker/COPYING /usr/share/ansible/collections/ansible_collections/community/docker/COPYING ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/doc/ansible-collection-community-docker/README.md /usr/share/ansible/collections/ansible_collections/community/docker/README.md 2 packages and 0 specfiles checked; 27 errors, 5 warnings, 27 badness; has taken 0.1 s
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #6 from Maxwell G gotmax@e.email --- Spec URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/0781e64... SRPM URL: https://download.copr.fedorainfracloud.org/results/gotmax23/reviews/fedora-r... Diff: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/commit/0781e... Fedora Review URL: https://download.copr.fedorainfracloud.org/results/gotmax23/reviews/fedora-r...
I implemented your changes and switched to the new `ansible-packaging` which now contains the ansible macros and dep generators. I added a note about the tests. None of the `ansible-collection-*` packages or the `ansible` collection bundle currently run tests, but we are working on it. As it's not a hard requirement, I don't think it should block the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #7 from Maxwell G gotmax@e.email --- I have updated this to the latest version. Ben, are you able to finish up the review?
Spec URL: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/blob/78ce6ed... SRPM URL:https://download.copr.fedorainfracloud.org/results/gotmax23/reviews/fedora-r... Diff: https://git.sr.ht/~gotmax23/ansible-collection-community-docker/commit/78ce6... Fedora Review URL: https://download.copr.fedorainfracloud.org/results/gotmax23/reviews/fedora-r...
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net)
--- Comment #8 from Ben Beasley code@musicinmybrain.net --- Yes, I’ll revisit this ASAP.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) |
--- Comment #9 from Ben Beasley code@musicinmybrain.net --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== Notes =====
- https://src.fedoraproject.org/rpms/ansible/pull-request/19#comment-90820 explains why it’s correct for the plugin modules to have shebangs even though they are not executable (an incredibly weird situation, but I’ll take it at face value).
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 49 files have unknown license. Detailed output of licensecheck in /home/reviewer/2028702-ansible-collection- community-docker/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/ansible/collections/ansible_collections/community(ansible- collection-community-rabbitmq, ansible-collection-community- kubernetes, ansible-collection-community-general, ansible-collection- community-mysql)
Appropriate directory co-ownership among packages that do not have dependency relationships.
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/ansible-collections/community.docker/archive/2.3.0/commun... : CHECKSUM(SHA256) this package : 9f0395ff26d00feb3d0eddbc003b92ada0a4923d6d460345d399c31ea8337c41 CHECKSUM(SHA256) upstream package : 9f0395ff26d00feb3d0eddbc003b92ada0a4923d6d460345d399c31ea8337c41
Requires -------- ansible-collection-community-docker (rpmlib, GLIBC filtered): ansible-core
Provides -------- ansible-collection-community-docker: ansible-collection(community.docker) ansible-collection-community-docker
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2028702 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, Python, SugarActivity, R, Ocaml, C/C++, PHP, fonts, Haskell, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
ansible-collection-community-docker.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/current_container_facts.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_compose.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_config.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container_exec.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_container_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_host_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_image_load.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_login.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_network.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_network_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_node.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_node_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_plugin.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_prune.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_secret.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_stack_task_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_service.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_swarm_service_info.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_volume.py 644 /usr/bin/python3 ansible-collection-community-docker.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/community/docker/plugins/modules/docker_volume_info.py 644 /usr/bin/python3 ansible-collection-community-docker.src: W: invalid-url URL %{ansible_collection_url} ansible-collection-community-docker.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/community/docker/.package_note-ansible-collection-community-docker-2.3.0-1.fc37.x86_64.ld ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/doc/ansible-collection-community-docker/CHANGELOG.rst /usr/share/ansible/collections/ansible_collections/community/docker/CHANGELOG.rst ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-community-docker/COPYING /usr/share/ansible/collections/ansible_collections/community/docker/COPYING ansible-collection-community-docker.noarch: W: files-duplicate /usr/share/doc/ansible-collection-community-docker/README.md /usr/share/ansible/collections/ansible_collections/community/docker/README.md 2 packages and 0 specfiles checked; 27 errors, 6 warnings, 27 badness; has taken 0.2 s
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #10 from Maxwell G gotmax@e.email --- Thank you for the review, Ben
https://pagure.io/releng/fedora-scm-requests/issue/43542
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-community-docker
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b43f50dfcf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b43f50dfcf
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |ansible-collection-communit | |y-docker-2.3.0-1.fc37
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-04-07 22:28:53
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b43f50dfcf has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-48dafaa351 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-48dafaa351
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c6b08ef8c8 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c6b08ef8c8
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a49cd0fddd has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a49cd0fddd
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-48dafaa351 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-48dafaa351` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-48dafaa351
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c6b08ef8c8 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-c6b08ef8c8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c6b08ef8c8
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a49cd0fddd has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-a49cd0fddd` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a49cd0fddd
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a49cd0fddd has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c6b08ef8c8 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2028702
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-48dafaa351 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com