https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Bug ID: 2391155 Summary: Review Request: umoci - Modifies Open Container Images Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rcallicotte@mailbox.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rcallicotte.fedorapeople.org/umoci.spec SRPM URL: https://rcallicotte.fedorapeople.org/umoci-0.5.0-1.fc44.src.rpm
Description: umoci (pronounced /uːmoˈʨi/ or approximately "oo-mo-tchee") is a reference implementation of the OCI image specification and provides users with the ability to create, manipulate, and otherwise interact with container images. It is designed to be as small and unopinonated as possible, so as to act as a foundation for larger systems to be built on top of.
Fedora Account System Username: rcallicotte
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #1 from Robby Callicotte rcallicotte@mailbox.org --- Successful scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=136459446
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Status|NEW |ASSIGNED
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- What's holding up creating man pages? I see you have a build dependency on go-md2man, so I assume that's what it uses for man pages?
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #4 from Robby Callicotte rcallicotte@mailbox.org --- Sorry, I was rushing to get the request opened on this... Updated with manpages. The upstream project provides gpg keyring information. I was attempting to add that to the package but nothing I tried seemed to work. I also reviewed OpenSuse Build Service[1], but it looks like that is not really doing a true verification of the keyring, just a sha256sum comparison. So I decided to skip over that for now.
Updated SPEC: https://rcallicotte.fedorapeople.org/umoci.spec Updated SRPM: https://rcallicotte.fedorapeople.org/umoci-0.5.0-1.fc44.src.rpm
[1] - https://build.opensuse.org/projects/openSUSE:Factory/packages/umoci/files/um...
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2105426 --> https://bugzilla.redhat.com/attachment.cgi?id=2105426&action=edit The .spec file difference from Copr build 9493539 to 9510007
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #6 from Neal Gompa ngompa13@gmail.com ---
export LDFLAGS="-X %{goipath}.version=%{version}"
This should probably be "%{version}-%{release}".
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Also, isn't the variable GO_LDFLAGS?
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #8 from Robby Callicotte rcallicotte@mailbox.org --- (In reply to Neal Gompa from comment #6)
export LDFLAGS="-X %{goipath}.version=%{version}"
This should probably be "%{version}-%{release}".
After compiled, this will show up like below: <mock-chroot> sh-5.3# ./umoci -v umoci version 0.5.0-1.fc44
This appears to be somewhat similar to how the Open Suse package is built:
export VERSION="$(cat ./VERSION)" if [ "$VERSION" != "%{version}" ]; then # Append "_suse" if the version is not an upstream one. VERSION="%{version}_suse" fi
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #9 from Robby Callicotte rcallicotte@mailbox.org --- (In reply to Neal Gompa from comment #7)
Also, isn't the variable GO_LDFLAGS?
You're right. I double-checked the go-rpm-macros and LDFLAGS is deprecated in favor of GO_LDFLAGS. I have updated the spec with these changes.
Updated SPEC: https://rcallicotte.fedorapeople.org/umoci.spec Updated SRPM: https://rcallicotte.fedorapeople.org/umoci-0.5.0-1.fc44.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2105541 --> https://bugzilla.redhat.com/attachment.cgi?id=2105541&action=edit The .spec file difference from Copr build 9510007 to 9513993
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer.
If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it.
[fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com
--- Comment #12 from Jakub Kadlčík jkadlcik@redhat.com --- When processing this ticket, the Fedora Review Service failed with a traceback instead of commenting. I reported an issue for that: https://github.com/FrostyX/fedora-review-service/issues/70
It built in Copr successfully though https://copr.fedorainfracloud.org/coprs/g/fedora-review/fedora-review-239115...
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #13 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package correctly identifies licensing and declares bundled dependencies - You might want to check with the Go SIG on how to do this in a more automatic fashion, I think they have a dependency generator for this stuff now * Package builds and installs * No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #14 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/umoci
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-123d72b639 (umoci-0.5.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-123d72b639
https://bugzilla.redhat.com/show_bug.cgi?id=2391155
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2025-11-28 22:40:14
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-123d72b639 (umoci-0.5.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com