Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Summary: Review Request: libgdither - Library for applying dithering to PCM audio sources Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kwizart@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://kwizart.fedorapeople.org/SPECS/libgdither.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/libgdither-0.6-1.fc8.kwizart.src.rpm Description: Library for applying dithering to PCM audio sources
This package has a fix that will allow gavl to use a shared version instead of an internal one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libgdither - Library for applying dithering to PCM audio sources
https://bugzilla.redhat.com/show_bug.cgi?id=454888
kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |456242 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@jcomserv.net AssignedTo|nobody@fedoraproject.org |limb@jcomserv.net Flag| |fedora-review?
--- Comment #1 from Jon Ciesla limb@jcomserv.net 2008-10-10 12:26:49 EDT --- rpmlint on srpm clean.
rpmlint on rpms:
libgdither-devel.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
Anything to put here?
License, naming, macros, scripts, all good. Full review is very clean. No BR issues evident after a mock build.
Other than the one minor bit above, we're ready to rock and/or roll.
I'll use my copies to start reviewing gavl.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #2 from Nicolas Chauvet (kwizart) kwizart@gmail.com 2008-10-16 10:40:29 EDT --- Hello, and sorry for the late answear
I think the whole framework could have a issue. Specially on lib64 system (mutlilibs systems using /usr/lib64 as a standard path for libs). And maybe we have a problem with -FPIC not been used on x86 system. (light library can avoid using Position independant Code for shared libs, but it cannot be prelinked and can gives selinux denials)
I'm still searching for package to test frei0r-plugins usability (for now i'm using my own package of LiVES but mlt could be a good candidate)
I will use my public/experimental repository for testing the whole framework against rawhide x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #3 from Zarko zarko.pintar@gmail.com 2009-03-19 03:45:18 EDT --- Hello,
What happened with this packet?
I want prepare frei0r-plugins for Fedora but I need this packet as dependency.
I prepare this packet for Fedora 10 so please, if you want to see my spec and src:
http://dl.getdropbox.com/u/728801/kdenlive/sources/libgdither.spec
http://dl.getdropbox.com/u/728801/kdenlive/sources/libgdither-0.6-2.fc10.src...
Please see them.
kind regards, Zarko
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #4 from Nicolas Chauvet (kwizart) kwizart@gmail.com 2009-03-19 05:59:31 EDT --- This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
But since ExcludeArch is undeeded, as the package will build at least on our primary arches; Il will stay with:
Spec URL: http://kwizart.fedorapeople.org/SPECS/libgdither.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/libgdither-0.6-1.fc8.kwizart.src.rpm Description: Library for applying dithering to PCM audio sources
@Jon Any news from your side ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #5 from Zarko zarko.pintar@gmail.com 2009-03-19 06:38:19 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
--- Comment #6 from Zarko zarko.pintar@gmail.com 2009-03-19 06:39:08 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #5 from Zarko zarko.pintar@gmail.com 2009-03-19 06:38:19 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
--- Comment #6 from Zarko zarko.pintar@gmail.com 2009-03-19 06:39:08 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #5 from Zarko zarko.pintar@gmail.com 2009-03-19 06:38:19 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
--- Comment #6 from Zarko zarko.pintar@gmail.com 2009-03-19 06:39:08 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
--- Comment #7 from Zarko zarko.pintar@gmail.com 2009-03-19 06:41:02 EDT --- (In reply to comment #4)
This package is still waiting for a reviewer.
@Zarko You aren't a sponsored packager at this time, so you need to follow this: https://fedoraproject.org/wiki/PackageMaintainers/Join
Yes, because this packets are my first job and waiting so long.
At this moment I do not have any new packet for build so I do not know how I can be sponsored packager without completely new packets?
BTW, Why these packets are waiting so long for review?
(I mean on gavl and frei0r-plugins, too)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #9 from Jon Ciesla limb@jcomserv.net 2009-03-19 09:43:38 EDT --- Nicolas, I'll finish this review shortly, and move from there.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #10 from Jon Ciesla limb@jcomserv.net 2009-03-19 10:47:44 EDT --- Looks good still, is there documentation that could go in -devel? And are the issues you raised in #2 resolved?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #11 from Nicolas Chauvet (kwizart) kwizart@gmail.com 2009-03-23 21:47:51 EDT --- I'm not worried about libgdither itself, I was able to link gavl with libgdither from my own repository (using mock). One can use the mock config files to start testing the packages built from my repository. What will need more looks is the way the targetted binary (I was testing LiVES) will behaves with the frei0r-plugins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2009-03-24 08:29:23 EDT --- Ok, then APPROVED. I'll move on down the chain.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
--- Comment #13 from Nicolas Chauvet (kwizart) kwizart@gmail.com 2009-03-24 08:41:36 EDT --- New Package CVS Request ======================= Package Name: libgdither Short Description: Library for applying dithering to PCM audio sources Owners: kwizart Branches: F-10 F-9 EL-5 Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #14 from Kevin Fenzi kevin@tummy.com 2009-03-24 13:21:35 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454888
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |496433(RussianFedora)
package-review@lists.fedoraproject.org