[Bug 223422] New: Review Request: mrxvt - Multi-tabbed terminal emulator. - package-review

Red Hat Bugzilla

Thursday, 18 January Thu, 18 Jan

9:57 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 gnome(a)dux-linux.org changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: mrxvt - |Review Request: mrxvt - |Multi-tabbed terminal |Multi-tabbed terminal |emulator. |emulator. BugsThisDependsOn| |177841 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Friday, 19 January Fri, 19 Jan

5 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|177841 | OtherBugsDependingO| |177841 nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

10:52 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-03-27 23:52 EST ------- Thanks for the tips. I've been in contact with the maintainer and need to discuss some possible source tree modifications. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

10:55 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?(gnome@dux- | |linux.org) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Saturday, 19 May Sat, 19 May

5:32 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-05-19 06:32 EST ------- Again ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Monday, 21 May Mon, 21 May

6:11 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-05-21 07:11 EST ------- Created an attachment (id=155086) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=155086&action=...) Latest RPM -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

7:29 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-05-21 08:29 EST ------- We cannot check what is the problem until the spec/srpm is provided. Please provide the URL where we can download your newest srpm (and please don't "attach" srpm to bugzilla) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

9:29 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-05-21 22:29 EST ------- OK I've tried to implement a few things Jeremy suggested but I'm running into some issues... You can find the latest build, spec file and desktop file here... http://littlehat.homelinux.org:8000/FEDORA/mrxvt/current/ latest rpmlint... [@laptop FEDORA]$ rpmlint /usr/src/redhat/RPMS/i386/mrxvt-05b-1.i386.rpm E: mrxvt description-line-too-long Mrxvt (previously named materm) is based on rxvt version 2.7.11 CVS and aterm. mrxvt aims to be independent of a user's desktop environment. W: mrxvt wrong-file-end-of-line-encoding /usr/share/doc/mrxvt/scripts/mrxvt.vbs W: mrxvt non-standard-dir-in-usr man W: mrxvt non-standard-dir-in-usr etc I took the latest svn snapshot from sourceforge and built this rpm, but it still has some problems... In particular I think the files in /share and /doc need to be moved around (those are the src tree modifications I alluded to earlier). Due to my inexperience with rpm building and the sparse (somewhat unreliable) info on building them on the fedora wiki, I'm not comfortable recommending these changes to the maintainer without specific reasons; I've conversed with the maintainer once and only hinted that the source tree might require changes -- beyond that I've been busy with school and now am on summer break, and ready to further that discussion with him. Any ideas? suggestions? Thanks for the help. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Thursday, 31 May Thu, 31 May

6:06 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-05-31 07:06 EST ------- OK. I've followed the guidelines and built new rpms. Please find the new rpms, spec file, and desktop file here: http://littlehat.homelinux.org:8000/FEDORA/mrxvt/0.5.2-1/ Also, here is the latest rpmlint: [a@laptop mrxvt_devel]$ sudo rpmlint /usr/src/redhat/RPMS/i386/mrxvt-0.5.2-1.i386.rpm W: mrxvt incoherent-version-in-changelog 1 0.5.2-1 W: mrxvt wrong-file-end-of-line-encoding /usr/share/doc/mrxvt/scripts/mrxvt.vbs W: mrxvt non-conffile-in-etc /etc/mrxvt/mrxvtrc.sample W: mrxvt non-conffile-in-etc /etc/mrxvt/mrxvtrc W: mrxvt non-conffile-in-etc /etc/mrxvt/submenus.menu W: mrxvt non-conffile-in-etc /etc/mrxvt/default.menu I believe the changelog version warning is OK considering the sources are for 0.5.2 and we don't have a minor release number (Am I incorrect?). The end-of-line-encoding is because it's a visual basic script -- this should be fine b/c it shouldn't kill the build process, correct? The non-conffile errors...is that a big deal??? considering a user should know where to grab example configuration information? I know it doesn't conform to the LSB. Is there a precedent for including this? or should they be moved? If they need to be moved, can someone suggest a proper location? As always, thanks for the help. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Sunday, 3 June Sun, 3 Jun

3:18 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-06-03 16:18 EST ------- Latest rpmlint: [a@laptop mrxvt_devel]$ rpmlint /usr/src/redhat/RPMS/i386/mrxvt-0.5.2-1.2.i386.rpm W: mrxvt incoherent-version-in-changelog 1.2 0.5.2-1.2 W: mrxvt wrong-file-end-of-line-encoding /usr/share/doc/mrxvt/scripts/mrxvt.vbs Latest spec and rpms can be found here (I'm trying to create a "stable" branch rpm too.): http://littlehat.homelinux.org:8000/FEDORA/mrxvt/current/ I believe I implemented all you asked with two exceptions: 1) Directory ownership -- I'm not sure how you'd like me to, but I will continue to look for examples. 2) I'm still getting a changelog "barf." Not sure how to go about fixing this, despite incrementing what I believe to be "correct." As always, thanks for the help. Now, what to do about that pesky vb script? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Monday, 4 June Mon, 4 Jun

1:44 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-04 02:44 EST ------- Well, for 0.5.2-1.2: * Souce URL - The format of URL for Source0 and Patch1 is still incorrect. For sources on sourceforge.net, again please refer to http://fedoraproject.org/wiki/Packaging/SourceURL (especially, the section "Sourceforge.net") * Directory ownership - What I want to say is that the directory %{_sysconfdir}/mrxvt/ is not owned by this package. ------------------------------------------------- [root@localhost ~]# LANG=C rpm -qf /etc/mrxvt file /etc/mrxvt is not owned by any package ------------------------------------------------- You must add: ----------------------------------------------- %dir %{_sysconfdir}/mrxvt ----------------------------------------------- to %files list. i.e. You must use: ----------------------------------------------- %dir %{_sysconfdir}/%{name} %config(noreplace) %{_sysconfdir}/%{name}/default.menu %config(noreplace) %{_sysconfdir}/%{name}/mrxvtrc %config(noreplace) %{_sysconfdir}/%{name}/mrxvtrc.sample %config(noreplace) %{_sysconfdir}/%{name}/submenus.menu ----------------------------------------------- ... or just: ----------------------------------------------- %config(noreplace) %{_sysconfdir}/%{name}/ ----------------------------------------------- NOTE: -------------------------------------------- %files foo/ -------------------------------------------- (where foo/ is a directory) means the directory foo/ itself and all files/directories/etc.. under foo/, while -------------------------------------------- %files %dir foo/ -------------------------------------------- means the directory foo/ only. - Also, the directory %{_datadir}/doc/%{name}/scripts/ should be owned by this package. * Macros - "%{_prefix}/share" should be %{_datadir}. - And, --------------------------------------------- %{_prefix}/share/pixmaps/mrxvt-csh.png %{_prefix}/share/pixmaps/mrxvt-csh.xpm %{_prefix}/share/pixmaps/mrxvt-root.png %{_prefix}/share/pixmaps/mrxvt-root.xpm %{_prefix}/share/pixmaps/mrxvt.png %{_prefix}/share/pixmaps/mrxvt.xpm ---------------------------------------------- can be replaced with ---------------------------------------------- %{_datadir}/pixmaps/%{name}* ---------------------------------------------- * Documentation - And all the files under %{_datadir}/doc/%{name} must be moved to %{_datadir}/doc/%{name}-%{version}. * Unneeded macros, comments - Remove unneeded macros and comments. * It doesn't seem that the macro %enable_trace is used anywhere. * Changelog formats - The correct format is like: ------------------------------------------------------ * Thu May 31 2007 Adam M. Dutko <gnome at dux-linux org> - 0.5.2-1.1 - Updated spec file per suggestions in bug #: 223422 ------------------------------------------------------ - And the release number should be integer + %{?dist}. (although there are some exceptions: please check: "Package Release" of http://fedoraproject.org/wiki/Packaging/NamingGuidelines ) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

6:52 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-06-04 07:52 EST ------- One more thing, the reccomendation of integer + %{?dist} fails on rpmbuild, which is why I did what I did in the spec file for the Release tag. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

11:23 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-04 12:23 EST ------- (In reply to comment #19)

...

1)Source URL -- FIXED 2)Directory Ownership -- FIXED

Okay.

...

3)Documentation -- NOT FIXED

For this, please once remove all files under %{_datadir}/doc/%{name} by: ----------------------------------------------- %install rm -rf $RPM_BUILD_ROOT make DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" install desktop-file-install --vendor=fedora \ --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ %{SOURCE1} rm -rf $RPM_BUILD_ROOT%{_datadir}/doc ------------------------------------------------ and later add the proper documents by: ------------------------------------------------ %files %defattr(-,root,root,-) %doc doc/README* doc/*.txt* %doc share/scripts/ %doc AUTHORS ChangeLog COPYING NEWS README TODO ------------------------------------------------ Here two modification is added: * Timestamps - This installs some text/image files which are not modified or created during build stage and keeping timestamps on these files is recommended. For this package, this can be done by adding 'INSTALL=%{__install} -p' * Unneeded documents - "INSTALL" file is for people who wants to rebuild this by themselves and so it is not needed for rpm file.

...

4)Unneeded Macros -- FIXED 5)Changelog Formats -- FIXED

- Well, please write a bit more precisely.. not just "updated spec file"... (In reply to comment #20)

...

One more thing, the reccomendation of integer + %{?dist} fails on rpmbuild, which is why I did what I did in the spec file for the Release tag.

- What do you mean by this? Usually release number should be: ----------------------------------------------- Release: 2%{?dist} ----------------------------------------------- and the corresponding %changelog entry is: ----------------------------------------------- * Sun Jun 3 2007 Adam M. Dutko <gnome at dux-linux org> - 0.5.2-2 - <some description> ------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Tuesday, 5 June Tue, 5 Jun

11:35 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-05 12:35 EST ------- (In reply to comment #22)

...

Latest rpmlint: [a@laptop mrxvt_devel]$ rpmlint /usr/src/redhat/RPMS/i386/mrxvt-0.5.2-1.4.i386.rpm W: mrxvt wrong-file-end-of-line-encoding /usr/share/doc/mrxvt-0.5.2/scripts/mrxvt.vbs

Fix this by: -------------------------------------------------- sed -i 's|\r||' scripts/mrxvt.vbs -------------------------------------------------- in %prep stage.

...

With regard to the integer + %{?dist} comment, I assume the current way I'm using it is correct?

Still not. What I wanted to say is that please write release number as ------------------------------------------ Release: 2%{?dist} ------------------------------------------ or ------------------------------------------ Release: 3%{?dist} ------------------------------------------ and not ------------------------------------------ Release: 1%{?dist}.4 ------------------------------------------

...

I do need to do three things: 1) Verify the buildrequires again...

mockbuild succeeds, however there seems to be some missing BR. ( I attach the difference )

...

2) Verify I can use this spec for build from the svn repository.

I don't know what you want to say here, but please don't use svn version source if possible.

...

3) Apply a new patch from the maintainer that fixes a bug.

Also I don't know what you want to say here... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

11:41 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-05 12:41 EST ------- Created an attachment (id=156243) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156243&action=...) normal rpmbuild log of mrxvt-0.5.2-1.fc8.4 And normal rpmbuild log: The important difference is: --------------------------------------------------- @@ -397,10 +83,10 @@ checking for XRegisterIMInstantiateCallback in -lX11... yes checking for SmcOpenConnection in -lSM... yes checking for IceConnectionNumber in -lICE... yes -checking for utempter_add_record in -lutempter... no +checking for utempter_add_record in -lutempter... yes checking for XpmCreateImageFromXpmImage in -lXpm... yes -checking for jpeg_read_header in -ljpeg... no -checking for png_check_sig in -lpng... no +checking for jpeg_read_header in -ljpeg... yes +checking for png_check_sig in -lpng... yes checking for XRenderCreatePicture in -lXrender... yes checking for fontconfig/fontconfig.h... yes checking for X11/Xft/Xft.h... yes @@ -617,7 +303,7 @@ Support wtmp records : yes Support lastlog records : yes Support X session manager : yes -Use utempter library : no +Use utempter library : yes Visual features: Support line space : yes @@ -632,8 +318,8 @@ Background features: Background image : yes XPM background image : yes -JPEG background image : no -PNG background image : no +JPEG background image : yes +PNG background image : yes Transparent background : yes Background tinting : yes (XRender) --------------------------------------------------- Perhaps libpng-devel, libjpeg-devel, libutempter-devel is missing for BR. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

9:25 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-06-12 22:25 EST ------- Latest rpmlint: [a@laptop mrxvt_devel]$ rpmlint /usr/src/redhat/RPMS/i386/mrxvt-0.5.2-6.i386.rpm [a@laptop mrxvt_devel]$ Nothing is there! YEAH!!!!

...

2) Verify I can use this spec for build from the svn repository.

I am going to start creating nightly rpm builds for the maintainer. This is "off-topic." Just wanted to let you know it's a work in progress.

...

3) Apply a new patch from the maintainer that fixes a bug.

There are a few bug fixes the maintainer would like added. Again, I will do this when I get the nightly builds running. ** I've added the extra build requires. ** I've added more comments and incremented the release number accordingly. ** I've fixed the end of line-encoding issue in the %prep section. Everything is up on my site: http://littlehat.homelinux.org:8000/FEDORA/mrxvt/current/0.5.2/ Please let me know if there are other outstanding issues that need to be corrected? and if not, what steps need to be taken to get this included in the F8 build process. Thank you for all the help. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Wednesday, 13 June Wed, 13 Jun

12:10 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-13 13:10 EST ------- (This review request is currently blocked by desktop-file-utils 0.13 issue) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Friday, 15 June Fri, 15 Jun

1:13 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-15 02:13 EST ------- Created an attachment (id=157060) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=157060&action=...) mock build log of mrxvt 0.5.2-6 on F-devel i386 The rebuild (on F-devel with mock) failed with newer desktop-file-utils (0.13) (Well, I didn't know that) the entry "Version" is the version of "Desktop Entry Standard" you used (see: http://standards.freedesktop.org/desktop-entry-spec/ ), so * This version value has no relation with the version of the application * The value of Version should be either: 0.9.[3-8] or 1.0 * And the Entry Version is *not needed* So please remove the Version entry. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Sunday, 17 June Sun, 17 Jun

10:19 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-17 11:19 EST ------- Created an attachment (id=157223) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=157223&action=...) spec file with some cleanup 0.5.2-8 with %%prep stage some cleanup. Well, now mrxvt is okay. However, as this is NEEDSPONSOR ticket, there is another step before I can approve this. ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few (or no) work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora Extras package review requests which are waiting for someone to review can be checked on: https://bugzilla.redhat.com/bugzilla/buglist.cgi?cmdtype=runnamed&nam... NOTE: FE-NEW blockers are now not complete. Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Monday, 18 June Mon, 18 Jun

9:02 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag|fedora-review? |fedora-review+ ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-06-18 10:02 EST ------- One comment: * Umm.. actually the "review style" is difficult issue. Many reviewers use some check list styles of their own, and it may have the benefit that it may show what the reviewers actually checked. Some other reviewers complain if there is no check list written on the review. However, there are also opinitions that the long verbose list is the same as just a copy/paste and makes it difficult to watch. So while the check list can exist, especially by the time you get used to reviewing, you should put the summary *at the end* to show briefly what the submitter should fix. But the most good way is to try anyway!! Again, reviewing style is somewhat difficult issue and actually there was a discussion about reviewing style (Some said that there should be check lists, some said that it is not needed) Well, ------------------------------------------------------------ This package (mrxvt) is APPROVED by me ------------------------------------------------------------ Please follow the procedure written on http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account" When you requested someone to sponsor you (in the procedure above), please make a note on this bug that you did so. If you want to push this package also on F-7, you also have to check: http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT after the URL above. !! Well, recenctly Fedora package system changed a lot !! If you have some questions, please let me know. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

10:31 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

8:53 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-06-19 21:53 EST ------- New Package CVS Request ======================= Package Name: mrxvt Short Description: multi-tabbed terminal emulator Owners: gnome(a)dux-linux.org Branches: FC6 F7 InitialCC: mtasaka(a)ioa.s.u-tokyo.ac.jp -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Wednesday, 20 June Wed, 20 Jun

12:01 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2007-06-20 01:01 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Friday, 29 June Fri, 29 Jun

9:42 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 gnome(a)dux-linux.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(gnome@dux- | |linux.org) | ------- Additional Comments From gnome(a)dux-linux.org 2007-06-29 10:42 EST -------

...

Would you try to rebuild mrxvt on all branches?

Which branches? I assume FC7-updates-candidate, FC7-updates and etc? CVS import will be done by Monday evening. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Monday, 2 July Mon, 2 Jul

9:02 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-07-02 22:02 EST ------- (In reply to comment #40)

...

For FC-6, FC7 and devel, please.

dist-fc6-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=54654 dist-fc7-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=54673 dist-f8-candidate: *wouldn't let me build for some reason dist-f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=54684 Everything is imported into CVS (devel, F-7, FC-6). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

9:23 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-07-02 22:23 EST ------- On koji buildsys, when rebuild is done properly the entries like below should appear. http://koji.fedoraproject.org/koji/packageinfo?packageID=2157 On plague buildsys the entries like below should appear. http://buildsys.fedoraproject.org/build-status/job.psp?uid=34629 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

10:03 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-07-02 23:03 EST ------- Well, I don't know how to use "koji" command directly and to get the rebuild actually registered to koji buildsys. Would you just try the following? $ cvs co mrxvt $ cd mrxvt/devel $ make tag build -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

7:49 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-07-03 08:49 EST ------- All of the builds were submitted before I left for work. They appear to have built properly, but again, I don't think they're signed properly. I will regenerate my upload/server certs this evening and resubmit them to koji through the CVS build mechanism. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

12:09 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-07-03 13:09 EST ------- (In reply to comment #48)

...

* Well, for F-7 and F-devel, build (on koji) seems to have done properly (by http://koji.fedoraproject.org/koji/packageinfo?packageID=4551 ). - Now for F-7, you have to request to push mrxvt to Fedora 7 updates. (please check:

Update created in bodhi: Release: Fedora 7 Status: pending Type: enhancement ... Requested: push ... Submitted: 2007-07-03 10:03:17 ...

...

http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT ) * For FC-6 (on plague buildsys), I still cannot see your rebuild.

Will fix tonight. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Wednesday, 4 July Wed, 4 Jul

9:21 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-07-04 10:21 EST ------- There is another version of mrxvt (0.4.2) I would like to get included. Do I register another bug? create the spec, then have another package maintainer review it before I can proceed? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

9:55 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-07-04 10:55 EST ------- (In reply to comment #52)

...

(In reply to comment #50) > It is building.... Okay. This FC-6 build is okay.

Great. I'm just waiting for the push to testing to go through in Bodhi; it's still pending.

...

(In reply to comment #51) > There is another version of mrxvt (0.4.2) I would like to get included. First of all, why do you want it?

It's another branch. 0.5.2 is the latest while 0.4.2 is older (less and/or different bugs I presume). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

9:36 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome(a)dux-linux.org 2007-07-05 10:36 EST ------- (In reply to comment #54)

...

I don't think that we should support 0.4.2 - It is old by more than one and the half year - And 9 months is passed since 0.5.2 is released. IMO we should regard 0.5.2 as "stable".

OK. I will maintain an "unsponsored" version of 0.4.2 on my personal site, which I will not push for inclusion into Fedora proper. UPDATE: I'm still waiting on bodhi approval for a testing push. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

9:55 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 gnome(a)dux-linux.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

10:03 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-07-05 11:03 EST ------- Okay. And now you can also post your questions to fedora-devel/maintainers mailing list. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Wednesday, 11 July Wed, 11 Jul

10:20 a.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From updates(a)fedoraproject.org 2007-07-11 11:20 EST ------- mrxvt-0.5.2-9.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

Red Hat Bugzilla

Monday, 7 July Mon, 7 Jul

11:08 p.m.

New subject: [Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/show_bug.cgi?id=223422 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Reply

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Bug 223422] New: Review Request: mrxvt - Multi-tabbed terminal emulator.