[Bug 568148] New: Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-squaremap - SquareMap for wxPython

https://bugzilla.redhat.com/show_bug.cgi?id=568148

Summary: Review Request: python-squaremap - SquareMap for
                    wxPython
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://dmalcolm.fedorapeople.org/python-packaging/python-squaremap.spec
SRPM URL:
http://dmalcolm.fedorapeople.org/python-packaging/python-squaremap-1.0.0-0.1...
Description:
A simple wxPython control to display hierarchic data as a recursive set of
nested squares, each of which represents the relative size of a given child
within its parent.

(used by the RunSnakeRun python profile visualizer, which I'm about to file a
review request for also)

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |568149

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

Thomas Spura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Thomas Spura  2010-02-25 17:31:27 EST ---
Review:

Good:
- name ok
- group ok
- BR/R ok
- macros everywhere
- no *.la
- no libs
- noarch ok
- license ok
- builds in mock
- source match upstream: cef66530225cc63caaf8b878020b333d

Needswork:
- $ rpmlint python-squaremap-1.0.0-0.1.b24.fc12.src.rpm
noarch/python-squaremap-1.0.0-0.1.b24.fc12.noarch.rpm 
python-squaremap.src: W: spelling-error Summary(en_US) wxPython -> python,
Python, diphthong
python-squaremap.src: W: spelling-error %description -l en_US wxPython ->
python, Python, diphthong
python-squaremap.noarch: W: spelling-error Summary(en_US) wxPython -> python,
Python, diphthong
python-squaremap.noarch: W: spelling-error %description -l en_US wxPython ->
python, Python, diphthong
python-squaremap.noarch: W: no-documentation
python-squaremap.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/squaremap/squaremap.py 0644 /usr/bin/env
2 packages and 0 specfiles checked; 1 errors, 5 warnings.

Spelling error is ignoreable, but you need to remove the shebang, because this
file is not intented to run.

- no-documentation: There is no LICENSE file.
  Please query upstream to add one.

- You should be more explicit in %files to be notified, when the egg is not
build:
e.g.
%{python_sitelib}/squaremap
%{python_sitelib}/Squaremap-*.egg-info

__________________________________________________________

This are only minor issues, which I'm sure, you'll fix before importing.

__________________________________________________________

APPROVED

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

--- Comment #2 from Thomas Spura  2010-02-25 17:34:49 EST ---
One thing I like to add:

Group: Development/Libraries would be better...

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

--- Comment #3 from Dave Malcolm  2010-03-02 21:46:25 EST ---
Thanks.

squaremap.py is actually usable as a script, so I gave it executable
permissions instead (it's a simple test when run as "main", you can use it to
view space used by files in a directory).

I've made the other changes you requested; I delete the egg-info during %prep,
and updated %files to verify that it got regenerated:

* Tue Mar  2 2010 David Malcolm  - 1.0.0-0.2.b24%{?dist}
- fix permissions for squaremap.py
- change group to Development/Libraries
- delete prebuilt egg-info, and explicitly list egginfo in %%files stanza to
ensure it is regenerated during the build

I'll email the maintainer about the license.

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Dave Malcolm  2010-03-02 21:47:51 EST ---
New Package CVS Request
=======================
Package Name: python-squaremap
Short Description: SquareMap for wxPython
Owners: dmalcolm
Branches: F-12 F-13
InitialCC:

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

--- Comment #5 from Jason Tibbitts  2010-03-03 19:59:52 EST ---
CVS done (by process-cvs-requests.py).

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

Dave Malcolm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #6 from Dave Malcolm  2010-03-04 15:16:18 EST ---
Imported into CVS

Built into dist-f14 as
http://koji.fedoraproject.org/koji/taskinfo?taskID=2031452

Built into dist-f13 as
http://koji.fedoraproject.org/koji/taskinfo?taskID=2031452

Build into dist-f12 as
http://koji.fedoraproject.org/koji/taskinfo?taskID=2031452

Thanks!

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

--- Comment #7 from Dave Malcolm  2010-03-04 15:21:04 EST ---
Ooops, copy and paste snafu; 
three copies of link above are all of the dist-f14 build

dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2031490
dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2031492

(Though these links are somewhat redundant)

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

--- Comment #8 from Fedora Update System  2010-08-26 12:33:03 EDT ---
python-squaremap-1.0.0-0.2.b24.fc13,RunSnakeRun-2.0.0-0.4.b4.fc13 has been
submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-squaremap-1.0.0-0.2.b24.fc13,R...

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

--- Comment #9 from Fedora Update System  2010-11-05 18:55:22 EDT ---
python-squaremap-1.0.0-0.2.b24.fc13, RunSnakeRun-2.0.0-0.4.b4.fc13 has been
pushed to the Fedora 13 stable repository.  If problems still persist, please
make note of it in this bug report.

[Bug 568148] Review Request: python-squaremap - SquareMap for wxPython

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=568148

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |python-squaremap-1.0.0-0.2.
                   |                            |b24.fc13
         Resolution|NEXTRELEASE                 |ERRATA