[Bug 809503] New: Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: liquibase - Database refactoring tool

https://bugzilla.redhat.com/show_bug.cgi?id=809503

           Summary: Review Request: liquibase - Database refactoring tool
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: dgoodwin(a)rm-rf.ca
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com,
                    package-review(a)lists.fedoraproject.org
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---


Spec URL: http://dgoodwin.fedorapeople.org/liquibase/liquibase.spec
SRPM URL:
http://dgoodwin.fedorapeople.org/liquibase/liquibase-2.0.3-5.fc16.src.rpm
Description: LiquiBase is an open source (Apache 2.0 License),
database-independent library
for tracking, managing and applying database changes. It is built on a simple
premise: All database changes are stored in a human readable yet trackable form
and checked into source control.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809503

Lukáš Zapletal <lzap(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lzap(a)redhat.com
         AssignedTo|nobody(a)fedoraproject.org    |lzap(a)redhat.com

--- Comment #1 from Lukáš Zapletal <lzap(a)redhat.com&gt; 2012-04-13 05:36:44 EDT ---
Hi Devan,

taking for review.

MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1] 

[lzap@lzapx Download]$ rpmlint liquibase-2.0.3-5.fc18.noarch.rpm
liquibase.noarch: W: name-repeated-in-summary C Liquibase
liquibase.noarch: W: spelling-error %description -l en_US trackable ->
traceable, tractable, track able
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-change/liquibase-ext-change.iml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/samples.iml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/liquibase-ext-changewithnestedtags.iml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/src/main/java/liquibase/ext/changewithnestedtags/SampleGrandChild.java
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-sqlgenerator/src/main/java/liquibase/ext/samplesqlgenerator/SampleUpdateGenerator.java
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/changelog.txt
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/src/main/java/liquibase/ext/changewithnestedtags/ChangeWithNestedTags.java
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-sqlgenerator/pom.xml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/src/main/java/liquibase/ext/changewithnestedtags/SampleChild.java
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/pom.xml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-sqlgenerator/liquibase-ext-sqlgenerator.iml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-change/pom.xml
liquibase.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-change/src/main/java/liquibase/ext/changesample/SampleChange.java
liquibase.noarch: W: no-manual-page-for-binary liquibase
1 packages and 0 specfiles checked; 0 errors, 16 warnings.

[lzap@lzapx Download]$ rpmlint liquibase-2.0.3-5.fc16.src.rpm 
liquibase.src: W: name-repeated-in-summary C Liquibase
liquibase.src: W: spelling-error %description -l en_US trackable -> traceable,
tractable, track able
liquibase.src: W: invalid-url Source0: liquibase-2.0.3.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

FIX: The git clone command is missing tag or hash. Your instructions will lead
to master/random tarball.

Please consider using generate-tarball script as described here:
http://fedoraproject.org/wiki/Packaging:SourceURL

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]

http://koji.fedoraproject.org/koji/taskinfo?taskID=3987265

MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]

Consider generating javadoc and adding -doc package delivering both docs and
samples. See the section at https://fedoraproject.org/wiki/Packaging:Java

FIX: All JAR files MUST go into %{_javadir} or a Java-version specific
directory %{_javadir}-* as appropriate[1].

Please use the Fedora macro for javadir.

Please consider using build-java-classpath. So instead:

export LIQUIBASE_HOME="/usr/share/java/"

use

CP=$(build-classpath liquibase)

Or consider using wrapper script auto generator from Wrapper Scripts section.

Looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809503

Devan Goodwin <dgoodwin(a)rm-rf.ca&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwmw2(a)infradead.org
          Component|Package Review              |0xFFFF
         AssignedTo|lzap(a)redhat.com             |dwmw2(a)infradead.org

--- Comment #2 from Devan Goodwin <dgoodwin(a)rm-rf.ca&gt; 2012-04-16 11:48:37 EDT ---
The git archive command specifies liquibase-parent-2.0.3 and should get us the
code from that tag reliably, did some quick testing to verify and it looks like
this is the case.

Made a couple touchups to spec file for rpmlint.

Switched to usage of %{_javadir}.

Added java-devel and jpackage-utils BuildRequires.

Added jpackage-utils Requires for use of the build-classpath at runtime.

Switched script to use build-classpath.

Added generation and packaging of javadocs.

Spec URL: http://dgoodwin.fedorapeople.org/liquibase/liquibase.spec
SRPM URL:
http://dgoodwin.fedorapeople.org/liquibase/liquibase-2.0.3-6.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809503

Lukáš Zapletal <lzap(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|0xFFFF                      |Package Review
         AssignedTo|dwmw2(a)infradead.org         |nobody(a)fedoraproject.org

--- Comment #3 from Lukáš Zapletal <lzap(a)redhat.com&gt; 2012-04-17 09:33:56 EDT ---
Corecting Component setting ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809503

Lukáš Zapletal <lzap(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody(a)fedoraproject.org    |dgoodwin(a)redhat.com
               Flag|                            |fedora-review+

--- Comment #4 from Lukáš Zapletal <lzap(a)redhat.com&gt; 2012-04-17 09:35:47 EDT ---
The package is *APPROVED*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809503

Devan Goodwin <dgoodwin(a)rm-rf.ca&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Devan Goodwin <dgoodwin(a)rm-rf.ca&gt; 2012-04-20 09:25:39 EDT ---
New Package SCM Request
=======================
Package Name: liquibase
Short Description: Database refactoring tool
Owners: dgoodwin jmrodri
Branches: f15 f16 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809503

--- Comment #6 from Jon Ciesla <limburgher(a)gmail.com&gt; 2012-04-20 09:32:17 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 809503] Review Request: liquibase - Database refactoring tool

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=809503

Igor Gnatenko <ignatenko(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2016-08-14 11:59:42



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component