https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Bug ID: 1296974 Summary: Review Request: python-beanbag - A helper module for accessing REST APIs Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sochotni@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://sochotni.fedorapeople.org//python-beanbag.spec SRPM URL: http://sochotni.fedorapeople.org//python-beanbag-1.9.2-1.fc22.src.rpm
Description: BeanBag is a simple module that lets you access REST APIs in an easy way. For example:
import beanbag github = beanbag.BeanBag("https://api.github.com") watchers = github.repos.ajtowns.beanbag.watchers() for w in watchers:
... print(w["login"])
See http://beanbag.readthedocs.org/ for more information.
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- sochotni's scratch build of python-beanbag-1.9.2-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12467424
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbean@redhat.com
--- Comment #2 from Ralph Bean rbean@redhat.com --- Created attachment 1112947 --> https://bugzilla.redhat.com/attachment.cgi?id=1112947&action=edit patch to python-beanbag.spec
Patch to update the specfile.
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Assignee|nobody@fedoraproject.org |rbean@redhat.com
--- Comment #3 from Ralph Bean rbean@redhat.com --- Hi Stanislav, I attached a patch to the specfile which should update it to reflect some of the more current practices for python packaging. I'll take the review once you can have a look over that and re-post an updated version of the srpm.
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- sochotni's scratch build of python-beanbag-1.9.2-2.fc22.src.rpm for epel7-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12494939
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #5 from Stanislav Ochotnicky sochotni@redhat.com --- So... I did notice py2_build etc macros in example in the python guidelines however it's not at all mentioned otherwise and I wasn't sure what to make of it. Of course the macros are not in EL6 - but then again I guess I don't have to care about it too much (FYI build on EL6 does fail because of that though - https://kojipkgs.fedoraproject.org//work/tasks/4945/12494945/build.log)
I also wasn't sure how to interpret the subpackage provides etc - but I see now that that they are supposed to really be used in python2/python3 subpackages instead of main package. That certainly makes sense, it just seemed ... weird not to have main package I guess.
Thanks for the patch, it does look cleaner now.
New SRPM: https://sochotni.fedorapeople.org/packages/python-beanbag-1.9.2-2.fc21.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1297411
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1297411 [Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #6 from Ralph Bean rbean@redhat.com --- Looks good to me now. Package Approved!
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-beanbag
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-beanbag-1.9.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4862ff15f8
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-beanbag-1.9.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-06e25cc466
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-beanbag-1.9.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4862ff15f8
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-beanbag-1.9.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-02-09 15:55:04
https://bugzilla.redhat.com/show_bug.cgi?id=1296974
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-beanbag-1.9.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org