Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=449067
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/Catalyst-Plugin-Session/ OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session-0.19... SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session.spec
Description: This plugin is the base of two related parts of functionality required for session management in web applications.
The first part, the State, is getting the browser to repeat back a session key, so that the web application can identify the client and logically string several requests together into a session.
The second part, the Store, deals with the actual storage of information about the client. This data is stored so that the it may be revived for every request made by the same client.
This plugin links the two pieces together.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
------- Additional Comments From cweyl@alumni.drew.edu 2008-05-30 03:07 EST ------- http://koji.fedoraproject.org/koji/taskinfo?taskID=635914
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2008-05-30 03:46 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=635914 + rpmlint is silent for SRPM and for RPM. + source files match upstream url eb7e9679234cd4f4269b5b1869141082 Catalyst-Plugin-Session-0.19.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 3 tests skipped. Files=8, Tests=33, 1 wallclock secs ( 1.01 cusr + 0.07 csys = 1.08 CPU) + package perl-Catalyst-Plugin-Session-0.19-1.fc9 => Provides: perl(Catalyst::Plugin::Session) = 0.19 perl(Catalyst::Plugin::Session::State) perl(Catalyst::Plugin::Session::Store) perl(Catalyst::Plugin::Session::Store::Dummy) perl(Catalyst::Plugin::Session::Test::Store) perl(Catalyst::Plugin::SessionStateTest) Requires: perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Catalyst) perl(Catalyst::Exception) perl(Catalyst::Test) perl(Digest) perl(File::Spec) perl(File::Temp) perl(NEXT) perl(Object::Signature) perl(Test::More) perl(base) perl(overload) perl(strict) perl(utf8) perl(warnings)
I don't know why some tests got skipped all skipped: Catalyst::Plugin::Session::State::Cookie version 0.03 or higher is required for this test See build.log
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
------- Additional Comments From cweyl@alumni.drew.edu 2008-05-30 11:34 EST ------- Including ::Cookie as a BR would create a circular buildloop, as ::Cookie has ::Session as a mandatory BR.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-05-30 12:01 EST ------- (In reply to comment #3)
Including ::Cookie as a BR would create a circular buildloop, as ::Cookie has ::Session as a mandatory BR.
OK. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
------- Additional Comments From cweyl@alumni.drew.edu 2008-05-30 12:10 EST ------- New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-Session Short Description: Catalyst generic session plugin Owners: cweyl Branches: F-7, F-8, F-9, devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-05-30 16:29 EST ------- cvs done (except for F-7, as we are no longer doing F-7 branches).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin
https://bugzilla.redhat.com/show_bug.cgi?id=449067
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2008-05-30 17:14 EST ------- Imported and built for rawhide. Thanks for the review! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=449067
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #8 from Iain Arnell iarnell@gmail.com 2011-07-11 06:39:14 EDT --- Package Change Request ====================== Package Name: perl-Catalyst-Plugin-Session New Branches: el6 Owners: iarnell
Chris doesn't maintain his packages in EPEL, but doesn't have a problem with others doing so.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=449067
--- Comment #9 from Jon Ciesla limb@jcomserv.net 2011-07-11 10:59:05 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org