[Bug 253910] New: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253910

Summary: Review Request: ksirk - Turnbased multiplayer board
                    strategy game (conquer the world!)
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://people.atrpms.net/~hdegoede/ksirk.spec
SRPM URL: http://people.atrpms.net/~hdegoede/ksirk-1.7-1.fc8.src.rpm
Description:
KsirK is a computerized version of a well known strategy board game. In the
current version, KsirK is a usable multi-player mono-machine game with a basic
AI. The goal of the game is simply to conquer the World... It is done by
attacking your neighbors with your armies.

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-09-08 11:28 EST -------
rpmlint is clean on RPM, but on SRPM:

ksirk.src:35: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.la
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.

ksirk.src:39: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.so
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.

This should probably be patched, should it not?

Also, I see shared libs, but no ldconfig in post or postun.

Running a mock build to double-check BRs, but it otherwise looks great.

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

------- Additional Comments From [e-mail]  2007-09-08 11:46 EST -------
(In reply to comment #1)
> rpmlint is clean on RPM, but on SRPM:
>
> ksirk.src:35: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.la
> A library path is hardcoded to one of the following paths: /lib,
> /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
>
> ksirk.src:39: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.so
> A library path is hardcoded to one of the following paths: /lib,
> /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.

These get caused by these lines in the spec:
rm $RPM_BUILD_ROOT%{_prefix}/lib/lib%{name}_*.la
# these are unversioned libs, which are only used by ksirk itself
mkdir -p $RPM_BUILD_ROOT%{_libdir}/%{name}
mv $RPM_BUILD_ROOT%{_prefix}/lib/lib%{name}_*.so \
  $RPM_BUILD_ROOT%{_libdir}/%{name}

Which move the lib from /usr/lib (wrong on 64 bit) to
%{_libdir}/%{name}, so the lines causing the warning actually fix the issue
reported by rpmlint :) Without these lines rpmlint won't complain and the result
will be wrong.
> Also, I see shared libs, but no ldconfig in post or postun.

Correct, the .so files are only for ksirk and are unversioned, thus they get
installed in %{_libdir}/%{name} not just %{_libdir}. So ldconfig is not needed
(and would have no effect as it doesn't look in %{_libdir}/%{name} only in
%{_libdir} ).

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

------- Additional Comments From [e-mail]  2007-09-08 12:26 EST -------
Ok, that makes sense.  My mock build revealed a missing BR, gettext.  Add that
and you're set.

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

------- Additional Comments From [e-mail]  2007-09-08 13:53 EST -------
(In reply to comment #3)
> Ok, that makes sense.  My mock build revealed a missing BR, gettext.  Add that
> and you're set.

Thanks!

Here is a new version with the missing BR added:
Spec URL: http://people.atrpms.net/~hdegoede/ksirk.spec
SRPM URL: http://people.atrpms.net/~hdegoede/ksirk-1.7-2.fc8.src.rpm

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-09-08 14:20 EST -------
Superlative.  Approved!

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

------- Additional Comments From [e-mail]  2007-09-08 15:03 EST -------
New Package CVS Request
=======================
Package Name:      ksirk
Short Description: Turnbased multiplayer board strategy game (conquer the world!)
Owners:            jwrdegoede
Branches:          F-7 devel
InitialCC:         <empty>
Cvsextras Commits: yes

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-09-09 18:34 EST -------
cvs done.

[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

https://bugzilla.redhat.com/show_bug.cgi?id=253910

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2007-09-11 13:39 EST -------
Imported and build, closing.