[Bug 571502] New: Review Request: pidgin-birthday-reminder - Birthday Reminder plugin for Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: pidgin-birthday-reminder - Birthday Reminder plugin for Pidgin
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Summary: Review Request: pidgin-birthday-reminder - Birthday Reminder plugin for Pidgin Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kalev@smartlink.ee QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://kalev.fedorapeople.org/pidgin-birthday-reminder.spec SRPM URL: http://kalev.fedorapeople.org/pidgin-birthday-reminder-1.4-1.fc14.src.rpm Description: Pidgin Birthday Reminder reminds you of your buddies birthdays. Birthdays can be set by hand or be automatically filled-in for ICQ, MSN and XMPP protocols.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2039330
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
William Witt william@witt-family.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |william@witt-family.net
--- Comment #1 from William Witt william@witt-family.net 2010-03-10 21:12:51 EST --- Below is an informal review: (extract from http://fedoraproject.org/wiki/Packaging:ReviewGuidelines)
* MUST: rpmlint must be run on every package. The output should be posted in the review.[1]
[ unamanic@gimli:~ ] $rpmlint /home/unamanic/rpmbuild/SRPMS/pidgin-birthday-reminder-1.4-1.fc12.src.rpm /home/unamanic/rpmbuild/RPMS/x86_64/pidgin-birthday-reminder-1.4-1.fc12.x86_64.rpm /home/unamanic/rpmbuild/RPMS/x86_64/pidgin-birthday-reminder-debuginfo-1.4-1.fc12.x86_64.rpm pidgin-birthday-reminder.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging pidgin-birthday-reminder.x86_64: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
* MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13]
is "# Pidgin package doesn't own sounds/pidgin/ dir" a bug against pidgin?
* MUST: Each package must consistently use macros. [17]
changing $RPM_BUILD_ROOT to %{buildroot} for consitancy would improve consistency
* SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [29]
are translations available?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #2 from Kalev Lember kalev@smartlink.ee 2010-03-11 04:25:59 EST --- (In reply to comment #1) Thanks for the review, William.
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does create that directory. [13]
is "# Pidgin package doesn't own sounds/pidgin/ dir" a bug against pidgin?
No, I don't think it's pidgin's bug. That comment in the spec file is just a reminder for myself why I had to own this directory. On pidgin's point of view, there is no reason why pidgin should own this dir: it doesn't place any files in there, and also it's not a standard directory where plugins would put stuff.
So right now I think it's best if pidgin-birthday-reminder owned this dir.
- MUST: Each package must consistently use macros. [17]
changing $RPM_BUILD_ROOT to %{buildroot} for consitancy would improve consistency
According to [1], choosing $RPM_BUILD_ROOT vs %{buildroot} is left entirely up to the packager. What matters is that $RPM_BUILD_ROOT should not be mixed with %{buildroot} in one spec.
[1] http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_...
- SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available. [29]
are translations available?
No, none are available.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no
--- Comment #3 from Terje Røsten terjeros@phys.ntnu.no 2010-03-18 07:56:17 EDT --- Seems good, however files have GPLv2+ and COPYING GPLv3.
Please contact upstream to clarify.
What is the correct URL?
This https://sourceforge.net/projects/pidgin-birthday/ or http://freakazoid.teamblind.de/2009/02/14/pidgin-birthday-reminder/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #4 from Kalev Lember kalev@smartlink.ee 2010-03-18 14:15:49 EDT --- (In reply to comment #3)
Seems good, however files have GPLv2+ and COPYING GPLv3.
Please contact upstream to clarify.
I actually believe that it's fine to ship GPLv3 COPYING file with sources that are GPLv2+. See http://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version...
However, GPLv3 COPYING file might still confuse people. I talked with the upstream author about that and he updated the COPYING file in SVN to contain the GPLv2 license text: http://pidgin-birthday.svn.sourceforge.net/viewvc/pidgin-birthday?view=rev&a...
What is the correct URL?
This https://sourceforge.net/projects/pidgin-birthday/ or http://freakazoid.teamblind.de/2009/02/14/pidgin-birthday-reminder/
All right, I guess the latter one has more info.
* Thu Mar 18 2010 Kalev Lember kalev@smartlink.ee - 1.4-2 - Updated URL
Spec URL: http://kalev.fedorapeople.org/pidgin-birthday-reminder.spec SRPM URL: http://kalev.fedorapeople.org/pidgin-birthday-reminder-1.4-2.fc14.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2061702
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |terjeros@phys.ntnu.no Flag| |fedora-review?
--- Comment #5 from Terje Røsten terjeros@phys.ntnu.no 2010-03-18 14:57:09 EDT --- ok rpmlint ok naming ok spec file ok perms and owns ok license ok license tag ok buildflags ok sha1sum 2416915f7693213d4c774f967065c628a50d9b3b birthday_reminder-1.4.tar.gz 2416915f7693213d4c774f967065c628a50d9b3b birthday_reminder-1.4.tar.gz.spec ok timestamps 2010-03-04 08:20 birthday_reminder-1.4.tar.gz ok koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2061772
I see no problems, only a small comment: wav files might belong in /usr/share/sounds/purple, that's a upstream issue not a review thing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Terje Røsten terjeros@phys.ntnu.no 2010-03-18 14:59:55 EDT ---
And the conclusion is package pidgin-birthday-reminder is
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Kalev Lember kalev@smartlink.ee 2010-03-18 15:10:41 EDT --- Thank you for the review, Terje!
New Package CVS Request ======================= Package Name: pidgin-birthday-reminder Short Description: Birthday Reminder plugin for Pidgin Owners: kalev Branches: F-11 F-12 F-13 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2010-03-19 15:55:51 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-03-19 17:57:24 EDT --- pidgin-birthday-reminder-1.4-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.4-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-03-19 17:57:28 EDT --- pidgin-birthday-reminder-1.4-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.4-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-03-19 17:57:32 EDT --- pidgin-birthday-reminder-1.4-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.4-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-03-20 07:14:55 EDT --- pidgin-birthday-reminder-1.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.5-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-03-20 07:15:01 EDT --- pidgin-birthday-reminder-1.5-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.5-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-03-20 07:15:06 EDT --- pidgin-birthday-reminder-1.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.5-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-03-22 21:55:49 EDT --- pidgin-birthday-reminder-1.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pidgin-birthday-reminder'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.5-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-03-22 22:01:59 EDT --- pidgin-birthday-reminder-1.5-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pidgin-birthday-reminder'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.5-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-03-22 22:03:53 EDT --- pidgin-birthday-reminder-1.5-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pidgin-birthday-reminder'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pidgin-birthday-reminder-1.5-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2010-03-26 20:54:41 EDT --- pidgin-birthday-reminder-1.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |pidgin-birthday-reminder-1. | |5-1.fc11 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2010-03-26 20:58:30 EDT --- pidgin-birthday-reminder-1.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|pidgin-birthday-reminder-1. |pidgin-birthday-reminder-1. |5-1.fc11 |5-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2010-04-08 23:43:51 EDT --- pidgin-birthday-reminder-1.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571502
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|pidgin-birthday-reminder-1. |pidgin-birthday-reminder-1. |5-1.fc12 |5-1.fc13
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla