[Bug 1326301] New: Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

            Bug ID: 1326301
           Summary: Review Request: intel-cmt-cat - Software providing
                    access to Intel (R) RDT technologies
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: tomasz.kantecki(a)intel.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL: https://01.org/sites/default/files/page/intel-cmt-cat.spec_.gz
SRPM URL:
https://01.org/sites/default/files/page/intel-cmt-cat-0.1.4-1.fc18.src_.rpm

Description:
Hi! I have finished packaging intel-cmt-cat software and I would appreciate a
review so it can be packaged for Fedora.

Software package includes command line tool and the corresponding man page. The
tool allows to monitor LLC cache occupancy (CMT) and memory bandwidth (MBM) as
well as control/configure access to LLC (CAT & CDP). Through configuring cache
access, workloads can be isolated and their impact on other workloads can be
reduced. Several studies found it useful for improved server utilization and
service assurance. Example:
http://csl.stanford.edu/~christos/publications/2015.heracles.isca.pdfFedora

CAT and CDP are not enabled via any Linux framework at the moment. The tool
provides solution until kernel frameworks enable the technologies in question
and customers upgrade their kernels.

CMT and MBM can be used via Linux perf in kernels 4.1+ and 4.6+ respectively.

The tool depends only on x86 MSR kernel driver (arch/x86/kernel/msr.c) and C &
pthreads libraries. This is user space software and because it accesses MSR's
it needs adequate level of privilege.

More about Intel (R) RDT technologies can be found here:
http://www.intel.com/content/www/us/en/architecture-and-technology/resour...

Fedora Account System Username:
tkanteck

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Neil Horman <nhorman(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nhorman(a)redhat.com
           Assignee|nobody(a)fedoraproject.org    |nhorman(a)redhat.com



--- Comment #1 from Neil Horman <nhorman(a)redhat.com&gt; ---
Tomasz, the spec and srpm files are somewhat misnamed.  They need to not be
compressed, and the the spec_ and src_ terms should be spec and src.  I can
manually fix that up this time, but please make note of that for subsequent
submissions.

Spec URL: http://people.redhat.com/nhorman/intel-cmt-cat.spec
SRPM URL: http://people.redhat.com/nhorman/intel-cmt-cat-0.1.4-1.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301



--- Comment #2 from Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; ---
Thanks Neil! 01.org website auto renames attachments - sorry for that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Janet Morgan <jamorgan(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1315489



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Neil Horman <nhorman(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(tomasz.kantecki@i
                   |                            |ntel.com)



--- Comment #3 from Neil Horman <nhorman(a)redhat.com&gt; ---

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
<NH>
Need to include the License file

[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 4 files have
unknown
     license. Detailed output of licensecheck in /home/nhorman/1326301
     -intel-cmt-cat/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
<NH> see above about including LICENSE

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in intel-
     cmt-cat-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.2.17 starting (python version = 3.4.3)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
Mock Version: 1.2.17
INFO: Mock Version: 1.2.17
Finish: chroot init
INFO: installing package(s):
/home/nhorman/1326301-intel-cmt-cat/results/intel-cmt-cat-0.1.4-1.fc25.x86_64.rpm
/home/nhorman/1326301-intel-cmt-cat/results/intel-cmt-cat-debuginfo-0.1.4-1.fc25.x86_64.rpm
/home/nhorman/1326301-intel-cmt-cat/results/intel-cmt-cat-debuginfo-0.1.4-1.fc25.x86_64.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 25 --disableplugin=local --setopt=deltarpm=false install
/home/nhorman/1326301-intel-cmt-cat/results/intel-cmt-cat-0.1.4-1.fc25.x86_64.rpm
/home/nhorman/1326301-intel-cmt-cat/results/intel-cmt-cat-debuginfo-0.1.4-1.fc25.x86_64.rpm
/home/nhorman/1326301-intel-cmt-cat/results/intel-cmt-cat-debuginfo-0.1.4-1.fc25.x86_64.rpm
--setopt=tsflags=nocontexts


Rpmlint
-------
Checking: intel-cmt-cat-0.1.4-1.fc25.x86_64.rpm
          intel-cmt-cat-debuginfo-0.1.4-1.fc25.x86_64.rpm
          intel-cmt-cat-0.1.4-1.fc25.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Requires
--------
intel-cmt-cat (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

intel-cmt-cat-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
intel-cmt-cat:
    intel-cmt-cat
    intel-cmt-cat(x86-64)

intel-cmt-cat-debuginfo:
    intel-cmt-cat-debuginfo
    intel-cmt-cat-debuginfo(x86-64)



Source checksums
----------------
https://github.com/01org/intel-cmt-cat/archive/v0.1.4.tar.gz :
  CHECKSUM(SHA256) this package     :
28be33719c1600ce70858ad24a57c5bd13340e7fd8023a456eae83e1887d5c2e
  CHECKSUM(SHA256) upstream package :
28be33719c1600ce70858ad24a57c5bd13340e7fd8023a456eae83e1887d5c2e


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1326301
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


I think you're pretty close to go, fix the license issue and we should be good
to go!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(tomasz.kantecki@i |
                   |ntel.com)                   |



--- Comment #4 from Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; ---
I have updated the SPEC to resolve license issue.
The files are uploaded to 01.org but again they have been mangled during the
upload. Sorry for that.

https://01.org/sites/default/files/page/intel-cmt-cat-0.1.4-2.fc20.src_.rpm
https://01.org/sites/default/files/page/intel-cmt-cat.spec__0.gz

To fix names after download please run:
mv intel-cmt-cat-0.1.4-2.fc20.src_.rpm intel-cmt-cat-0.1.4-2.fc20.src.rpm
mv intel-cmt-cat.spec__0.gz intel-cmt-cat.spec.gz
gizp -d intel-cmt-cat.spec.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Neil Horman <nhorman(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
                   |                            |needinfo?(tomasz.kantecki@i
                   |                            |ntel.com)



--- Comment #5 from Neil Horman <nhorman(a)redhat.com&gt; ---
If 01.org is going to continually mangle your urls, I would suggest not using
01.org at all, as it will make future rpmlint checks fail against your
committed spec file.  Get a fedora hosted account, or move the whole thing to
github and be done with it.

But the rpm looks good now, review ACK.

I've sponsored you into the packager group, please complete the packaging
process to import your new rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(tomasz.kantecki@i |
                   |ntel.com)                   |



--- Comment #6 from Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; ---
Thanks! Per your advice I've uploaded the files to github and fixed small typo
issue in the spec file.

https://github.com/01org/intel-cmt-cat/raw/master/srpm/intel-cmt-cat.spec
https://github.com/01org/intel-cmt-cat/raw/master/srpm/intel-cmt-cat-0.1....

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Neil Horman <nhorman(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(tomasz.kantecki@i
                   |                            |ntel.com)



--- Comment #7 from Neil Horman <nhorman(a)redhat.com&gt; ---
ok, thanks.  you're good to go then, just follow the rest of the process to get
the package imported to the fedora repo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301



--- Comment #8 from Jon Ciesla <limburgher(a)gmail.com&gt; ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/intel-cmt-cat

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301



--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
intel-cmt-cat-0.1.4-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-36d91d432f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
intel-cmt-cat-0.1.4-3.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-36d91d432f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301



--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
intel-cmt-cat-0.1.4-3.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2016-05-07 07:51:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301



--- Comment #12 from Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; ---
I think all required information has been supplied already

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(tomasz.kantecki@i |
                   |ntel.com)                   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Tomasz Kantecki <tomasz.kantecki(a)intel.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1351707




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1351707
[Bug 1351707] Review Request: ntel-cmt-cat - Software providing access to
Intel (R) RDT technologies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Mark Flitter <mflitter(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1428345



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1326301] Review Request: intel-cmt-cat - Software providing access to Intel (R) RDT technologies

https://bugzilla.redhat.com/show_bug.cgi?id=1326301

Mark Flitter <mflitter(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1428345                     |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component