https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Bug ID: 1231356 Summary: Review Request: php-utfnormal - Unicode normalization functions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@cchtml.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://michael.cronenworth.com/RPMS/php-utfnormal.spec SRPM URL: http://michael.cronenworth.com/RPMS/php-utfnormal-1.0.2-1.fc21.src.rpm Description: Unicode normalization functions, broken out of mediawiki Fedora Account System Username: mooninite
$ rpmlint php-utfnormal.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/SRPMS/php-utfnormal-1.0.2-1.fc21.src.rpm php-utfnormal.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1230630
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1230630 [Bug 1230630] MediaWiki fails with "requires the PSR-3 logging library to be present"
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com
--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- * Shouldn't source come from https://github.com/wikimedia/utfnormal as that's where Composer installs from? -- https://packagist.org/packages/wikimedia/utfnormal
* Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should be "php-wikimedia-utfnormal"
* Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path should be "/usr/share/php/UtfNormal/*" to be PSR-0 compliant
* Per https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need to provide "php-composer(wikimedia/utfnormal) = %{version}"
* Tests are provided so they should be run in %check
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
--- Comment #2 from Tom Hughes tom@compton.nu --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== Issues ======
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php
- This will likely fix itself once the requires are correct
[!]: Package is named according to the Package Naming Guidelines.
- Should be php-wikimedia-utfnormal as it is a composer library?
[!]: Requires correct, justified where necessary.
- PHP addons which are neither PEAR nor PECL should require what makes sense (either a base PHP version or a php-api, php(zend-abi) as necessary). - Pre composer.json maybe "php(language) >= 5.3.3"?
[!]: Package complies to the Packaging Guidelines
- composer.json should be shipped as %doc
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
- See above re requires - Needs provide of php-composer(wikimedia/utfnormal) = %{version}
[!]: %check is present and all tests pass.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/tom/1231356-php-utfnormal/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [!]: Run phpci static analyze on all php files. Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo package to get a more comprehensive php review. See: url: undefined
Rpmlint ------- Checking: php-utfnormal-1.0.2-1.fc23.noarch.rpm php-utfnormal-1.0.2-1.fc23.src.rpm php-utfnormal.noarch: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code php-utfnormal.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- php-utfnormal.noarch: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- php-utfnormal (rpmlib, GLIBC filtered):
Provides -------- php-utfnormal: php-utfnormal
Source checksums ---------------- http://git.wikimedia.org/zip/?r=utfnormal.git&format=xz&h=bb892a53a7... : CHECKSUM(SHA256) this package : 98dc20b2f06efcd0a42dea8b9cde15b666e5de033de2cab46749ed173257a5d0 CHECKSUM(SHA256) upstream package : 98dc20b2f06efcd0a42dea8b9cde15b666e5de033de2cab46749ed173257a5d0
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1231356 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
--- Comment #3 from Tom Hughes tom@compton.nu --- In addition, like the other commenter I'm not sure this is the "real source" as many of the files in src claim to be generated so it may be better to package from github and generate them in %build.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |php-utfnormal - Unicode |php-wikimedia-utfnormal - |normalization functions |Unicode normalization | |functions
--- Comment #4 from Michael Cronenworth mike@cchtml.com --- Wikimedia created this library. Wikimedia hosts the source in their official git repository. Please, also, see the description on github: "Github mirror of "utfnormal" - our actual code is hosted with Gerrit..."
My preference is to use the official source repository and not github.
This is a pure PHP library so there is nothing to do in %build. Composer is not provided in Fedora.
http://michael.cronenworth.com/RPMS/php-wikimedia-utfnormal.spec http://michael.cronenworth.com/RPMS/php-wikimedia-utfnormal-1.0.2-2.fc21.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
--- Comment #5 from Michael Cronenworth mike@cchtml.com --- Here's the license file request: https://phabricator.wikimedia.org/T102359
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Tom Hughes tom@compton.nu --- Other than the recommendation (at https://fedoraproject.org/wiki/Packaging:PHP#File_Placement) that composer.json be shipped as %doc that all looks good now, so package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Michael Cronenworth mike@cchtml.com --- Thanks for the review.
New Package SCM Request ======================= Package Name: php-wikimedia-utfnormal Short Description: Unicode normalization functions Upstream URL: http://www.mediawiki.org/wiki/Utfnormal Owners: mooninite Branches: f21 f22 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-utfnormal-1.0.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-wikimedia-utfnormal-1.0.2-1.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-utfnormal-1.0.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-wikimedia-utfnormal-1.0.2-1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #11 from Remi Collet fedora@famillecollet.com --- hmm.. too fast for me...
Per Guildelines, shoud requires all needed extension. See phpcompatinfo report => php-intl, php-pcre and php-spl
I really consider running test suite as a "MUST" when exists and when possible.
Ex: https://github.com/remicollet/remirepo/commit/1073a91e55dad625b01d41db374a30...
Notice: the generated simple autoloader, needed to run tests, is also installed, which can make easier ti use this library outside of composer project.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-utfnormal-1.0.2-1.fc22 has been pushed to the Fedora 22 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
--- Comment #13 from Michael Cronenworth mike@cchtml.com --- I have updated the Requires and installed an autoloader. Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |php-wikimedia-utfnormal-1.0 | |.2-3.fc22 Resolution|--- |ERRATA Last Closed| |2015-07-03 14:37:13
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-utfnormal-1.0.2-3.fc22 has been pushed to the Fedora 22 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1231356
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-wikimedia-utfnormal-1.0 |php-wikimedia-utfnormal-1.0 |.2-3.fc22 |.2-3.fc21
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-utfnormal-1.0.2-3.fc21 has been pushed to the Fedora 21 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla