https://bugzilla.redhat.com/show_bug.cgi?id=876408
Bug ID: 876408 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: miro@hroncok.cz Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-1.... Description: Boost::Geometry::Utils Perl module Fedora Account System Username: churchyard
https://bugzilla.redhat.com/show_bug.cgi?id=876408
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Depends On| |876405
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m Blocks|177841 (FE-NEEDSPONSOR) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |890839
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Bug 876408 depends on bug 876405, which changed state.
Bug 876405 Summary: Review Request: perl-Module-Build-WithXSpp - XS++ enhanced flavor of Module::Build https://bugzilla.redhat.com/show_bug.cgi?id=876405
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #1 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-4....
- Using dos2unix instead of sed - Removed deleting empty dirs - Dropped perl macro - Removed BRs provided by perl package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
--- Comment #2 from Petr Šabata psabata@redhat.com --- I'll take the review...
- Using dos2unix instead of sed
Why? What's the advantage?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- The action is more obvious (readable) in the spec, I suppose.
When reading the spec over again, some part of my brain remembered, someone has told me once to use dos2unix instead of sed. It's part of my subconscious now.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #4 from Petr Šabata psabata@redhat.com --- (In reply to comment #3)
The action is more obvious (readable) in the spec, I suppose.
When reading the spec over again, some part of my brain remembered, someone has told me once to use dos2unix instead of sed. It's part of my subconscious now.
It's mostly a matter of style. I was just curious.
Issues found while looking at your package:
Missing build-time dependencies: perl(File::Temp) (from t/00-compile.t:11) perl(Exporter) (from lib/Boost/Geometry/Utils.pm:9) perl(XSLoader) (from lib/Boost/Geometry/Utils.pm:12)
You can drop the following deps as they aren't actually used anywhere: perl(ExtUtils::Typemaps::Default) perl(ExtUtils::XSpp) perl(Module::Build)
What's the point of including the 'src' directory in the documentation? If you really want to package it, consider putting it in a doc subpackage. My guess is the package users probably won't need those 31MiB installed. The same applies to the xsp directory, even though it's quite small. If you're going to keep these, also change the License tag to "(GPL+ or Artistic) and Boost and MIT".
And... (In reply to comment #1)
- Dropped perl macro
You could also drop it in the MODULE_COMPAT virtual dependency line.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #5 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-5....
- Dropped perl macro in MODULE_COMPAT - Removed src and xsp from %%doc - Dropped converting src to UTF-8 - Dropped converting newlines and dos2unix BR - Dropped BRs: perl(ExtUtils::Typemaps::Default) perl(ExtUtils::XSpp) perl(Module::Build) - Added BRs: perl(File::Temp) perl(Exporter) perl(XSLoader)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Petr Šabata psabata@redhat.com --- Everything addressed.
However, the build fails because it can't find the prerequisities specified in Build.PL. I'm sorry for the confusion -- I should have checked that. Please, re-add the dropped BRs before pushing the package.
Anyway, approving.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #7 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-6....
Added back perl(ExtUtils::Typemaps::Default), builds in mock.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Miro Hrončok mhroncok@redhat.com --- New Package SCM Request ======================= Package Name: perl-Boost-Geometry-Utils Short Description: Boost::Geometry::Utils Perl module Owners: churchyard Branches: f17 f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Boost-Geometry-Utils-0.05-6.fc1...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-28 10:07:40
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Boost-Geometry-Utils-0.05-6.fc1...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|CURRENTRELEASE |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org