[Bug 876408] New: Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module - package-review

List overview All Threads
Download

newer

[Bug 876408] New: Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

older

[Bug 908168] New: Review Request:...

[Bug 886908] New: Review Request:...

Red Hat Bugzilla

13 Nov 2012 13 Nov '12

9:03 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=876408

Bug ID: 876408 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: miro@hroncok.cz Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-1.... Description: Boost::Geometry::Utils Perl module Fedora Account System Username: churchyard

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by thread

Red Hat Bugzilla

13 Nov 13 Nov

9:03 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

https://bugzilla.redhat.com/show_bug.cgi?id=876408

Miro Hrončok miro@hroncok.cz changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

17 Nov 17 Nov

4:45 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Mario Blättermann mario.blaettermann@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

30 Dec 30 Dec

9:19 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Miro Hrončok miro@hroncok.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |890839

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y3Epm23hbu&a=cc_unsubscribe

Red Hat Bugzilla

12 Jan 12 Jan

9:10 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Bug 876408 depends on bug 876405, which changed state.

Bug 876405 Summary: Review Request: perl-Module-Build-WithXSpp - XS++ enhanced flavor of Module::Build https://bugzilla.redhat.com/show_bug.cgi?id=876405

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UZs0Qhxv6m&a=cc_unsubscribe

Red Hat Bugzilla

16 Jan 16 Jan

10:09 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #1 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-4....

- Using dos2unix instead of sed - Removed deleting empty dirs - Dropped perl macro - Removed BRs provided by perl package

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ES1kuCAmwA&a=cc_unsubscribe

Red Hat Bugzilla

17 Jan 17 Jan

2:30 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Petr Šabata psabata@redhat.com changed:

--- Comment #2 from Petr Šabata psabata@redhat.com --- I'll take the review...

...

Using dos2unix instead of sed

Why? What's the advantage?

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Kx7jiHYFRB&a=cc_unsubscribe

Red Hat Bugzilla

4:33 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- The action is more obvious (readable) in the spec, I suppose.

When reading the spec over again, some part of my brain remembered, someone has told me once to use dos2unix instead of sed. It's part of my subconscious now.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BLnVYVEUfP&a=cc_unsubscribe

Red Hat Bugzilla

10:33 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #4 from Petr Šabata psabata@redhat.com --- (In reply to comment #3)

...

The action is more obvious (readable) in the spec, I suppose.

When reading the spec over again, some part of my brain remembered, someone has told me once to use dos2unix instead of sed. It's part of my subconscious now.

It's mostly a matter of style. I was just curious.

Issues found while looking at your package:

Missing build-time dependencies: perl(File::Temp) (from t/00-compile.t:11) perl(Exporter) (from lib/Boost/Geometry/Utils.pm:9) perl(XSLoader) (from lib/Boost/Geometry/Utils.pm:12)

You can drop the following deps as they aren't actually used anywhere: perl(ExtUtils::Typemaps::Default) perl(ExtUtils::XSpp) perl(Module::Build)

What's the point of including the 'src' directory in the documentation? If you really want to package it, consider putting it in a doc subpackage. My guess is the package users probably won't need those 31MiB installed. The same applies to the xsp directory, even though it's quite small. If you're going to keep these, also change the License tag to "(GPL+ or Artistic) and Boost and MIT".

And... (In reply to comment #1)

...

Dropped perl macro

You could also drop it in the MODULE_COMPAT virtual dependency line.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1U4Pe59hsj&a=cc_unsubscribe

Red Hat Bugzilla

10:46 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #5 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-5....

- Dropped perl macro in MODULE_COMPAT - Removed src and xsp from %%doc - Dropped converting src to UTF-8 - Dropped converting newlines and dos2unix BR - Dropped BRs: perl(ExtUtils::Typemaps::Default) perl(ExtUtils::XSpp) perl(Module::Build) - Added BRs: perl(File::Temp) perl(Exporter) perl(XSLoader)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=caSBNxjMZG&a=cc_unsubscribe

Red Hat Bugzilla

18 Jan 18 Jan

7:44 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Petr Šabata psabata@redhat.com changed:

--- Comment #6 from Petr Šabata psabata@redhat.com --- Everything addressed.

However, the build fails because it can't find the prerequisities specified in Build.PL. I'm sorry for the confusion -- I should have checked that. Please, re-add the dropped BRs before pushing the package.

Anyway, approving.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F9PrlKEc54&a=cc_unsubscribe

Red Hat Bugzilla

9:01 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #7 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-6....

Added back perl(ExtUtils::Typemaps::Default), builds in mock.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ON1AVfyNV7&a=cc_unsubscribe

Red Hat Bugzilla

9:04 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Miro Hrončok mhroncok@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #8 from Miro Hrončok mhroncok@redhat.com --- New Package SCM Request ======================= Package Name: perl-Boost-Geometry-Utils Short Description: Boost::Geometry::Utils Perl module Owners: churchyard Branches: f17 f18 InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gnqM5Z2mvT&a=cc_unsubscribe

Red Hat Bugzilla

9:37 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nFRvO9iRwu&a=cc_unsubscribe

Red Hat Bugzilla

11:50 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PXZWp3duxQ&a=cc_unsubscribe

Red Hat Bugzilla

11:50 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Boost-Geometry-Utils-0.05-6.fc1...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=enoiC35eH9&a=cc_unsubscribe

Red Hat Bugzilla

19 Jan 19 Jan

9:12 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ztU7cfyWrG&a=cc_unsubscribe

Red Hat Bugzilla

9:12 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc18 has been pushed to the Fedora 18 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F2Mt9Gn0l9&a=cc_unsubscribe

Red Hat Bugzilla

28 Jan 28 Jan

9:07 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9M2m7EmBtK&a=cc_unsubscribe

Red Hat Bugzilla

9:07 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WEaz64dFYZ&a=cc_unsubscribe

Red Hat Bugzilla

21 Feb 21 Feb

11:29 a.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Boost-Geometry-Utils-0.05-6.fc1...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5cb2Oxl4bY&a=cc_unsubscribe

Red Hat Bugzilla

4 Mar 4 Mar

4:26 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|CURRENTRELEASE |ERRATA

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YeFnYO3GCj&a=cc_unsubscribe

Red Hat Bugzilla

4:26 p.m.

New subject: [Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Boost-Geometry-Utils-0.05-6.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BbaLWx0FgU&a=cc_unsubscribe

4523

Age (days ago)

4633

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla