[Bug 1451411] New: Review Request: python-flask-httpauth - Basic and Digest HTTP authentication for Flask routes
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Bug ID: 1451411 Summary: Review Request: python-flask-httpauth - Basic and Digest HTTP authentication for Flask routes Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jpena@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jpena.fedorapeople.org/python-flask-httpauth/python-flask-httpauth.s... SRPM URL: https://jpena.fedorapeople.org/python-flask-httpauth/python-flask-httpauth-3... Description: FlaskHTTPAuth provides Basic and Digest HTTP authentication for Flask routes. Fedora Account System Username: jpena
Koji scratch build available at https://koji.fedoraproject.org/koji/taskinfo?taskID=19587651
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Chandan Kumar chkumar246@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chkumar246@gmail.com Assignee|nobody@fedoraproject.org |chkumar246@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Chandan Kumar chkumar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chkumar@redhat.com, | |jpena@redhat.com Flags| |needinfo?(jpena@redhat.com)
--- Comment #1 from Chandan Kumar chkumar@redhat.com --- Thanks Jpena for putting the Package Review.
Below is some of my comments: * The current pypi tarball does not contains docs and tests folder, please use github tarball. Note: I have added a patch upstream to include docs and tests in pypi tarball: https://github.com/miguelgrinberg/Flask-HTTPAuth/pull/55
* Add -docs and -tests subpackage to the project as well as include %check section to run unit tests.
Rest looks ok to me.
Thanks,
Chandan Kumar
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Javier Peña jpena@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jpena@redhat.com) |
--- Comment #2 from Javier Peña jpena@redhat.com --- Thanks Chandan.
I have updated the spec to use version 3.2.3, which includes your PR to add docs and tests to the package. The spec now runs unit tests and packages documentation. I have not packaged unit tests, since they do not get installed by "python setup.py install" and I don't see a lot of value in adding them.
Updated files are:
- Spec: https://jpena.fedorapeople.org/python-flask-httpauth/python-flask-httpauth.s... - SRPM: https://jpena.fedorapeople.org/python-flask-httpauth/python-flask-httpauth-3...
Koji scratch build available at https://koji.fedoraproject.org/koji/taskinfo?taskID=19866638
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Chandan Kumar chkumar246@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Chandan Kumar chkumar246@gmail.com --- This is a formal package review.
It works fine. So I am approving this package. This package is Approved now.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (unspecified)", "Unknown or generated". 64 files have unknown license. Detailed output of licensecheck in /home/chkumar246/asguard/packaging/python-flask- httpauth/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages/__pycache__, /usr/lib/python3.6/site-packages, /usr/lib/python3.6 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -flask-httpauth , python-flask-httpauth-doc , python3-flask-httpauth [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: python2-flask-httpauth-3.2.3-1.fc27.noarch.rpm python-flask-httpauth-doc-3.2.3-1.fc27.noarch.rpm python3-flask-httpauth-3.2.3-1.fc27.noarch.rpm python-flask-httpauth-3.2.3-1.fc27.src.rpm python-flask-httpauth.src:108: W: macro-in-%changelog %check 4 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- python3-flask-httpauth (rpmlib, GLIBC filtered): python(abi) python3-flask python3-werkzeug
python2-flask-httpauth (rpmlib, GLIBC filtered): python(abi) python-flask python-werkzeug
python-flask-httpauth-doc (rpmlib, GLIBC filtered):
Provides -------- python3-flask-httpauth: python3-flask-httpauth python3.6dist(flask-httpauth) python3dist(flask-httpauth)
python2-flask-httpauth: python-Flask-HTTPAuth python2-flask-httpauth python2.7dist(flask-httpauth) python2dist(flask-httpauth)
python-flask-httpauth-doc: python-flask-httpauth-doc
Source checksums ---------------- https://files.pythonhosted.org/packages/source/F/Flask-HTTPAuth/Flask-HTTPAu... : CHECKSUM(SHA256) this package : 5f4ba7ab79103e28b566c6a0592076312d17c716e079c66ca9ffe21a7871ee8d CHECKSUM(SHA256) upstream package : 5f4ba7ab79103e28b566c6a0592076312d17c716e079c66ca9ffe21a7871ee8d
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -r -m fedora-rawhide-x86_64 -b 1451411 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-flask-httpauth
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-flask-httpauth-3.2.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b8f6987943
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-flask-httpauth-3.2.3-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b8f6987943
https://bugzilla.redhat.com/show_bug.cgi?id=1451411
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-06-09 15:27:19
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-flask-httpauth-3.2.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com