https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Bug ID: 1103897 Summary: Review Request: python-rxjson - JSON RX Schema validation tool Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: bochecha@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://bochecha.fedorapeople.org/packages/python-rxjson.spec SRPM URL: http://bochecha.fedorapeople.org/packages/python-rxjson-0.2-1.fc20.src.rpm
Description: JSON RX Schema validation tool.
Fedora Account System Username: bochecha
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1103898
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1103898 [Bug 1103898] Package Bodhi 2
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1103898 |1103917
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1103898 [Bug 1103898] Package Bodhi 2 https://bugzilla.redhat.com/show_bug.cgi?id=1103917 [Bug 1103917] Review Request: python-cornice - Define Web Services in Pyramid
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@gmail.com Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Haïkel Guémar karlthered@gmail.com --- I hereby approve of this package into Fedora Packages Collection. Formal review here:
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/haikel/1103897-python-rxjson/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-rxjson [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-rxjson-0.2-1.fc20.noarch.rpm python3-rxjson-0.2-1.fc20.noarch.rpm python-rxjson-0.2-1.fc20.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint python3-rxjson python-rxjson 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- python3-rxjson (rpmlib, GLIBC filtered): python(abi)
python-rxjson (rpmlib, GLIBC filtered): python(abi)
Provides -------- python3-rxjson: python3-rxjson
python-rxjson: python-rxjson
Source checksums ---------------- https://pypi.python.org/packages/source/r/rxjson/rxjson-0.2.tar.gz : CHECKSUM(SHA256) this package : a5356253b4f24f72895f686edcec50482be0ebc2ec97495f13dffb08dc0d66fa CHECKSUM(SHA256) upstream package : a5356253b4f24f72895f686edcec50482be0ebc2ec97495f13dffb08dc0d66fa
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Mathieu Bridon bochecha@fedoraproject.org --- Thanks Haikel!
New Package SCM Request ======================= Package Name: python-rxjson Short Description: JSON RX Schema validation tool Upstream URL: https://pypi.python.org/pypi/rxjson/ Owners: bochecha lmacken Branches: devel el6 el7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1103897
Mathieu Bridon bochecha@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2014-06-03 13:23:24
--- Comment #4 from Mathieu Bridon bochecha@fedoraproject.org --- Thanks for the Git, Jon!
Package built, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla