Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: lv2-abGate - an LV2 Noise Gate plugin
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Summary: Review Request: lv2-abGate - an LV2 Noise Gate plugin Product: Fedora Version: 16 Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: brendan.jones.it@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
A simple LV2 noise gate plugin for use in hosts that support LV2
SPEC: http://bsjones.fedorapeople.org/lv2-abGate.spec SRPM: http://bsjones.fedorapeople.org/lv2-abGate-1.1.3-1.fc16.src.rpm
RPMLINT: rpmlint /home/bsjones/rpmbuild/SRPMS/lv2-abGate-1.1.3-1.fc16.src.rpm /home/bsjones/rpmbuild/RPMS/x86_64/lv2-abGate*.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2012-01-06 09:14:48 EST --- I'll review this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com 2012-01-06 09:29:44 EST --- Failed to build in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624813
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
--- Comment #3 from Brendan Jones brendan.jones.it@gmail.com 2012-01-06 09:56:28 EST --- lv2core has been updated prior to raising this bug. I thought this would come up.
Removed lv2config
SPEC: http://bsjones.fedorapeople.org/lv2-abGate.spec SRPM: http://bsjones.fedorapeople.org/lv2-abGate-1.1.3-2.fc16.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2012-01-06 10:30:39 EST --- Successful Koji scratchbuild for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624978
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
work ~/temp: rpmlint * lv2-abGate.src: I: enchant-dictionary-not-found en_US 3 packages and 0 specfiles checked; 0 errors, 0 warnings. work ~/temp:
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum abGate-1.1.3.tar.gz* f1f65e4e05038c7cbff05463ebb423213ce99603db58f7802a10f4d8e735abf5 abGate-1.1.3.tar.gz f1f65e4e05038c7cbff05463ebb423213ce99603db58f7802a10f4d8e735abf5 abGate-1.1.3.tar.gz.1 sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. 0 The package DOESN'T have a %clean section, so it won't build cleanly on systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Brendan Jones brendan.jones.it@gmail.com 2012-01-08 17:13:51 EST --- New Package SCM Request ======================= Package Name: lv2-abGate Short Description: LV2 noisegate plugin Owners: bsjones Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-01-08 17:20:03 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-01-11 06:47:13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE | Keywords| |Reopened
--- Comment #7 from Brendan Jones brendan.jones.it@gmail.com 2012-01-11 06:52:48 EST --- Peter, the (pending) update will close these bug.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2012-01-12 02:05:35 EST --- lv2-abGate-1.1.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/lv2-abGate-1.1.3-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2012-01-12 02:05:44 EST --- lv2-abGate-1.1.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lv2-abGate-1.1.3-2.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-01-15 14:59:51 EST --- Package lv2-abGate-1.1.3-2.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lv2-abGate-1.1.3-2.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-0505/lv2-abGate-1.1.3-2.... then log in and leave karma (feedback).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |lv2-abGate-1.1.3-2.fc16 Resolution| |ERRATA Last Closed|2012-01-11 06:47:13 |2012-02-02 12:24:41
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2012-02-02 12:24:41 EST --- lv2-abGate-1.1.3-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754004
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|lv2-abGate-1.1.3-2.fc16 |lv2-abGate-1.1.3-2.fc15
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2012-02-02 12:28:00 EST --- lv2-abGate-1.1.3-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla