[Bug 2182905] New: Review Request: oidc-agent - Command-line tool for obtaining OpenID Connect access tokens
5:55 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
Bug ID: 2182905
Summary: Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: steve.traylen(a)cern.ch
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: http://cern.ch/straylen/rpms/oidc-agent/oidc-agent.spec
SRPM URL:
http://cern.ch/straylen/rpms/oidc-agent/oidc-agent-4.5.1-1.fc39.src.rpm
Description: Command-line tool for obtaining OpenID Connect access tokens
Fedora Account System Username: stevetraylen
This is re-submission of oidc-agent that was originally submitted here:
https://bugzilla.redhat.com/show_bug.cgi?id=1997994
User vokac has agreed that I can take over the submission of oidc-agent.
I will follow up shortly with the items from that review that have and have not
been resolved.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
6:09 p.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
Steve Traylen <steve.traylen(a)cern.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Steve Traylen <steve.traylen(a)cern.ch> ---
From #1997994
* Dynamic requires are now relied upon - no explicit requires unless needed.
* Bundling
* Now using a system builds of liblist (clib-list)
* Now using a system build of cjson
* mustache is no longer needed as desktop package is removed.
* src/oidc-gen/qr.c is still based on another lib but is not the whole lib.
* windows binarys have gone , I guess upstream.
* /etc/X11/Xsession.d has gone because the desktop ( useless on wayland
anyway )
* Package now owns /etc/oidc-agent
* all %defattr have gone.
* src/oidc-prompt/html/static/css/lib/bootstrap.min.css has gone since
desktop package gone.
* BuildRoot gone.
* The -p for install has been added upstream.
* license file is now only liboidc-agent package which is required by all
packages.
* libsodium-static is no longer used or linked to.
* Files inside %{_datadir}/bash-completion/completions/ are now explictly
owned rather than duplicating the
directory ownership.
* Source URL is better (%forge macros)
* This spec file is soly for Fedora and in time EPEL - it will not track
upstream spec file.
* %(__rm), %{_sed) replace with rm , sed.
* suse conditionals all gone
rpmlint is now clean.
* Todo
* src/oidc-prompt/html/static/css/lib/bootstrap.min.css should be removed
from source in %prep (if still there)
* Couple of patches need some work.
* Understand what happened between F38 and F38 with respect to directories
for created objects.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
11:09 p.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
Petr Vokac <vokac(a)fjfi.cvut.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vokac(a)fjfi.cvut.cz
--- Comment #2 from Petr Vokac <vokac(a)fjfi.cvut.cz> ---
*** Bug 1997994 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
2:09 a.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
Steve Traylen <steve.traylen(a)cern.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On| |2163447
--- Comment #3 from Steve Traylen <steve.traylen(a)cern.ch> ---
#2163447 is desktop dependency for mustach - re-add desktop after available.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2163447
[Bug 2163447] Review Request: mustach - Tiny Mustach processor
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
8:33 a.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
Steve Traylen <steve.traylen(a)cern.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On|2163447 |
--- Comment #4 from Steve Traylen <steve.traylen(a)cern.ch> ---
Building without GUI component which allows us to build with out some of the
harder dependencies.
[fedora-review-service-build]
Spec URL: http://cern.ch/straylen/rpms/oidc-agent/oidc-agent.spec
SRPM URL:
http://cern.ch/straylen/rpms/oidc-agent/oidc-agent-4.5.1-1.fc39.src.rpm
* the parallel make is now fixed with respect to object creation.
* src/oidc-prompt/html/static/css/lib/bootstrap.min.css is now being removed
in %prep state to ensure it is not being used.
Ready for a review.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2163447
[Bug 2163447] Review Request: mustach - Tiny Mustach processor
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
1:11 p.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
--- Comment #5 from Steve Traylen <steve.traylen(a)cern.ch> ---
[fedora-review-service-build]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
5:21 a.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
--- Comment #6 from hardt(a)kit.edu ---
We have worked on further removing code used from others by moving it into
separate packages.
I.e. you could remove certain parts of the code, when installing the required
dependencies:
cjson: (part of fedora)
rm -rf lib/cJSON
export USE_CJSON_SO=1
spec file:
BuildRequires: cjson-devel
or
BuildRequires: cJSON-devel
clibs/list: (part of fedora)
rm -rf lib/list
export USE_LIST_SO=1
spec file:
BuildRequires: clibs-list-devel
[..]
%package -n oidc-agent-cli
Requires: clibs-list
[..]
%package -n liboidc-agent4
Requires: clibs-list
[..]
%package -n oidc-agent-desktop
Requires: clibs-list
mustach: (packaging approved, but not yet part of fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=2163447)
rm -rf src/oidc-prompt/mustache
export USE_MUSTACHE_SO=1
spec file:
BuildRequires: mustach-lib-cjson-devel
[..]
%package -n oidc-agent-desktop
Requires: mustach-lib-cjson
Only for oidc-agent-desktop:
simple.css (replaces dependency on bootswatch)
Package submitted for review:
https://bugzilla.redhat.com/show_bug.cgi?id=2189488
rm -rf src/oidc-prompt/html/static/css/lib/bootstrap.min.css
spec file:
BuildRequires: simple.css
I'm not 100% sure whether I forgot a runtime dependency, but I can't test
this sufficiently well right now. I'll be AFK for 4 weeks, so I wanted to
send this update nevertheless.
Best,
Marcus.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
4:08 a.m.
New subject: [Bug 2182905] Review Request: oidc-agent - Command-line tool for
obtaining OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
Steve Traylen <steve.traylen(a)cern.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|NEW |CLOSED
Flags|needinfo?(steve.traylen@cer |
|n.ch) |
Last Closed| |2024-05-25 09:08:38
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
4:08 a.m.
New subject: needinfo canceled: [Bug 2182905] Review Request: oidc-agent -
Command-line tool for obtaining OpenID Connect access tokens
Product: Fedora
Version: rawhide
Component: Package Review
Steve Traylen <steve.traylen(a)cern.ch> has canceled Package Review
<package-review(a)lists.fedoraproject.org>'s request for Steve Traylen
<steve.traylen(a)cern.ch>'s needinfo:
Bug 2182905: Review Request: oidc-agent - Command-line tool for obtaining
OpenID Connect access tokens
https://bugzilla.redhat.com/show_bug.cgi?id=2182905
23
days inactive
446
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
bugzilla＠redhat.com