[Bug 2235075] New: Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Bug ID: 2235075
           Summary: Review Request: python-pip-requirements-parser -
                    Mostly correct pip requirements parsing library
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser....
SRPM URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-...

Description:
This is an experimental Python library to enable POSIX parameter expansion in a
string. It supports also a subset of Bash parameter expansion.

Fedora Account System Username: eclipseo

To build it against the dependencies, use the following COPR in your rawhide
mock.cfg:

[copr:copr.fedorainfracloud.org:eclipseo:scancode-toolkit]
name=Copr repo for scancode-toolkit owned by eclipseo
baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit...
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit...
repo_gpgcheck=0
enabled=1
enabled_metadata=1

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2235055 (scancode-toolkit)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2235055
[Bug 2235055] Review Request: scancode-toolkit - Scan code and detect licenses,
copyrights, and more.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Miroslav Suchý  ---
It seems that the description is, by mistake, copied from
python-parameter-expansion-patched.

And the -doc subpackage should contains:
Provides: bundled(jquery)
Provides: bundled(js-searchtools)

Otherwise LGTM.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #2 from Robert-André Mauchin 🐧  ---
> It seems that the description is, by mistake, copied from python-parameter-expansion-patched.

fixed
> And the -doc subpackage should contains:
> Provides: bundled(jquery)
> Provides: bundled(js-searchtools)

ok

Thanks for the review.

Spec URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser....
SRPM URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-...

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |)                           |

--- Comment #3 from Miroslav Suchý  ---
The "Provides" should go to -doc package. I.e.

%package -n python-%{pypi_name}-doc
Summary:        Documentation for python-%{pypi_name}
BuildArch:      noarch
Provides:       bundled(jquery)
Provides:       bundled(js-searchtools)

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/nexB/pip
                   |                            |-requirements-parser

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6532612
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #5 from Robert-André Mauchin 🐧  ---
(In reply to Miroslav Suchý from comment #3)
> The "Provides" should go to -doc package. I.e.
>
> %package -n python-%{pypi_name}-doc
> Summary:        Documentation for python-%{pypi_name}
> BuildArch:      noarch
> Provides:       bundled(jquery)
> Provides:       bundled(js-searchtools)

Done. Thank you.

Spec URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser....
SRPM URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-...

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |)                           |

--- Comment #6 from Miroslav Suchý  ---
Is it possible that you forgot to upload the altered spec and src.rpm? I still
see the provides in main package. And I double check I am not seeing cached
version.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #7 from Robert-André Mauchin 🐧  ---
Update this way:

%package -n python-%{pypi_name}-doc
Summary:        Documentation for python-%{pypi_name}
# BSD-2-Clause: Sphinx javascript
# MIT: jquery
License:        MIT AND BSD-2-Clause
BuildArch:      noarch
Requires:       python3-%{pypi_name} = %{?epoch:%{epoch}:}%{version}-%{release}
Provides:       bundled(js-sphinx_javascript_frameworks_compat)
Provides:       bundled(js-doctools)
Provides:       bundled(js-jquery)
Provides:       bundled(js-language_data)
Provides:       bundled(js-searchtools)

Spec URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser....
SRPM URL:
https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-...

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?([e-mail] |
                   |)                           |

--- Comment #8 from Miroslav Suchý  ---
APPROVED

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

--- Comment #9 from Robert-André Mauchin 🐧  ---
Thank you so much!

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

--- Comment #10 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pip-requirements-parser

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #11 from Fedora Update System  ---
FEDORA-2023-3aa6ce0b7e has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-3aa6ce0b7e

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

--- Comment #12 from Fedora Update System  ---
FEDORA-2023-67d1d7288b has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-67d1d7288b

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #13 from Fedora Update System  ---
FEDORA-2023-3aa6ce0b7e has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-3aa6ce0b7e *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-3aa6ce0b7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

--- Comment #14 from Fedora Update System  ---
FEDORA-2023-67d1d7288b has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-67d1d7288b *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-67d1d7288b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-11-07 01:38:56

--- Comment #15 from Fedora Update System  ---
FEDORA-2023-3aa6ce0b7e has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2235075] Review Request: python-pip-requirements-parser - Mostly correct pip requirements parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=2235075

--- Comment #16 from Fedora Update System  ---
FEDORA-2023-67d1d7288b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.