[Bug 215200] New: Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
4:31 a.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
Summary: Review Request: php-pear-Services-Weather - This class
acts as an interface to various online weather-services
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: Fedora(a)FamilleCollet.com
QAContact: fedora-package-review(a)redhat.com
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Services-Weather.spec
SRPM URL:
http://remi.collet.free.fr/rpms/extras/php-pear-Services-Weather-1.4.0-1....
Mock Log: http://remi.collet.free.fr/rpms/extras/php-pear-Services-Weather-build.log
Description:
Services_Weather searches for given locations and retrieves current
weather data and, dependent on the used service, also forecasts.
Up to now, GlobalWeather from CapeScience, Weather XML from EJSE (US
only), a XOAP service from Weather.com and METAR/TAF from NOAA are
supported. Further services will get included, if they become available,
have a usable API and are properly documented.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
4:33 a.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
Fedora(a)FamilleCollet.com changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |214236
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
6:04 p.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
chris.stone(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody(a)fedoraproject.org |chris.stone(a)gmail.com
Alias| |pear-Svcs-Weather
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
1:28 a.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
Bug 215200 depends on bug 214236, which changed state.
Bug 214236 Summary: Review Request: php-pear-SOAP - Simple Object Access Protocol (SOAP)
Client/Server for PHP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214236
What |Old Value |New Value
----------------------------------------------------------------------------
Resolution| |NEXTRELEASE
Status|ASSIGNED |CLOSED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
11:15 a.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
------- Additional Comments From chris.stone(a)gmail.com 2006-11-18 12:15 EST -------
Hi Remi, quick comment before I start the formal review. I looked over your spec
file and I wonder why you choose to use # as your delimiter character in your
sed command? # is used as a comment in a spec file and this looks very
confusing to a reader of the spec file, please change # to @ instead.
Also you use %{__sed} however you do not use macros for any other of your system
commands, you should be consistent and just use "sed", I think it came up
during
the discussion of creating the template that macro usage for system commands was
only needed in %post(pre)/%post(pre)un sections.
Therefore, I would change the sed line to read:
sed -i -e s@/usr/local/bin/php@%{_bindir}/php@
$RPM_BUILD_ROOT%{pear_datadir}/%{pear_name}/buildMetarDB.php
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
11:39 a.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
------- Additional Comments From chris.stone(a)gmail.com 2006-11-18 12:39 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- spec written in American english
X spec file is not legible, see comment #1 above.
- sed command obfuscated by using comment character (#) as delimeter
- source match upstream
a83fbf5e2e7ffd22219c513cfefe6b52 Services_Weather-1.4.0.tgz
- successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- not relocatable
- owns all directories it creates
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- although you use %{__sed} when you dont use macros for any other system command
- contains code
- no large documentation
- files in %doc do not affect run time
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- not a GUI app needing a .desktop file
- does not own files or directories owned by other packages
==== MUST ====
- Unobfuscate sed command by using @ instead of # as delimiter (# is used as a
comment character in spec files)
==== SHOULD ====
- Change %{__sed} to just "sed" to have consistent macro usage, macros for
system commands are only needed for %post/%pre,%postun/%preun sections
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
12:54 p.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
------- Additional Comments From Fedora(a)FamilleCollet.com 2006-11-18 13:54 EST -------
Hi, thanks for the review.
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Services-Weather.spec
SRPM URL:
http://remi.collet.free.fr/rpms/extras/php-pear-Services-Weather-1.4.0-2....
%changelog
* Sat Nov 18 2006 Remi Collet <Fedora(a)famillecollet.com> 1.4.0-2
- Unobfuscate sed command
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
12:55 p.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
------- Additional Comments From Fedora(a)FamilleCollet.com 2006-11-18 13:55 EST -------
SRPM URL:
http://remi.collet.free.fr/rpms/extras/php-pear-Services-Weather-1.4.0-2....
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
2:18 p.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
chris.stone(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From chris.stone(a)gmail.com 2006-11-18 15:18 EST -------
Looks good, APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
12:19 a.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215200
Fedora(a)FamilleCollet.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
10:57 p.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Services-Weather - This class acts as an interface to
various online weather-services
Alias: pear-Svcs-Weather
https://bugzilla.redhat.com/show_bug.cgi?id=215200
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
Version|devel |rawhide
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
2:53 a.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=215200
Remi Collet <fedora(a)famillecollet.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--- Comment #6 from Remi Collet <fedora(a)famillecollet.com> 2010-05-13 03:53:09 EDT
---
Package Change Request
======================
Package Name: php-pear-Services-Weather
New Branches: EL-6
Owners: remi
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
5:39 p.m.
New subject: [Bug 215200] Review Request: php-pear-Services-Weather - This class acts as an interface to various online weather-services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=215200
Dennis Gilmore <dennis(a)ausil.us> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Dennis Gilmore <dennis(a)ausil.us> 2010-05-13 18:39:43 EDT ---
CVS Done
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
5158
days inactive
6436
days old
package-review@lists.fedoraproject.org
12 comments
1 participants
participants (1)
-
Red Hat Bugzilla