Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: robert@marcanoonline.com QAContact: fedora-package-review@redhat.com
Spec URL: http://www.marcanoonline.com/downloads/fedora/package_submissions/dirvish/di... SRPM URL: http://www.marcanoonline.com/downloads/fedora/package_submissions/dirvish/di... Description: Dirvish is a fast, disk based, rotating network backup system. With dirvish you can maintain a set of complete images of your filesystems with unattended creation and expiration. A dirvish backup vault is like a time machine for your data.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051
------- Additional Comments From tibbs@math.uh.edu 2006-10-05 12:07 EST ------- First off, the spec says GPL but the license in certainly not the GPL: Licensed under the Open Software License version 2.0 And as a bonus, v2.0 of that license shouldn't be used. But I think it's still open source; it was version 1.1 that had problems.
Also, the actual license needs to be included in the package, since it's present in the tarball.
* source files match upstream: 892ec9333b19e623880cdb499443c11b dirvish-1.2.1.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. X license field matches the actual license. * license is open source-compatible. X License text included upstream but is not in the final package. * latest version is being packaged. * BuildRequires are proper (BR: perl is not necessary) * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: dirvish = 1.2.1-1.fc6 = /usr/bin/perl perl(File::Find) perl(Getopt::Long) perl(POSIX) perl(Time::ParseDate) perl(Time::Period) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * not a GUI app.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051
------- Additional Comments From robert@marcanoonline.com 2006-10-05 13:28 EST ------- ooooops big mistake.. fixed
http://www.marcanoonline.com/downloads/fedora/package_submissions/dirvish/di... http://www.marcanoonline.com/downloads/fedora/package_submissions/dirvish/di...
the OSL 2.0 is not recommended any more (it was superceded by version 2.1 and 3.0 but it was approved by the OSI (see http://opensource.org/licenses/osl-2.0.php)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-10-05 19:14 EST ------- Builds fine and looks good. The only issue is that rpmlint is now complaining: W: dirvish invalid-license OSL The license tag accurately describes the license, so this should be OK.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208051
robert@marcanoonline.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From robert@marcanoonline.com 2006-10-05 21:44 EST ------- thanks...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=208051
Robert Marcano robert@marcanoonline.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Robert Marcano robert@marcanoonline.com 2009-04-06 09:10:58 EDT --- Package Change Request ====================== Package Name: dirvish New Branches: EL-5 Owners: robmv
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=208051
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Kevin Fenzi kevin@tummy.com 2009-04-06 23:13:29 EDT --- cvs done.
package-review@lists.fedoraproject.org