[Bug 2242022] New: Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Bug ID: 2242022
           Summary: Review Request: swiftlint - Tool to enforce Swift
                    style and conventions
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint.spec
SRPM URL:
https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint-0.53.0-1.fc40.s...

Description:
SwiftLint is a tool to enforce Swift style and conventions, loosely based on
the now archived GitHub Swift Style Guide. SwiftLint enforces the style guide
rules that are generally accepted by the Swift community. These rules are well
described in popular style guides like Kodeco's Swift Style Guide.

SwiftLint hooks into Clang and SourceKit to use the AST representation of your
source files for more accurate results.

Fedora Account System Username: dcavalca

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Davide Cavalca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Davide Cavalca  ---
This is a preliminary WIP I'm putting up for feedback, it needs more work for
sure before it can be approved (see the comments in the spec for details).

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
         Whiteboard|                            |NotReady
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #3 from Davide Cavalca  ---
Spec URL: https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint.spec
SRPM URL:
https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint-0.53.0-1.fc40.s...

Changelog:
- fix %doc usage
- do a release build by default

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #4 from Davide Cavalca  ---
Spec URL: https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint.spec
SRPM URL:
https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint-0.53.0-1.fc40.s...

Changelog:
- rework bundled deps handling to autogenerate provides as well
- patch fallback library path to avoid segfault
- enable tests by default

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #5 from Ron Olson  ---
Thanks for working on this; I've been wanting this tool available on Fedora
since Swift became available. :)

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #6 from Davide Cavalca  ---
There's three (likely all related issues remaining):
- the build isn't using the right cflags/ldflags and I can't find a sane way to
pass them
- the debuginfo that's generated seems to be in dwarf 5 format and debugedit
can't cope with it
- the resulting binary has some unnecessary rpath we're currently removing
manually

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Neal Gompa  ---
debugedit is supposed to be able to cope with DWARF 5:
https://src.fedoraproject.org/rpms/rpm/c/652537b1a5ac5c0e5b1974a4b31346db18a...

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #8 from Davide Cavalca  ---
I'm trying this to get the right flags passed

%prep
echo -n 'swift build -v -c %{config} %{?_smp_build_ncpus:-j
%{_smp_build_ncpus}} ' > build.sh
for flag in %build_cflags; do
  echo -n "-Xcc ${flag} " >> build.sh
done
for flag in %build_cxxflags; do
  echo -n "-Xcxx ${flag} " >> build.sh
done
for flag in %build_ldflags; do
  echo -n "-Xlinker ${flag} " >> build.sh
done

%build
sh -x build.sh

and it does "work" but the build ultimately fails with

/usr/libexec/swift/5.8.1/bin/swiftc -g -L
/builddir/build/BUILD/SwiftLint-0.53.0/.build/aarch64-unknown-linux-gnu/release
-o
/builddir/build/BUILD/SwiftLint-0.53.0/.build/aarch64-unknown-linux-gnu/release/swiftlint
-module-name swiftlint -emit-executable -Xlinker --gc-sections -Xlinker
--defsym -Xlinker main=swiftlint_main -Xlinker '-rpath=$ORIGIN'
@/builddir/build/BUILD/SwiftLint-0.53.0/.build/aarch64-unknown-linux-gnu/release/swiftlint.product/Objects.LinkFileList
-target aarch64-unknown-linux-gnu -Xlinker -Wl,-z,relro -Xlinker
-Wl,--as-needed -Xlinker -Wl,-z,now -Xlinker -flto=thin -Xlinker
-Wl,--build-id=sha1 -Xcc -O2 -Xcc -flto=thin -Xcc -fexceptions -Xcc -g -Xcc
-grecord-gcc-switches -Xcc -pipe -Xcc -Wall -Xcc -Werror=format-security -Xcc
-Werror=implicit-function-declaration -Xcc -Werror=implicit-int -Xcc
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Xcc -Wp,-D_GLIBCXX_ASSERTIONS -Xcc
--config -Xcc /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -Xcc
-fstack-protector-strong -Xcc -mbranch-protection=standard -Xcc
-fasynchronous-unwind-tables -Xcc -fno-omit-frame-pointer -Xcc
-mno-omit-leaf-frame-pointer -v -L /usr/libexec/swift/5.8.1/lib
Swift version 5.8.1 (swift-5.8.1-RELEASE)
Target: aarch64-unknown-linux-gnu
/usr/libexec/swift/5.8.1/bin/swift-autolink-extract
@/tmp/TemporaryDirectory.1jtY4M/arguments-4662626656583931728.resp
error: autolink-extract command failed with exit code 1 (use -v to see
invocation)
<unknown>:0: error: error opening input file
'/builddir/build/BUILD/SwiftLint-0.53.0/.build/aarch64-unknown-linux-gnu/release/CYaml.build/src/api.c.o'
(The file was not recognized as a valid object file
)
error: Bad exit status from /var/tmp/rpm-tmp.55d6Iz (%build)
    Bad exit status from /var/tmp/rpm-tmp.55d6Iz (%build)

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Mark Wielaard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]              |[e-mail]

--- Comment #9 from Mark Wielaard  ---
(In reply to Neal Gompa from comment #7)
> debugedit is supposed to be able to cope with DWARF 5:
> https://src.fedoraproject.org/rpms/rpm/c/
> 652537b1a5ac5c0e5b1974a4b31346db18a19d59

For GCC generated DWARF5, llvm generates something debugedit cannot handle yet:
https://sourceware.org/bugzilla/show_bug.cgi?id=28728
Workaround is to use -gdwarf-4 till this is fixed.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #10 from Davide Cavalca  ---
For the record, the "right" way to pass the linker flags is

for flag in %(echo %build_ldflags | tr ',' ' '); do
  # These are passed directly to the linker, not to the compiler
  if [ "$flag" != '-Wl' ]; then
    echo -n "-Xlinker ${flag} " >> build.sh
  fi
done

but this still doesn't build successfully

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #11 from Davide Cavalca  ---
Spec URL: https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint.spec
SRPM URL:
https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint-0.53.0-1.fc40.s...

Changelog:
- pass build id ldflags and force DRAWF4
- enable debug package generation
- enable parallel build

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #12 from Davide Cavalca  ---
With the latest update I think this is ready for review.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Davide Cavalca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|NotReady                    |

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #13 from Neal Gompa  ---
Spec review:
> Source:         %{forgeurl}/archive/%{version}/%{srcname}-%{version}.tar.gz
> # Build cache of the bundled dependencies so we can build offline
> Source:         %{srcname}-%{version}-bundled-deps.tar.gz
> Source:         %{srcname}-%{version}-bundled-provides.txt
> Source:         swiftlint-get-bundled-deps.sh

As you use the numbered Source variables in the spec, please use numbered
Sources too.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #14 from Davide Cavalca  ---
Spec URL: https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint.spec
SRPM URL:
https://dcavalca.fedorapeople.org/review/swiftlint/swiftlint-0.53.0-1.fc40.s...

Changelog:
- use numbered Sources

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #15 from Fedora Review Service  ---
Created attachment 1993655
  --> https://bugzilla.redhat.com/attachment.cgi?id=1993655&action=edit
The .spec file difference from Copr build 6493717 to 6520906

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #16 from Neal Gompa  ---
> # Swift only supports these arches
> ExclusiveArch:  x86_64 aarch64

Future note: when designing macros for packaging swift stuff, don't forget to
macroize this.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #17 from Neal Gompa  ---
Review notes:

* Package follows Fedora Packaging Guidelines (well, as well as it can given
the lack of Swift guidelines so far)
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint (modulo weirdness caused by... well this
package)

PACKAGE APPROVED.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #18 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/swiftlint

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #19 from Fedora Update System  ---
FEDORA-2023-5b1548897b has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-5b1548897b

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-10-17 18:46:10

--- Comment #20 from Fedora Update System  ---
FEDORA-2023-5b1548897b has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #21 from Fedora Update System  ---
FEDORA-2023-db294cb0c6 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-db294cb0c6

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #22 from Fedora Update System  ---
FEDORA-2023-9db2651150 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-9db2651150

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #23 from Fedora Update System  ---
FEDORA-2023-9db2651150 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-9db2651150 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-9db2651150

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #24 from Fedora Update System  ---
FEDORA-2023-db294cb0c6 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-db294cb0c6 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-db294cb0c6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #25 from Fedora Update System  ---
FEDORA-EPEL-2023-21db6471b3 has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-21db6471b3

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #26 from Fedora Update System  ---
FEDORA-EPEL-2023-21db6471b3 has been pushed to the Fedora EPEL 9 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-21db6471b3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #27 from Fedora Update System  ---
FEDORA-EPEL-2023-21db6471b3 has been pushed to the Fedora EPEL 9 stable
repository.
If problem still persists, please make note of it in this bug report.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #28 from Fedora Update System  ---
FEDORA-2023-9db2651150 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #29 from Fedora Update System  ---
FEDORA-2023-db294cb0c6 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-db294cb0c6 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-db294cb0c6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2242022] Review Request: swiftlint - Tool to enforce Swift style and conventions

https://bugzilla.redhat.com/show_bug.cgi?id=2242022

--- Comment #30 from Fedora Update System  ---
FEDORA-2023-db294cb0c6 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.