Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
Summary: Review Request: perl-Class-MakeMethods Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
Spec URL: http://home.comcast.net/~ckweyl/perl-Class-MakeMethods.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-MakeMethods-1.01-0.fc5.src.rpm
Description: The Class::MakeMethods framework allows Perl class developers to quickly define common types of methods. When a module uses Class::MakeMethods or one of its subclasses, it can select from a variety of supported method types, and specify a name for each method desired. The methods are dynamically generated and installed in the calling package.
Construction of the individual methods is handled by subclasses. This delegation approach allows for a wide variety of method-generation techniques to be supported, each by a different subclass. Subclasses can also be added to provide support for new types of methods.
Over a dozen subclasses are available, including implementations of a variety of different method-generation techniques. Each subclass generates several types of methods, with some supporting their own open-eneded extension syntax, for hundreds of possible combinations of method types.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
Jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |Jochen@herr-schmitt.de
------- Additional Comments From Jochen@herr-schmitt.de 2006-07-03 15:46 EST ------- Good: + tarballs in SRPM match upstream version. + rpmlint doensn't complaints source rpm. + Local Build works fine. + Mock build works fine. + rpmlint doesn't complaints binary rpm. + License is the same as perl.
Bad: - perl should not be included - Package doesn't contain verbatin license text.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
------- Additional Comments From tibbs@math.uh.edu 2006-07-03 16:34 EST ------- Jochen, are you reviewing this? You should block FE-REVIEW instead of FE-NEW is you are.
Note that BR: perl is in the optional list; generally we don't see it as a blocker. I can't tell if you're inticating that it's a blocker or not.
Also note that it is quite rare for a Perl module to include the verbatim license text, and it not a blocker to fail to include the license text in the package when the upstream tarball does not include it.
Just some friendly comments. Thanks for helping out with the reviews.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
Jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163779 nThis| |
------- Additional Comments From Jochen@herr-schmitt.de 2006-07-04 13:44 EST ------- @Jason,
Thank you for your clarification.
@Christ,
After the clarification from Jason, I will be able to APPROVE you package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2006-07-05 11:47 EST ------- Imported and built for devel; will build for FC-[45] after branching.
Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
imlinux@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |imlinux@gmail.com
------- Additional Comments From imlinux@gmail.com 2006-07-05 11:52 EST ------- Is this actually Approved or still waiting for approval?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197484
------- Additional Comments From cweyl@alumni.drew.edu 2006-07-05 12:00 EST ------- Given the blocker bug was switched from FE-REVIEW to FE-ACCEPT, I understood comment #3 to be an approval.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-MakeMethods
https://bugzilla.redhat.com/show_bug.cgi?id=197484
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=197484
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag| |fedora-cvs?
--- Comment #7 from Iain Arnell iarnell@gmail.com 2010-09-02 10:27:19 EDT --- Package Change Request ====================== Package Name: perl-Class-MakeMethods New Branches: el6 Owners: iarnell tremble
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=197484
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2010-09-02 17:16:44 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla