[Bug 484279] New: Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Summary: Review Request: BareBonesBrowserLaunch - Simple
                    library to launch a browser window from Java
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://jmatthews.fedorapeople.org/BareBonesBrowserLaunch/1.5/1/BareBonesBrow...
SRPM URL:
http://jmatthews.fedorapeople.org/BareBonesBrowserLaunch/1.5/1/BareBonesBrow...
Description: 
Utility class to open a web page from a Swing application in the user's 
default browser. Supports: Mac OS X, GNU/Linux, Unix, Windows XP

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

John Matthews  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

John Matthews  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |484281

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

--- Comment #1 from John Matthews   2009-03-25 12:52:32 EDT ---
Does anyone have time to review this? It's part of work required to get
hadoop/nutch packaged.

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #2 from Dan Horák   2009-03-25 13:46:47 EDT ---
formal review is here, see the notes below:

OK source files match upstream, checked with diff
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
BAD doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK* file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- move the *.class removal from %build to %prep
- the %files section for the main package must contain only the *.jar, not the
whole %{_javadir}, use %{_javadir}/*
- use plain %defattr(-,root,root,-) for the javadoc subpackage
- the javadoc documentation shouldn't be marked as %doc and
%{_javadocdir}/%{name} directory should exist, other packages create this as a
symlink to the versioned directory
- all the points above are based on
https://fedoraproject.org/wiki/Packaging/Java

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Vedran Miletić  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |needinfo?(jmatthew@redhat.c
                   |                            |om)

--- Comment #3 from Vedran Miletić   2009-11-04 17:22:26 EDT ---
Hi, is anyone working on this? I'm very interested in having Hadoop in Fedora,
and willing to help it happen if I can.

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

John Matthews  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(jmatthew@redhat.c |
                   |om)                         |

--- Comment #4 from John Matthews   2009-11-12 10:35:18 EDT ---
Hello Vedran,

If you would like to pick this up, and finish the packaging, feel free.

As to the work done for bringing Hadoop into Fedora.  We created a wiki page
for Spacewalk below, listing out the deps and what was needed, as you'll see
this was for an older Nutch/Hadoop.

https://fedorahosted.org/spacewalk/wiki/GettingPackagesIntoFedora/Nutch

Regards,
John

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

--- Comment #5 from Vedran Miletić   2009-11-12 11:18:31 EDT ---
Sure, I will look into it these days and see if I can do something.

Can Cloudera packages be helpful in this case?

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Orion Poplawski   2009-12-28 18:58:24 EDT ---
How about this:

http://www.cora.nwra.com/~orion/fedora/BareBonesBrowserLaunch-2.0-1.fc12.src...
http://www.cora.nwra.com/~orion/fedora/BareBonesBrowserLaunch.spec

* Mon Dec 28 2009 Orion Poplawski  2.0-1
- Update to 2.0
- Use upstream jar source directly
- Cleanup spec

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

--- Comment #7 from Dan Horák   2010-01-05 06:15:48 EDT ---
(In reply to comment #6)
> How about this:
>
> http://www.cora.nwra.com/~orion/fedora/BareBonesBrowserLaunch-2.0-1.fc12.src...
> http://www.cora.nwra.com/~orion/fedora/BareBonesBrowserLaunch.spec
> Mon Dec 28 2009 Orion Poplawski  2.0-1
> Update to 2.0
> Use upstream jar source directly
> Cleanup spec

Orion, do you want to step in as the submitter/maintainer?

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

--- Comment #8 from Orion Poplawski   2010-01-05 10:17:09 EDT ---
(In reply to comment #7)
> Orion, do you want to step in as the submitter/maintainer?

I'm happy to do so.

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

--- Comment #9 from Dan Horák   2010-01-06 06:55:17 EDT ---
Ok, then lets continue. All issues from comment #2 besides one are fixed in the
latest spec file. What remains is non-existency of non-versioned directory with
the javadoc documentation as written in the guidelines for Java packages.
Adding a non-versioned symlink is also possible.

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

--- Comment #10 from Orion Poplawski   2010-01-06 10:42:56 EDT ---
http://www.cora.nwra.com/~orion/fedora/BareBonesBrowserLaunch-2.0-2.fc12.src...
http://www.cora.nwra.com/~orion/fedora/BareBonesBrowserLaunch.spec

* Wed Jan 6 2010 Orion Poplawski  2.0-2
- Unversion javadoc dir

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Dan Horák   2010-01-06 10:52:08 EDT ---
Thanks, the package is now APPROVED.

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #12 from Orion Poplawski   2010-01-06 11:07:53 EDT ---
New Package CVS Request
=======================
Package Name:  BareBonesBrowserLaunch
Short Description: Simple library to launch a browser window from Java
Owners: orion
Branches: F-12 F-11 EL-5
InitialCC:

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #13 from Kevin Fenzi   2010-01-06 16:33:52 EDT ---
cvs done.

[Bug 484279] Review Request: BareBonesBrowserLaunch - Simple library to launch a browser window from Java

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=484279

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #14 from Orion Poplawski   2010-01-06 16:48:47 EDT ---
Checked in and built.  Updates to follow shortly.  Thanks all...