[Bug 2244781] New: Review Request: hyprpaper - Blazing fast wayland wallpaper utility with IPC controls
3:34 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Bug ID: 2244781
Summary: Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
Product: Fedora
Version: rawhide
Status: NEW
Component: Package Review
Assignee: nobody(a)fedoraproject.org
Reporter: daron439(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://solopasha.fedorapeople.org/reviews/hyprpaper/hyprpaper.spec
SRPM URL:
https://solopasha.fedorapeople.org/reviews/hyprpaper/hyprpaper-0.4.0-1.fc...
Description:
Hyprpaper is a blazing fast wallpaper utility for Hyprland with the ability
to dynamically change wallpapers through sockets. It will work on all
wlroots-based compositors, though.
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=107694088
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
3:46 a.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Fedora Review Service <fedora-review-bot(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://github.com/hyprwm/h
| |yprpaper
--- Comment #1 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6542113
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:59 p.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
--- Comment #2 from Pavel Solovev <daron439(a)gmail.com> ---
Spec URL: https://solopasha.fedorapeople.org/reviews/hyprpaper/hyprpaper.spec
SRPM URL:
https://solopasha.fedorapeople.org/reviews/hyprpaper/hyprpaper-0.6.0-1.fc...
Update to 0.6.0
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=111625063
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:09 p.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
--- Comment #3 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Created attachment 2008339
--> https://bugzilla.redhat.com/attachment.cgi?id=2008339&action=edit
The .spec file difference from Copr build 6542113 to 6885891
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:09 p.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Fedora Review Service <fedora-review-bot(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |AutomationTriaged
--- Comment #4 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6885891
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
6:15 a.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Doc Type|--- |If docs needed, set a value
CC| |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #5 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
Explain the license breakdown in a comment.
[!]: Latest version is packaged.
Bump to the latest version v0.7.0.
Package approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-Clause License",
"Historical
Permission Notice and Disclaimer - sell variant and/or NTP License
(legal disclaimer)". 36 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/hyprpaper/review-
hyprpaper/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 7559 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: hyprpaper-0.7.0-1.fc41.x86_64.rpm
hyprpaper-debuginfo-0.7.0-1.fc41.x86_64.rpm
hyprpaper-debugsource-0.7.0-1.fc41.x86_64.rpm
hyprpaper-0.7.0-1.fc41.src.rpm
==============================================================================================================
rpmlint session starts
==============================================================================================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp7c0e2bx7')]
checks: 32, packages: 4
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
6:59 a.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
--- Comment #6 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/hyprpaper
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
7:04 a.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
--- Comment #7 from Pavel Solovev <daron439(a)gmail.com> ---
Thank you for the review, 0.7.0 IPC doesn't work with hyprland 0.39.1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
9:57 p.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-c7bf7252de (hyprpaper-0.6.0-1.fc41) has been submitted as an update
to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c7bf7252de
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
10 p.m.
New subject: [Bug 2244781] Review Request: hyprpaper - Blazing fast wayland
wallpaper utility with IPC controls
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
Last Closed| |2024-05-23 03:00:34
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-c7bf7252de (hyprpaper-0.6.0-1.fc41) has been pushed to the Fedora
41 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244781
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
25
days inactive
243
days old
package-review@lists.fedoraproject.org
9 comments
1 participants
participants (1)
-
bugzilla＠redhat.com