https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Bug ID: 1016200 Summary: Review Request: (unorphan) global - Source code tag system Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pzhukov@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://landgraf.fedorapeople.org/packages/requested/global/global.spec SRPM URL: http://landgraf.fedorapeople.org/packages/requested/global/global-6.2.9-1.fc...
Description: GNU GLOBAL is a source code tag system that works the same way across diverse environments. It supports C, C++, Yacc, Java, PHP and assembler source code.
Fedora Account System Username:landgraf
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
--- Comment #1 from Pavel Zhukov pzhukov@redhat.com --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6032750
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com Assignee|nobody@fedoraproject.org |lemenkov@gmail.com Flags| |fedora-review+
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
work ~: rpmlint ~/Desktop/global-* ~/Desktop/emacs-global-* global.src:3: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)
^^^ A minor cosmetic issue. Please fix that before uploading.
global.src: E: specfile-error warning: bogus date in %changelog: Fri Apr 7 2005 Michael Schwendt <mschwendt[AT]users.sf.net>
^^^ A minor cosmetic issue. Please fix that before uploading.
global.x86_64: W: manual-page-warning /usr/share/man/man1/global.1.gz 224: warning: macro `./../../usr/src/sys/libkern/strlen.c' not defined global.x86_64: W: manual-page-warning /usr/share/man/man1/global.1.gz 228: warning: macro `./../../usr/src/lib/libc/string/strlen.c' not defined
^^^ These two should be reported upstream (if not fixed there already)/
global.x86_64: E: non-executable-script /usr/share/gtags/completion.cgi.tmpl 0644L /usr/bin/perl global.x86_64: E: non-executable-script /usr/share/gtags/ghtml.cgi.tmpl 0644L /bin/sh global.x86_64: E: non-executable-script /usr/share/gtags/bless.sh.tmpl 0644L /bin/sh global.x86_64: E: non-executable-script /usr/share/gtags/global.cgi.tmpl 0644L /usr/bin/perl
^^^ I suppose that these files have to have shebang (they are templates necessary for a normal operation).
global-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/global-6.2.9/libltdl/.libs global-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/global-6.2.9/libltdl/.libs
^^^ I'm not an autotools expert but looks like .libs should be somehow marked as "ignored". I think this should be reported upstream.
global-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/global-6.2.9/libglibc/regex.h global-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/global-6.2.9/libglibc/regex.c
^^^ Just chmod 644 them in the %prep section.
global-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/global-6.2.9/libglibc/getopt.h
^^^ Although some other fellow maintainers insists that we should fix this, I believe that only upstream should deal with legal things. Please report upstream about that.
emacs-global.noarch: W: no-documentation
^^^ Sad but true - this sub-package doesn't have them.
emacs-global-el.noarch: W: spelling-error Summary(en_US) Elisp -> Lisp, Elise, Elisa emacs-global-el.noarch: W: spelling-error %description -l en_US Elisp -> Lisp, Elise, Elisa
^^^ False positive.
emacs-global-el.noarch: W: no-documentation
^^^ Likewise. Sad but true - this sub-package doesn't have any documantation.
emacs-global-el.noarch: E: script-without-shebang /usr/share/emacs/site-lisp/gtags.el
^^^ I'm not an elisp expert, but I think it's harmless.
5 packages and 0 specfiles checked; 7 errors, 11 warnings. work ~:
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv2 or later with some BSD-licensed parts). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL.
work ~/rpmbuild/SOURCES: sha256sum global-6.2.9.tar.gz* d8d831cbd9bac9f51598af316231290cc328e4f18dc29b58a2f2ae0fee44c303 global-6.2.9.tar.gz d8d831cbd9bac9f51598af316231290cc328e4f18dc29b58a2f2ae0fee44c303 global-6.2.9.tar.gz.1 work ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths.
-/+ The package does bundles copies of system libraries (ltdl among them) but I don't want to insist on removing them right now. Please investigate the issue and either remove these libraries (build agaist system-wide ones) or ask FESCo for bundling exception:
* https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions
0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No C/C++ header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so) in some of the dynamic linker's default paths. 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8.
APPROVED
ps In the future please address all these issues (minor mostly) mentioned above.
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Pavel Zhukov pzhukov@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Pavel Zhukov pzhukov@redhat.com --- Note: this is deprecated package. SCM is already created
New Package SCM Request ======================= Package Name: global Short Description: Source code tag system Owners: landgraf Branches: f19 f20 rawhide InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Unretired devel, f19. Please take ownership of those and f18, and submit a Package Change request for f20.
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Pavel Zhukov pzhukov@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Pavel Zhukov pzhukov@redhat.com --- Package Change Request ====================== Package Name: global New Branches: F20 Owners: landgraf InitialCC: ======================
Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Please leave initialcc blank if not needed.
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Pavel Zhukov pzhukov@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- External Bug ID| |FedoraHosted 5792
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Pavel Zhukov pzhukov@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- External Bug ID|FedoraHosted 5792 |
--- Comment #7 from Pavel Zhukov pzhukov@redhat.com --- https://fedorahosted.org/rel-eng/ticket/5792
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- global-6.2.9-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/global-6.2.9-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- global-6.2.9-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/global-6.2.9-3.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- Package global-6.2.9-3.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing global-6.2.9-3.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-19608/global-6.2.9-3.fc2... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |global-6.2.9-3.fc19 Resolution|--- |ERRATA Last Closed| |2013-10-29 21:54:37
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- global-6.2.9-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1016200
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|global-6.2.9-3.fc19 |global-6.2.9-3.fc20
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- global-6.2.9-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla