https://bugzilla.redhat.com/show_bug.cgi?id=2330103
Bug ID: 2330103 Summary: Review Request: rust-asn1-rs - Rust parsers/encoders for ASN.1 BER/DER data Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: tfanelli@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/re... SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/ma... Description: Rust parsers/encoders for ASN.1 BER/DER data Fedora Account System Username: tfanelli
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/as | |n1-rs
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8335820 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #2 from Tyler Fanelli tfanelli@redhat.com --- Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/re... SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/ma... Description: Rust parsers/encoders for ASN.1 BER/DER data Fedora Account System Username: tfanelli
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8335889 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #4 from Tyler Fanelli tfanelli@redhat.com --- Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/re... SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/ma... Description: Rust parsers/encoders for ASN.1 BER/DER data Fedora Account System Username: tfanelli
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2060904 --> https://bugzilla.redhat.com/attachment.cgi?id=2060904&action=edit The .spec file difference from Copr build 8335889 to 8335929
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8335929 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #7 from Tyler Fanelli tfanelli@redhat.com --- Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/re... SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/ma... Description: Rust parsers/encoders for ASN.1 BER/DER data Fedora Account System Username: tfanelli
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2060907 --> https://bugzilla.redhat.com/attachment.cgi?id=2060907&action=edit The .spec file difference from Copr build 8335929 to 8335947
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8335947 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
Daniel Berrangé berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |berrange@redhat.com
--- Comment #10 from Daniel Berrangé berrange@redhat.com --- The automated builds being reported here are useless as they're against outdated stable Fedora which lacks the pre-req rust packages.
Doing a rawhide build though, shows a dependency flaw breaking test suite execution:
https://koji.fedoraproject.org/koji/taskinfo?taskID=126548833
error: no matching package named `bitvec` found location searched: registry `crates-io` required by package `asn1-rs-tests v0.0.0 (/builddir/build/BUILD/rust-asn1-rs-0.6.2-build/asn1-rs-0.6.2/target/tests/trybuild/asn1-rs)`
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |decathorpe@gmail.com Status|NEW |CLOSED Last Closed| |2024-12-05 19:25:02
--- Comment #11 from Fabio Valentini decathorpe@gmail.com --- This package has also already been submitted for review.
And it looks like Davide has figured out how to fix the tests.
*** This bug has been marked as a duplicate of bug 2312637 ***
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #12 from Tyler Fanelli tfanelli@redhat.com --- Thanks for letting me know. In the future, how can I check if a package was already submitted for review?
https://bugzilla.redhat.com/show_bug.cgi?id=2330103
--- Comment #13 from Fabio Valentini decathorpe@gmail.com --- There's a dashboard of pending package reviews here (reviewable are packages that aren't blocked, there's also other views for "hidden" / blocked or "in progress" reviews): https://fedoraproject.org/PackageReviewStatus/reviewable.html
If you use the fedora-create-review for filing your package review request tickets, it will also warn you about a pre-existing ticket for the same package before filing a new one.
package-review@lists.fedoraproject.org