[Bug 571993] New: Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Summary: Review Request: non-sequencer - A powerful, real-time,
                    pattern-based MIDI sequencer
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer.spec
SRPM URL:
http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer-0.0-1.2...
Description:

The Non Sequencer is a powerful real-time, pattern-based MIDI
sequencer for Linux-released under the GPL. Filling the void left by
countless DAWs, piano-roll editors, and other purely performance based
solutions, it is a composition tool-one that transforms MIDI
music-making on Linux from a complex nightmare into a pleasurable,
efficient, and streamlined process.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Martin Gieseking  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Martin Gieseking  2010-03-29 08:51:17 EDT ---
Just a couple of quick comments:

- according to the source file headers, the license seems to be GPLv2+

- add the following line to the %prep section in order to disable early
stripping of debuginfo:
sed -i '/^ifneq ($(USE_DEBUG),yes)/,+4 d' Makefile
(alternatively, you can patch the Makefile)

- the configure command in the %build section should look like this:
%configure --enable-lash

- I think, the documentation is extensive enough to put it in a separate doc
subpackage

- add TODO.mu to %doc

$ rpmlint /var/lib/mock/fedora-12-i386/result/*.rpm
non-sequencer.src:38: W: configure-without-libdir-spec
non-sequencer.src: W: invalid-url Source0:
non-sequencer-20100131gitba94d2c354145.tar.bz2
non-sequencer-debuginfo.i686: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #2 from Adam Huffman  2010-03-30 02:45:51 EDT ---
Thanks for taking a look.  I've uploaded a new version that addresses your
comments:

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer.spec

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer-1.9.3-2...

$ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm
non-sequencer.src: W: invalid-url Source0:
non-sequencer-20100131gitba94d2c354145.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

For me it comes up full-screen at startup - not sure whether that's a problem.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #3 from Martin Gieseking  2010-03-30 03:10:52 EDT ---
Now the doc directory is added twice. You can remove it from the base package.
:)
I'll have a look at the rest later today.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #4 from Adam Huffman  2010-03-30 03:48:35 EDT ---
Oops - fixed in release -3.

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer.spec

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer-1.9.3-3...

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #5 from Martin Gieseking  2010-03-30 16:38:42 EDT ---
I had a deeper look into the package and have to cancel my previous remark
about the doc package. Sorry! The documentation files are expected to be
installed with the base package. Otherwise the program's help doesn't work. 
Nonetheless, installing the doc files is a bit tricky.

a) the make statement in %build must look like this:
make VERBOSE=1 SYSTEM_PATH=%{_datadir}
DOCUMENT_PATH=%{_defaultdocdir}/%{name}-%{version}/doc/ %{?_smp_mflags}

It ensures compiling the final doc path into the program.

b) the %install section should contain the following lines:
sed -i "/.html/d" Makefile
make install DESTDIR=$RPM_BUILD_ROOT

c) and finally the %doc line in the %files section:
%doc COPYING doc/

Now the help should be available through the help menu of the application.

Like you, I wasn't able to start non-sequencer in its own window. It always
comes up full-screen. Maybe you should ask upstream whether that's a known
issue.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #6 from Adam Huffman  2010-04-06 19:27:32 EDT ---
Updated version with those latest changes at:

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer.spec

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer-1.9.3-3...

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Orcan 'oget' Ogetbil  2010-06-28 00:16:01 EDT ---
Hi, I'll review this package but there are two important issues that need to be
fixed first:

1- The build needs to be verbose. We want to see what flags are passed to the
compiler. Currently the compiler invocations are silent because of the lines
that start with @ in the Makefile. We need to patch or sed these out.

I am also not sure whether removing the whole "ifeq ($(USE_DEBUG),yes)" part
from the Makefile is right. This also removes -DNDEBUG, and other flags which
might be needed by the source, which I didn't check. Simply appending the
optflags at the end should be sufficient. Something like
   sed -i 's|DNDEBUG|DNDEBUG $(CXXFLAGS)|' Makefile
Let me know if I am missing something.

2- Since this is a desktop application, we need a .desktop file, an icon and
the scriptlets, as usual.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #8 from Orcan 'oget' Ogetbil  2010-09-11 20:20:56 EDT ---
ping? are you still interested in packaging this?

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Adam Huffman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?([e-mail] |
                   |m)                          |

--- Comment #9 from Adam Huffman  2010-09-12 07:40:03 EDT ---
I am interested in packaging it.  However, the upstream activity seems rather
erratic - no commits since January and there are bugs that have remained
unfixed for quite a while.

If you think it's worthwhile proceeding with all that in mind, I'll do so.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #10 from Adam Huffman  2010-09-12 13:44:05 EDT ---
Put a new version addressing the compilation problems at:

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer.spec

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer-1.9.3-4...

I tried your suggestion regarding CXXFLAGS and that didn't seem to work as then
the various include paths were not picked up.

The icon is a resized version of the logo file included in the documentation,
for want of something better.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #11 from Orcan 'oget' Ogetbil  2010-09-13 00:52:14 EDT ---
Thanks for the update. I will hopefully find time this week to have a look.

(In reply to comment #10)
> I tried your suggestion regarding CXXFLAGS and that didn't seem to work as then
> the various include paths were not picked up.

My suggestion was a guide for you to start-up. It wasn't meant to be _the_
solution. I assume that you fixed the issue with the patch.
> The icon is a resized version of the logo file included in the documentation,
> for want of something better.

BuildRequires: ImageMagick and do the conversion in %build? Or at least some
reference would be good that says where you got the image from (so that when
someone looks into the specfile, he knows there are no license issues with the
image).

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #12 from Jason Tibbitts  2010-11-17 20:43:20 EST ---
Did everything happen here?  It looks like oget was going to review, but that
was a couple of months ago.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #13 from Orcan 'oget' Ogetbil  2010-11-17 21:47:23 EST ---
Thanks for the reminder Jason. This package slipped out of my mind.

I will look into this by the end of this week.

Adam, sorry for the delay.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #14 from Orcan Ogetbil  2010-11-21 23:15:24 EST ---
Sorry for being late. Here is a more thorough review:

- rpmlint says
   non-sequencer.src:61: W: configure-without-libdir-spec
   non-sequencer.src: W: invalid-url Source0:
non-sequencer-20100131gitba94d2c354145.tar.bz2
   non-sequencer.x86_64: W: no-manual-page-for-binary non-sequencer
These can be ignored. However
   non-sequencer.x86_64: W: no-documentation
needs a fix. You need to put at least the COPYING file in this package, also
possibly the TODO file

! Currently, the -doc subpackage does not require the main package. Is this
intentional? If this is what you want, the COPYING file must exist both in the
main package and the -doc subpackage.

* Currently the source tarball contains the .git* stuff that we don't need.
Those can be taken out. The tarball instructions tarball tell us to check out
the latest git version. What we need is the instructions to generate the exact
tarball. In case upstream updates their repo, current instructions will be
incorrect.

* The %doc package should be noarch

* Please explain in the SPEC file where you got the other sources. Do they have
copyrights? Also please explain in the SPEC file what the patch is for, and/or
its upstream status.

* The directory %{_datadir}/%{name}/ must be owned by the main package. See

http://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Owners...

* You certainly don't need the BuildRequires: cmake git. I am not sure whether
you really need libpng-devel libjpeg-devel. Somehow -lpng and -ljpeg flags are
passed to the linking, but what adds them?

* Each package must consistently use macros. Please don't use plain /usr. Use
%{_prefix} instead.

! Please span %description to 80 columns as much as possible. Currently it is
set to 70.

* The icon is installed in the wrong place. It should be
    %{_datadir}/icons/hicolor/128x128/apps/
Note that you leave the scriptlets as is.

? sed -i "/.html/d" Makefile
What is the above for? Can't that be moved to %prep?

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |StalledSubmitter

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Adam Huffman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|StalledSubmitter            |

--- Comment #15 from Adam Huffman  2010-12-05 07:13:52 EST ---
Sorry for the delay - will take a look in a couple of days.

This was one of my first packages so it's no wonder it needs a lot of work...

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |StalledSubmitter

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #16 from Orcan Ogetbil  2011-06-19 22:40:21 EDT ---
Hi Adam, what is going on with this package?

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #17 from Adam Huffman  2011-06-21 17:42:52 EDT ---
I admit I've neglected this one, as upstream hasn't been active for quite a
while.  However, I still think it's a useful package, so I'm hoping to have
time to work on it at the weekend.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Brendan Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |805236(FedoraAudio)

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #18 from Brendan Jones  2012-03-20 13:49:27 EDT ---
Looks like upstream has pushed out a new release.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Brendan Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(verdurin@fedorapr
                   |                            |oject.org)

--- Comment #19 from Brendan Jones  2012-04-11 13:21:41 EDT ---
Hi Adam,

can I close this so someone else can resubmit? This is being tracked by the
Fedora Audio spin now.

regards,

Brendan

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

Adam Huffman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(verdurin@fedorapr |
                   |oject.org)                  |

--- Comment #20 from Adam Huffman  2012-04-11 14:41:58 EDT ---
Apologies for the delay - I'm in the middle of moving across the country and
starting a new job.  That said, I do intend to complete the review, so I'm
happy to continue unless someone else is desperate to do it.

I should have time to update to the new release at the weekend.

[Bug 571993] Review Request: non-sequencer - A powerful, real-time, pattern-based MIDI sequencer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=571993

--- Comment #21 from Adam Huffman  2012-04-15 18:35:50 EDT ---
There's a new version that includes the recent changes but still needs some
work at:

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer.spec

http://verdurin.fedorapeople.org/reviews/non-sequencer/non-sequencer-1.9.4-1...

I'll contact upstream about the old FSF address errors.