Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
Summary: Review Request: perl-File-chdir - Perl module for local chdir() Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: ianburrell@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://znark.com/fedora/perl-File-chdir.spec SRPM URL: http://znark.com/fedora/perl-File-chdir-0.06-1.src.rpm Description: a more sensible way to change directories
It is required by the perl-SVN-Mirror which is required by perl-SVK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
ianburrell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |196627 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
------- Additional Comments From tibbs@math.uh.edu 2006-06-26 11:23 EST ------- I'm not sure why you have "CHECK(GPL or Artistic)" as the license. "GPL or Artistic" is correct. (Perhaps it's cpanspec doing that?)
You should capitalize the summary.
rpmlint complains about these: W: perl-File-chdir summary-not-capitalized a more sensible way to change directories W: perl-File-chdir invalid-license CHECK(GPL or Artistic)
Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. X license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 41a4661789f6de97fb632e4560d37864 File-chdir-0.06.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). X rpmlint is not silent * final provides and requires are sane: perl(File::chdir) = 0.06 perl(File::chdir::ARRAY) perl(File::chdir::SCALAR) perl-File-chdir = 0.06-1.fc6 = perl >= 0:5.004 perl(:MODULE_COMPAT_5.8.8) perl(Cwd) perl(Exporter) perl(File::Spec) perl(strict) perl(vars) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=3, Tests=48, 0 wallclock secs ( 0.08 cusr + 0.04 csys = 0.12 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
------- Additional Comments From tibbs@math.uh.edu 2006-06-26 11:24 EST ------- By the way, it looks like you need to go through and fix the licenses and perhaps clean up the symmaries of the other spanspec-generated packages you've submitted. I'll be happy to review them all but I'll wait for cleaned-up versions first.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
------- Additional Comments From ianburrell@gmail.com 2006-06-28 02:23 EST ------- I fixed the warnings.
http://znark.com/fedora/perl-File-chdir.spec http://znark.com/fedora/perl-File-chdir-0.06-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-06-28 13:37 EST ------- Still builds fine and rpmlint is now quiet. The issues I had are fixed.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617
ianburrell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From ianburrell@gmail.com 2006-06-29 02:42 EST ------- Added and built for devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/show_bug.cgi?id=196617
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
ianburrell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From ianburrell@gmail.com 2008-06-06 13:59 EST ------- Package Change Request ====================== Package Name: perl-File-chdir New Branches: EL-4 EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
https://bugzilla.redhat.com/show_bug.cgi?id=196617
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-06-06 14:58 EST ------- cvs done.
package-review@lists.fedoraproject.org