[Bug 562997] New: Review Request: rubygem-maruku - Markdown-superset interpreter written in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-maruku - Markdown-superset interpreter written in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Summary: Review Request: rubygem-maruku - Markdown-superset interpreter written in Ruby Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmorsi@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://mo.morsi.org/files/gems/rubygem-maruku.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-maruku-0.6.0-1.fc12.src.rpm Description: Maruku is a Markdown interpreter in Ruby. It features native export to HTML and PDF (via Latex). The output is really beautiful!
rpmlint rpmbuild/RPMS/noarch/rubygem-maruku-0.6.0-1.fc12.noarch.rpm rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/MDDocument/is_math_enabled%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/In/Markdown/any_matching_block_extension%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/new_meta_data%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/String/t2_contains_signature%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/String/t2_empty%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/In/Markdown/SpanLevelParser/HTMLHelper/is_finished%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/MDElement/%3d%3d-i.yaml %3d rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/Strings/force_linebreak%3f-i.yaml %3f rubygem-maruku.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/maruku-0.6.0/ri/MaRuKu/markdown_extra%3f-i.yaml %3f 1 packages and 0 specfiles checked; 0 errors, 9 warnings.
The result of the ri documentation generator. Not much can be done. Other rubygems have been accepted in lieu of this warning, so ignorning
rpmlint rpmbuild/SRPMS/rubygem-maruku-0.6.0-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Package builds fine in mock. Koji build unavailable due to rubygem-syntax dependency.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mohammed Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |562992
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mohammed Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |562998
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Bug 562997 depends on bug 562992, which changed state.
Bug 562992 Summary: Review Request: rubygem-syntax - Ruby library for performing simple syntax highlighting https://bugzilla.redhat.com/show_bug.cgi?id=562992
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |DUPLICATE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-02-12 13:55:41 EST --- Some notes: - License tag should be "GPLv2+". - For other issues - unused / unneeded macros - URL - ruby(abi) dependency - marking %doc - enabling %check (as this contains tests/ directory) Please check my comment on bug 562993 .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
--- Comment #2 from Mohammed Morsi mmorsi@redhat.com 2010-02-17 16:24:05 EST --- (In reply to comment #1)
Some notes:
- License tag should be "GPLv2+".
Done
- For other issues
- unused / unneeded macros
Done
- URL
See my comment reply on bug 562993
- ruby(abi) dependency
- marking %doc
- enabling %check (as this contains tests/ directory)
All done
Please check my comment on bug 562993 .
Updated and uploaded new rubygem-maruku rpm
Spec URL: http://mo.morsi.org/files/gems/rubygem-maruku.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-maruku-0.6.0-2.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-02-18 02:55:21 EST --- Please address - directory ownership issue - rake test failure (at least BR: rubygem(rake) is needed. Also it seems "Gem::manage_gems" in Rakefile seems deprecated)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
--- Comment #4 from Mohammed Morsi mmorsi@redhat.com 2010-02-23 11:52:35 EST --- (In reply to comment #3)
Please address
- directory ownership issue
- rake test failure (at least BR: rubygem(rake) is needed. Also it seems "Gem::manage_gems" in Rakefile seems deprecated)
All three issues are resolved.
Updated and uploaded new rubygem-maruku spec / srpm
Spec URL: http://mo.morsi.org/files/gems/rubygem-maruku.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-maruku-0.6.0-3.fc12.src.rpm
There are a few tests that fail when rake test is run, though the majority pass. The same tests fail when I install the upstream gem via the normal 'gem install' means and run rake test in the default installation dir.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-02-24 14:05:45 EST --- Well, after checking the whole source code, I cannot figure out under what license this gem is distributed under. Perhaps under GPLv2+, however - Overall license text could not be found - especially I cannot figure out under what licenses scripts under bin/ directory are.
Would you ask the upstream?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
--- Comment #6 from Mohammed Morsi mmorsi@redhat.com 2010-02-28 18:44:29 EST --- Maruku is licensed under the GPLv2+
http://github.com/nex3/maruku/blob/master/LICENSE
Thus the current specfile should be good in that respect.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-04 12:36:56 EST --- Okay.
-------------------------------------------------------- This package (rubygem-maruku) is APPROVED by mtasaka --------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mohammed Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Mohammed Morsi mmorsi@redhat.com 2010-03-08 13:24:30 EST --- New Package CVS Request ======================= Package Name: rubygem-maruku Short Description: A Markdown interpreter in Ruby. Owners: mmorsi Branches: F-12, F-13 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2010-03-09 01:12:49 EST --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562997
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #10 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-17 03:41:28 EDT --- Closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla