[Bug 2239563] New: Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

Bug ID: 2239563
           Summary: Review Request: kf6-syntax-highlighting
           Product: Fedora
           Version: rawhide
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://1707.io/jz/kf6-syntax-highlighting.spec
SRPM URL:
https://1707.io/jz/kf6-syntax-highlighting-5.240.0%5E20230917.220810.80b3126...

Reproducible: Always

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

Alessandro Astone  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Alessandro Astone  ---
`%autosetup -n %{framework}-%{shortcommit0} -p1` should be changed to
`%autosetup -n %{framework}-%{commit0} -p1` and the tarball properly downloaded
from the URL in Source0 (you can use `spectool -g *.spec`)

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

--- Comment #2 from Justin Zobel  ---
Yeah I was previously creating the tarballs locally but as these will need to
go into Fedora builds they will need to be retrievable so I've updated this
spec.

Spec URL: https://1707.io/jz/kf6-syntax-highlighting.spec
SRPM URL:
https://1707.io/jz/kf6-syntax-highlighting-5.240.0%5E20230917.220810.80b3126...

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

Troy Dawson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

--- Comment #3 from Troy Dawson  ---
%description is in the wrong place.
Because you have it before the BuildRequires and Requires, rpmbuild is thinking
all those BuildRequires are part of the descriptions and does not pull them in.

Even then, it is still failing builds with missing files. 
File not found:
/builddir/build/BUILDROOT/kf6-syntax-highlighting-5.240.0^20230917.220810.80b312632182971f3480e147aa2c9d0ad9d73035-123.fc40.x86_64/usr/lib64/libKF6SyntaxHighlighting.so.5.240

It looks like the file ends up at
/usr/lib64/libKF6SyntaxHighlighting.so.5.240.0

Here is a diff with both of those fixes in them.  With these, it builds on
Fedora Rawhide mock.

--- kf6-syntax-highlighting.spec        2023-09-25 08:32:24.164759164 -0700
+++ kf6-syntax-highlighting.spec.original       2023-09-25 08:31:53.540409091
-0700
@@ -12,6 +12,9 @@
 URL:            https://invent.kde.org/frameworks/%%7Bframework%7D
 Source0:       
https://invent.kde.org/frameworks/%%7Bframework%7D/-/archive/%%7Bcommit0%7D/...

+%description
+%{summary}.
+
 # KDE Frameworks
 BuildRequires:  extra-cmake-modules

@@ -26,9 +29,6 @@
 BuildRequires:  cmake(Qt6Core)
 BuildRequires:  cmake(Qt6Qml)

-%description
-%{summary}.
-
 %package        devel
 Summary:        Development files for %{name}
 Requires:       %{name}%{?_isa} = %{version}-%{release}
@@ -56,7 +56,7 @@
 %license LICENSES/*.txt
 %{_kf6_bindir}/ksyntaxhighlighter6
 %{_kf6_datadir}/qlogging-categories6/*categories
-%{_kf6_libdir}/libKF6SyntaxHighlighting.so.5.240.0
+%{_kf6_libdir}/libKF6SyntaxHighlighting.so.5.240
 %{_kf6_libdir}/libKF6SyntaxHighlighting.so.6
 %{_kf6_qmldir}/org/kde/syntaxhighlighting

Note:  This isn't a review, this is just helping to get the package build-able.

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

Troy Dawson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

--- Comment #4 from Justin Zobel  ---
Spec URL: https://1707.io/jz/kf6-syntax-highlighting.spec
SRPM URL:
https://1707.io/jz/kf6-syntax-highlighting-5.240.0%5E20230922.195427.0211d71...

Updated.

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

--- Comment #5 from Troy Dawson  ---
Thank you.  It now builds and I am able to do the review.

License - Although the majority of code under src is MIT, there is alot of
external stuff in data and autotests that have different licenses.
I believe this covers them all.  And yes, the MIT is in SPDX format

License:        MIT AND BSD-2-Clause AND BSD-3-Clause AND CC0-1.0 AND
GPL-2.0-only AND LGPL-2.0-or-later

That is the only issue I found, and I believe it can be fixed on checking.

REVIEW APPROVED
Note: Fix License line as noted above before building.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/quake/review/2239563-kf6-syntax-highlighting/diff.txt
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Creative Commons CC0 1.0", "MIT
     License", "*No copyright* Creative Commons CC0 1.0", "GNU General
     Public License, Version 2", "GNU Library General Public License,
     Version 2.0", "GNU Lesser General Public License, Version 2.1", "*No
     copyright* MIT License", "BSD 2-Clause License", "*No copyright* BSD
     3-Clause License", "*No copyright* GNU General Public License, Version
     2", "*No copyright* GNU General Public License v2.0 or later", "*No
     copyright* GNU Lesser General Public License", "*No copyright* Public
     domain", "Apache License 2.0", "GNU Lesser General Public License",
     "*No copyright* Apache License", "GNU Lesser General Public License
     v2.1 or later", "GNU Library General Public License v2 or later",
     "Standard ML of New Jersey License", "*No copyright* GNU Lesser
     General Public License, Version 2.1", "*No copyright* Artistic
     License", "BSD 3-Clause License", "*No copyright* GNU Library General
     Public License v2 or later", "*No copyright* GNU General Public
     License", "GNU General Public License v2.0 or later", "GNU General
     Public License". 1680 files have unknown license. Detailed output of
     licensecheck in /home/quake/review/2239563-kf6-syntax-
     highlighting/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /home/quake/review/2239563-kf6-syntax-
     highlighting/srpm-unpacked/kf6-syntax-highlighting.spec
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.

[Bug 2239563] Review Request: kf6-syntax-highlighting

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

Troy Dawson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|ASSIGNED                    |POST

[Bug 2239563] Review Request: kf6-syntax-highlighting - KDE Frameworks 6 Syntax highlighting engine for Kate syntax definitions

https://bugzilla.redhat.com/show_bug.cgi?id=2239563

--- Comment #6 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/kf6-syntax-highlighting