[Bug 1431867] New: Review Request: golang-github-zillode-notify - File system event notification library on steroids
4:58 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Bug ID: 1431867
Summary: Review Request: golang-github-zillode-notify - File
system event notification library on steroids
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: decathorpe(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-zillode-notify...
SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-zillode-notify...
Description: File system event notification library on steroids
Fedora Account System Username: decathorpe
koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18365687
This package is one of the dependencies of syncthing-inotify. Tests now pass on
all arches (thanks to upstream for fixing a problem with aarch64 very
quickly!).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:04 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1431868
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1431868
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:14 a.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Athos Ribeiro <athoscribeiro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |athoscribeiro(a)gmail.com
Assignee|nobody(a)fedoraproject.org |athoscribeiro(a)gmail.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:22 a.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Athos Ribeiro <athoscribeiro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Athos Ribeiro <athoscribeiro(a)gmail.com> ---
Package looks good. Approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: golang-github-zillode-notify-devel-0-0.1.gitc2582a9.fc27.noarch.rpm
golang-github-zillode-notify-unit-test-devel-0-0.1.gitc2582a9.fc27.x86_64.rpm
golang-github-zillode-notify-0-0.1.gitc2582a9.fc27.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires
--------
golang-github-zillode-notify-unit-test-devel (rpmlib, GLIBC filtered):
golang-github-zillode-notify-devel
golang-github-zillode-notify-devel (rpmlib, GLIBC filtered):
golang(golang.org/x/sys/unix)
Provides
--------
golang-github-zillode-notify-unit-test-devel:
golang-github-zillode-notify-unit-test-devel
golang-github-zillode-notify-unit-test-devel(x86-64)
golang-github-zillode-notify-devel:
golang(github.com/zillode/notify)
golang-github-zillode-notify-devel
Source checksums
----------------
https://github.com/zillode/notify/archive/c2582a9d7e06fd326cdacc3a39f2263...
:
CHECKSUM(SHA256) this package :
b11fd89925a7b9c5e27367da36ee89a95e48121b4f84e99c4da764022a19afce
CHECKSUM(SHA256) upstream package :
b11fd89925a7b9c5e27367da36ee89a95e48121b4f84e99c4da764022a19afce
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:10 a.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #2 from Fabio Valentini <decathorpe(a)gmail.com> ---
Thanks for the review, I've just sent the pkgdb request.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:51 a.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #3 from Jon Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-zillode-...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:49 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc26 has been submitted as an
update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3fdff88105
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:49 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-31df863b76
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:49 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:13 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9dc5bf5ff
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:24 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3fdff88105
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:13 a.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2017-03-15 12:13:43
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:56 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |ON_QA
Resolution|RAWHIDE |---
Keywords| |Reopened
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9dc5bf5ff
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:58 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-31df863b76
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:23 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed|2017-03-15 12:13:43 |2017-03-26 17:23:10
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:19 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:06 p.m.
New subject: [Bug 1431867] Review Request:
golang-github-zillode-notify - File system event notification library on
steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867
--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2626
days inactive
2645
days old
package-review@lists.fedoraproject.org
16 comments
1 participants
participants (1)
-
bugzilla＠redhat.com