https://bugzilla.redhat.com/show_bug.cgi?id=2183661
Bug ID: 2183661 Summary: Review Request: rust-clap_builder - Simple to use, efficient, and full-featured Command Line Argument Parser Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-clap_builder.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-clap_builder-4.2.1-1.fc38.src.rpm
Description: A simple to use, efficient, and full-featured Command Line Argument Parser.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2183661
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/cl | |ap_builder
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5734012 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2183661
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |alebastr89@gmail.com Status|NEW |POST CC| |alebastr89@gmail.com
--- Comment #3 from Aleksei Bavshin alebastr89@gmail.com ---
# * missing dev-dependencies: snapbox, trycmd
Same as with clap_mangen, the tests that actually require snapbox, trybuild, trycmd are not included into the crate. But this time there are library and doc tests which require unpackaged `unic-emoji-char` and `color-print` respectively. Please, update the comment with actual missing test deps before importing the package.
Looks good otherwise. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2183661
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review! And good catch. I will update the comment before import.
https://bugzilla.redhat.com/show_bug.cgi?id=2183661
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap_builder
https://bugzilla.redhat.com/show_bug.cgi?id=2183661
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-bf649844fc has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bf649844fc
https://bugzilla.redhat.com/show_bug.cgi?id=2183661 Bug 2183661 depends on bug 2182231, which changed state.
Bug 2182231 Summary: rust-clap_lex-0.4.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=2182231
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2183661 Bug 2183661 depends on bug 2183200, which changed state.
Bug 2183200 Summary: Review Request: rust-anstyle - ANSI text styling https://bugzilla.redhat.com/show_bug.cgi?id=2183200
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2183661 Bug 2183661 depends on bug 2183204, which changed state.
Bug 2183204 Summary: Review Request: rust-anstream - Simple cross platform library for writing colored text to a terminal https://bugzilla.redhat.com/show_bug.cgi?id=2183204
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2183661
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-04-08 22:24:36
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-bf649844fc has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org