[Bug 239162] New: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

Summary: Review Request: perl-Net-Packet - A framework to easily
                    send and receive frames from layer 2 to la  yer 7
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-Packet.spec
SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-Packet-3.25-1.fc7.src...

Description:
perl-Net-Packet is a unified framework to craft, send and receive packets at
layers 2, 3, 4 and 7.

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |239158, 239161, 239163

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |239164
              nThis|                            |

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |perl-Net-Packet

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

Bug 239162 depends on bug 239161, which changed state.

Bug 239161 Summary: Review Request: perl-Net-Libdnet - Perl Interface to libdnet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239161

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

Bug 239162 depends on bug 239161, which changed state.

Bug 239161 Summary: Review Request: perl-Net-Libdnet - Perl Interface to libdnet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239161

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|NEXTRELEASE                 |
             Status|CLOSED                      |ASSIGNED

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

Bug 239162 depends on bug 239161, which changed state.

Bug 239161 Summary: Review Request: perl-Net-Libdnet - Perl Interface to libdnet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239161

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

Bug 239162 depends on bug 239163, which changed state.

Bug 239163 Summary: Review Request: perl-Net-IPv6Addr - Perl module to check validity of IPv6 addresses
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239163

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

------- Additional Comments From [e-mail]  2007-06-04 01:12 EST -------
You need to add build dependencies on perl(ExtUtils::MakeMaker), perl(Test),
perl(Test::Pod::Coverage) and perl(Test::Pod).  This will give you additional
test coverage and will keep things building once the perl/perl-devel split is
complete.

* source files match upstream:
   a673b790fea0bb50d55063b6ca90233b7527f9263a7fa51bd4c43d16b32373c3  
   Net-Packet-3.25.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Net::Packet) = 3.25
   perl(Net::Packet::ARP)
   perl(Net::Packet::CDP)
   perl(Net::Packet::CDP::Address)
   perl(Net::Packet::CDP::Type)
   perl(Net::Packet::CDP::TypeAddresses)
   perl(Net::Packet::CDP::TypeCapabilities)
   perl(Net::Packet::CDP::TypeDeviceId)
   perl(Net::Packet::CDP::TypePortId)
   perl(Net::Packet::CDP::TypeSoftwareVersion)
   perl(Net::Packet::Consts)
   perl(Net::Packet::Desc)
   perl(Net::Packet::DescL2)
   perl(Net::Packet::DescL3)
   perl(Net::Packet::DescL4)
   perl(Net::Packet::Dump)
   perl(Net::Packet::ETH)
   perl(Net::Packet::Env)
   perl(Net::Packet::Frame)
   perl(Net::Packet::ICMPv4)
   perl(Net::Packet::IGMPv4)
   perl(Net::Packet::IPv4)
   perl(Net::Packet::IPv6)
   perl(Net::Packet::LLC)
   perl(Net::Packet::Layer)
   perl(Net::Packet::Layer2)
   perl(Net::Packet::Layer3)
   perl(Net::Packet::Layer4)
   perl(Net::Packet::Layer7)
   perl(Net::Packet::NULL)
   perl(Net::Packet::OSPF)
   perl(Net::Packet::PPP)
   perl(Net::Packet::PPPLCP)
   perl(Net::Packet::PPPoE)
   perl(Net::Packet::RAW)
   perl(Net::Packet::SLL)
   perl(Net::Packet::STP)
   perl(Net::Packet::TCP)
   perl(Net::Packet::UDP)
   perl(Net::Packet::Utils)
   perl(Net::Packet::VLAN)
   perl-Net-Packet = 3.25-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Bit::Vector)
   perl(Carp)
   perl(Class::Gomor::Array)
   perl(Data::Dumper)
   perl(Exporter)
   perl(Net::IPv4Addr)
   perl(Net::IPv6Addr)
   perl(Net::Libdnet)
   perl(Net::Packet::ARP)
   perl(Net::Packet::CDP)
   perl(Net::Packet::CDP::Address)
   perl(Net::Packet::CDP::Type)
   perl(Net::Packet::CDP::TypeAddresses)
   perl(Net::Packet::CDP::TypeCapabilities)
   perl(Net::Packet::CDP::TypeDeviceId)
   perl(Net::Packet::CDP::TypePortId)
   perl(Net::Packet::CDP::TypeSoftwareVersion)
   perl(Net::Packet::Consts)
   perl(Net::Packet::Desc)
   perl(Net::Packet::DescL2)
   perl(Net::Packet::DescL3)
   perl(Net::Packet::DescL4)
   perl(Net::Packet::Dump)
   perl(Net::Packet::ETH)
   perl(Net::Packet::Env)
   perl(Net::Packet::Frame)
   perl(Net::Packet::ICMPv4)
   perl(Net::Packet::IGMPv4)
   perl(Net::Packet::IPv4)
   perl(Net::Packet::IPv6)
   perl(Net::Packet::LLC)
   perl(Net::Packet::Layer)
   perl(Net::Packet::Layer2)
   perl(Net::Packet::Layer3)
   perl(Net::Packet::Layer4)
   perl(Net::Packet::Layer7)
   perl(Net::Packet::NULL)
   perl(Net::Packet::OSPF)
   perl(Net::Packet::PPP)
   perl(Net::Packet::PPPLCP)
   perl(Net::Packet::PPPoE)
   perl(Net::Packet::RAW)
   perl(Net::Packet::SLL)
   perl(Net::Packet::STP)
   perl(Net::Packet::TCP)
   perl(Net::Packet::UDP)
   perl(Net::Packet::Utils)
   perl(Net::Packet::VLAN)
   perl(Net::Pcap)
   perl(Net::Write::Layer2)
   perl(Net::Write::Layer4)
   perl(Socket)
   perl(Socket6)
   perl(Storable)
   perl(Time::HiRes)
   perl(constant)
   perl(strict)
   perl(warnings)
X %check is present.  Many tests are necessarily skipped because they need the 
  network.  Some tests are skipped due to missing dependencies.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

------- Additional Comments From [e-mail]  2007-06-04 03:21 EST -------
Updated:

- Add missing BRs

Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-Packet.spec
SRPM URL:
http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Net-Packet-3.25-2.fc7.src...

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-06-10 00:55 EST -------
Somehow I missed your comment.  Sorry about that; too many reviews in flight, I
guess.

Looks like a typo in the release number of your last changelog entry (3.25-1 ->
2.35-2), which annoys rpmlint.

The remaining runnable tests run fine; the others need access and cannot be
usefully run in mock:
   All tests successful, 27 subtests skipped.
   Files=31, Tests=104,  5 wallclock secs ( 3.84 cusr +  0.99 csys =  4.83 CPU)

Just fix up that changelog entry when you check in.

APPROVED

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

------- Additional Comments From [e-mail]  2007-06-10 05:46 EST -------
New Package CVS Request
=======================
Package Name: perl-Net-Packet
Short Description: A framework to easily send and receive frames from layer 2 to
layer 7
Owners: [e-mail] 
Branches: F-7 FC-6 EL-4 EL-5

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-06-10 23:30 EST -------
cvs done.

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

Bug 239162 depends on bug 239158, which changed state.

Bug 239158 Summary: Review Request: perl-Net-Write - A portable interface to open and send raw data to network
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239158

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

------- Additional Comments From [e-mail]  2007-06-26 18:24 EST -------
Any reason this hasn't been imported yet?

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?([e-mail])

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?([e-mail])|

------- Additional Comments From [e-mail]  2007-07-15 08:04 EST -------
No reason besides me forgetting about it, imported now, waiting for some BRs to
get into updates before building for F-7.

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/show_bug.cgi?id=239162

------- Additional Comments From [e-mail]  2007-08-25 13:10 EST -------
Are those dependencies in the repo now?  Any chance this ticket can ever be closed?

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 239162] Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la  yer 7
Alias: perl-Net-Packet

https://bugzilla.redhat.com/show_bug.cgi?id=239162

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide