[Bug 2168095] New: Review Request: php-sebastian-object-enumerator5 - Traverses array and object to enumerate all referenced objects, version 5
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Bug ID: 2168095 Summary: Review Request: php-sebastian-object-enumerator5 - Traverses array and object to enumerate all referenced objects, version 5 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-object-enumer... SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-object-enumerator5-5.0.0-1.rem... Description: Traverses array structures and object graphs to enumerate all referenced objects.
Fedora Account System Username: remi
--
for phpunit10
previous reviews: bug #1320532 for php-sebastian-object-enumerator bug #1428914 for php-sebastian-object-enumerator3 bug #1800789 for php-sebastian-object-enumerator4
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2167789, 2167788 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2167788 [Bug 2167788] Review Request: php-sebastian-recursion-context5 - Recursively process PHP variables, version 5 https://bugzilla.redhat.com/show_bug.cgi?id=2167789 [Bug 2167789] Review Request: php-sebastian-object-reflector3 - Allows reflection of object attributes, version 3
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2168112
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2168112 [Bug 2168112] Review Request: phpunit10 - The PHP Unit Testing framework version 10
https://bugzilla.redhat.com/show_bug.cgi?id=2168095 Bug 2168095 depends on bug 2167788, which changed state.
Bug 2167788 Summary: Review Request: php-sebastian-recursion-context5 - Recursively process PHP variables, version 5 https://bugzilla.redhat.com/show_bug.cgi?id=2167788
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168095 Bug 2168095 depends on bug 2167789, which changed state.
Bug 2167789 Summary: Review Request: php-sebastian-object-reflector3 - Allows reflection of object attributes, version 3 https://bugzilla.redhat.com/show_bug.cgi?id=2167789
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org CC| |benson_muite@emailplus.org Flags| |fedora-review?
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License". 14 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/php- sebastian-object-enumerator5/2168095-php-sebastian-object- enumerator5/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
PHP: [x]: Run phpci static analyze on all php files. Note: 6.5.5@7852058 static analyze results in /home/FedoraPackaging/reviews/php-sebastian-object- enumerator5/2168095-php-sebastian-object-enumerator5/phpci.log
Rpmlint ------- Checking: php-sebastian-object-enumerator5-5.0.0-1.fc39.noarch.rpm php-sebastian-object-enumerator5-5.0.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7tmcfmma')] checks: 31, packages: 2
php-sebastian-object-enumerator5.spec: W: invalid-url Source0: php-sebastian-object-enumerator5-5.0.0-202d0e3.tgz 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 2.2 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s
Requires -------- php-sebastian-object-enumerator5 (rpmlib, GLIBC filtered): (php-composer(sebastian/object-reflector) >= 3.0 with php-composer(sebastian/object-reflector) < 4) (php-composer(sebastian/recursion-context) >= 5.0 with php-composer(sebastian/recursion-context) < 6) php(language) php-composer(fedora/autoloader) php-spl
Provides -------- php-sebastian-object-enumerator5: php-composer(sebastian/object-enumerator) php-sebastian-object-enumerator5
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2168095 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, PHP Disabled plugins: Haskell, Ruby, Java, R, SugarActivity, Perl, C/C++, Python, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments: a) gh_date should be 20230203 not 20150728 b) Do not get requirement for php-spl from phpcompatinfo on src directory, only needed in tests directory. Maybe it should be conditionally required if running tests?
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
--- Comment #3 from Remi Collet fedora@famillecollet.com ---
a) gh_date should be 20230203 not 20150728
This is a commented out ;) (only used when need to build a snapshot, not a release)
b) Do not get requirement for php-spl from phpcompatinfo on src directory, only needed in tests
Fixed
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-object-enumer... SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-object-enumerator5-5.0.0-2.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- Thanks. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/php-sebastian-object-enumerator5
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Thanks for the review
SCM requests https://pagure.io/releng/fedora-scm-requests/issue/54107 https://pagure.io/releng/fedora-scm-requests/issue/54108
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5a67f62ab9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a67f62ab9
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5a67f62ab9 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5a67f62ab9 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a67f62ab9
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2168095
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2023-07-11 01:26:32
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5a67f62ab9 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com