Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=435220
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bob@fedoraunity.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/linpsk.spec SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/linpsk-0.9-3.fc8.src.rpm Description: LinPsk is a program for operating on digital modes running on Linux. LinPsk supports BPSK, QPSK and RTTY at the moment.
This srpm mock builds on Fedora 7, Fedora 8 and devel on i386 and x86_64. All resulting rpms are rpmlint clean.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kanarip@kanarip.com Status|NEW |NEEDINFO Flag| |fedora-review+, | |needinfo?(bob@fedoraunity.or | |g)
------- Additional Comments From kanarip@kanarip.com 2008-02-28 18:23 EST ------- RPM Lint: OK Package name: OK Spec file: OK License: OK (GPLv2 or later) Actual License: OK (GPLv2 in COPYING, GPLv2+ in source) %doc License: OK Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: OK Compile and Build: - F-7: OK - F-8: OK - rawhide: OK - EL-5: OK
Applicable Package Guidelines: - -debuginfo package: OK (~2.5M)
Locales: N/A Shared libs: N/A Relocatable: N/A Directory and file ownership: OK No duplicate files in %files: OK File Permissions: OK Macro usage: OK Code vs. Content: OK (Large) Documentation: OK %doc affecting runtime: OK Header files in -devel package: N/A Static Libraries in -static package: N/A pkgconfig Requires: N/A Library files: N/A Devel requires base package: N/A .la libtool archives: N/A Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK
A small suggestion for the %files section; you might want to use more wildcards (*) instead of %{name}, but it's really up to you as a maintainer.
Otherwise, once more, your packages are a breeze to review.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
bob@fedoraunity.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo?(bob@fedoraunity.or|fedora-cvs? |g) |
------- Additional Comments From bob@fedoraunity.org 2008-02-28 20:29 EST ------- New Package CVS Request ======================= Package Name: linpsk Short Description: Psk31 and RTTY program for Linux Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindrepb Cvsextras Commits: Yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-02-28 22:17 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
------- Additional Comments From updates@fedoraproject.org 2008-02-28 23:30 EST ------- linpsk-0.9-3.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
bob@fedoraunity.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From bob@fedoraunity.org 2008-02-28 23:34 EST ------- Thank you kanarip for yet another review. Thank you nirik for cvs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
------- Additional Comments From updates@fedoraproject.org 2008-02-28 23:41 EST ------- linpsk-0.9-3.fc7 has been submitted as an update for Fedora 7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
------- Additional Comments From updates@fedoraproject.org 2008-03-01 04:25 EST ------- linpsk-0.9-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: linpsk - Psk31 and RTTY program for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=435220
------- Additional Comments From updates@fedoraproject.org 2008-03-01 04:27 EST ------- linpsk-0.9-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org