Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: sympy - A Python library for symbolic mathematics
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Summary: Review Request: sympy - A Python library for symbolic mathematics Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: konrad@tylerc.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/sympy.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/sympy-0.6.2-1.fc9.src.rpm Description: SymPy aims to become a full-featured computer algebra system (CAS) while keeping the code as simple as possible in order to be comprehensible and easily extensible. SymPy is written entirely in Python and does not require any external libraries.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
--- Comment #1 from Conrad Meyer konrad@tylerc.org 2008-10-12 15:04:10 EDT --- Builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=875246
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@jcomserv.net AssignedTo|nobody@fedoraproject.org |limb@jcomserv.net Flag| |fedora-review?
--- Comment #2 from Jon Ciesla limb@jcomserv.net 2008-10-13 11:24:23 EDT --- Starting full review. . . .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
--- Comment #3 from Jon Ciesla limb@jcomserv.net 2008-10-13 12:11:11 EDT --- rpmlint on SRPM is clean
rpmlint on RPMs:
sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/utilities/compilef.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/solvers/numeric.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/mpmath/elliptic.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/mpmath/tests/test_elliptic.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
Since these aren't meant to be executable, it would be good to patch out the shebangs and send the patch upstream.
Otherwise, full review looks great.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
--- Comment #4 from Conrad Meyer konrad@tylerc.org 2008-10-13 16:13:31 EDT --- Patch submitted upstream: http://code.google.com/p/sympy/issues/detail?id=1156
New spec and SRPM URLs: http://konradm.fedorapeople.org/fedora/SPECS/sympy.spec http://konradm.fedorapeople.org/fedora/SRPMS/sympy-0.6.2-2.fc9.src.rpm
rpmlint on the spec, src.rpm, and generated rpm [0] is clean.
[0]: http://konradm.fedorapeople.org/fedora/RPMS/noarch/sympy-0.6.2-2.fc9.noarch....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2008-10-14 09:36:22 EDT --- Alright, there we go. Looks good.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
--- Comment #6 from Conrad Meyer konrad@tylerc.org 2008-10-14 11:28:37 EDT --- New Package CVS Request ======================= Package Name: sympy Short Description: A Python library for symbolic mathematics Owners: konradm Branches: F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Conrad Meyer konrad@tylerc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
--- Comment #7 from Huzaifa S. Sidhpurwala huzaifas@redhat.com 2008-10-15 01:33:14 EDT --- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Huzaifa S. Sidhpurwala huzaifas@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Conrad Meyer konrad@tylerc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #8 from Conrad Meyer konrad@tylerc.org 2008-10-15 19:28:31 EDT --- Built in rawhide. Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #9 from Jussi Lehtola jussi.lehtola@iki.fi 2008-11-06 06:46:04 EDT --- Please add also branch for EPEL (at least 5), and build documentation into a -doc package.
HTML documentation builds fine, LaTeX doesn't seem to work.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Conrad Meyer konrad@tylerc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #10 from Conrad Meyer konrad@tylerc.org 2008-11-06 11:57:13 EDT --- Package Change Request ====================== Package Name: sympy New Branches: EL-5 Owners: konradm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Conrad Meyer konrad@tylerc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
--- Comment #11 from Conrad Meyer konrad@tylerc.org 2008-11-06 19:18:35 EDT --- Wait, no, I don't want to maintain this for EPEL. You can take it if you like.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #12 from Jussi Lehtola jussi.lehtola@iki.fi 2008-11-07 01:45:53 EDT --- Fine.
Package Change Request ====================== Package Name: sympy New Branches: EL-5 Owners: jussilehtola
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466660
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #13 from Kevin Fenzi kevin@tummy.com 2008-11-07 16:38:46 EDT --- cvs done.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla