[Bug 2176171] New: Review Request: R-httr2 - Perform HTTP Requests and Process the Responses
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
Bug ID: 2176171 Summary: Review Request: R-httr2 - Perform HTTP Requests and Process the Responses Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: spotrh@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://spot.fedorapeople.org/R-httr2.spec SRPM URL: https://spot.fedorapeople.org/R-httr2-0.2.2-1.fc37.src.rpm Description: Tools for creating and modifying HTTP requests, then performing them and processing the results. 'httr2' is a modern re-imagining of 'httr' that uses a pipe-based interface and solves more of the problems that API wrapping packages face. Fedora Account System Username: spot
Normally, I provide a Koji rawhide scratch build with my review requests, but in this case, a proper build of httr2 (with %check) depends on R-docopt, which is under review in bz2176170
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
Tom "spot" Callaway spotrh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2176170
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2176170 [Bug 2176170] Review Request: R-docopt - Command-Line Interface Specification Language
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://CRAN.R-project.org/ | |package=%{packname}
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5603124 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.ucar86@gmail.com
--- Comment #2 from Iñaki Ucar i.ucar86@gmail.com --- I would just remove the particular test file that uses docopt instead of packaging it... Packages should work fine without Suggests, including tests (except of course for the test suite), so this kind of thing is a bug really.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |i.ucar86@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
--- Comment #3 from Iñaki Ucar i.ucar86@gmail.com --- A test and a vignette seem to require Internet access, and the checks fail. Again, I would remove that test and check without rebuilding vignettes.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171 Bug 2176171 depends on bug 2176170, which changed state.
Bug 2176170 Summary: Review Request: R-docopt - Command-Line Interface Specification Language https://bugzilla.redhat.com/show_bug.cgi?id=2176170
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
--- Comment #4 from Tom "spot" Callaway spotrh@gmail.com --- New SRPM: https://spot.fedorapeople.org/R-httr2-0.2.2-2.fc39.src.rpm New SPEC: https://spot.fedorapeople.org/R-httr2.spec
- skip tests from testthat that require network - disable vignettes and examples
I also submitted a PR upstream to apply the "skip tests" change.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5730356 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2176171
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Iñaki Ucar i.ucar86@gmail.com --- Thanks, all ok (copying the review below for reference). Package approved. Just please use the URL field as specified in the package guidelines upon package import:
URL: https://CRAN.R-project.org/package=%%7Bpackname%7D Source: %{url}&version=%{packver}#/%{packname}_%{packver}.tar.gz
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION - Package requires R-core.
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* MIT License", "Unknown or generated". 170 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/R-httr2/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section.
===== SHOULD items =====
Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 0.2.2, packaged version is 0.2.2
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: R-httr2-0.2.2-2.fc39.noarch.rpm R-httr2-0.2.2-2.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6acs9c_s')] checks: 31, packages: 2
R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/pipe.html /usr/share/R/library/httr2/help/+25+3E+25.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/curl_translate.html /usr/share/R/library/httr2/help/curl_help.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/httr2.html /usr/share/R/library/httr2/help/httr2-package.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/jwt_encode_sig.html /usr/share/R/library/httr2/help/jwt_claim.html:/usr/share/R/library/httr2/help/jwt_encode_hmac.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/last_response.html /usr/share/R/library/httr2/help/last_request.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/with_mock.html /usr/share/R/library/httr2/help/local_mock.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/oauth_client_req_auth_jwt_sig.html /usr/share/R/library/httr2/help/oauth_client_req_auth.html:/usr/share/R/library/httr2/help/oauth_client_req_auth_body.html:/usr/share/R/library/httr2/help/oauth_client_req_auth_header.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/oauth_flow_auth_code_url.html /usr/share/R/library/httr2/help/oauth_flow_auth_code.html:/usr/share/R/library/httr2/help/oauth_flow_auth_code_listen.html:/usr/share/R/library/httr2/help/oauth_flow_auth_code_parse.html:/usr/share/R/library/httr2/help/oauth_flow_auth_code_pkce.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/obfuscated.html /usr/share/R/library/httr2/help/obfuscate.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/req_body_raw.html /usr/share/R/library/httr2/help/req_body.html:/usr/share/R/library/httr2/help/req_body_file.html:/usr/share/R/library/httr2/help/req_body_form.html:/usr/share/R/library/httr2/help/req_body_json.html:/usr/share/R/library/httr2/help/req_body_multipart.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/req_url_query.html /usr/share/R/library/httr2/help/req_url.html:/usr/share/R/library/httr2/help/req_url_path.html:/usr/share/R/library/httr2/help/req_url_path_append.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_body_xml.html /usr/share/R/library/httr2/help/resp_body_html.html:/usr/share/R/library/httr2/help/resp_body_json.html:/usr/share/R/library/httr2/help/resp_body_raw.html:/usr/share/R/library/httr2/help/resp_body_string.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_status_desc.html /usr/share/R/library/httr2/help/resp_check_status.html:/usr/share/R/library/httr2/help/resp_is_error.html:/usr/share/R/library/httr2/help/resp_status.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_encoding.html /usr/share/R/library/httr2/help/resp_content_type.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_headers.html /usr/share/R/library/httr2/help/resp_header.html:/usr/share/R/library/httr2/help/resp_header_exists.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/secrets.html /usr/share/R/library/httr2/help/secret_decrypt.html:/usr/share/R/library/httr2/help/secret_encrypt.html:/usr/share/R/library/httr2/help/secret_has_key.html:/usr/share/R/library/httr2/help/secret_make_key.html:/usr/share/R/library/httr2/help/secret_read_rds.html:/usr/share/R/library/httr2/help/secret_write_rds.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/url_parse.html /usr/share/R/library/httr2/help/url_build.html 2 packages and 0 specfiles checked; 0 errors, 17 warnings, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/pipe.html /usr/share/R/library/httr2/help/+25+3E+25.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/curl_translate.html /usr/share/R/library/httr2/help/curl_help.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/httr2.html /usr/share/R/library/httr2/help/httr2-package.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/jwt_encode_sig.html /usr/share/R/library/httr2/help/jwt_claim.html:/usr/share/R/library/httr2/help/jwt_encode_hmac.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/last_response.html /usr/share/R/library/httr2/help/last_request.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/with_mock.html /usr/share/R/library/httr2/help/local_mock.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/oauth_client_req_auth_jwt_sig.html /usr/share/R/library/httr2/help/oauth_client_req_auth.html:/usr/share/R/library/httr2/help/oauth_client_req_auth_body.html:/usr/share/R/library/httr2/help/oauth_client_req_auth_header.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/oauth_flow_auth_code_url.html /usr/share/R/library/httr2/help/oauth_flow_auth_code.html:/usr/share/R/library/httr2/help/oauth_flow_auth_code_listen.html:/usr/share/R/library/httr2/help/oauth_flow_auth_code_parse.html:/usr/share/R/library/httr2/help/oauth_flow_auth_code_pkce.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/obfuscated.html /usr/share/R/library/httr2/help/obfuscate.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/req_body_raw.html /usr/share/R/library/httr2/help/req_body.html:/usr/share/R/library/httr2/help/req_body_file.html:/usr/share/R/library/httr2/help/req_body_form.html:/usr/share/R/library/httr2/help/req_body_json.html:/usr/share/R/library/httr2/help/req_body_multipart.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/req_url_query.html /usr/share/R/library/httr2/help/req_url.html:/usr/share/R/library/httr2/help/req_url_path.html:/usr/share/R/library/httr2/help/req_url_path_append.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_body_xml.html /usr/share/R/library/httr2/help/resp_body_html.html:/usr/share/R/library/httr2/help/resp_body_json.html:/usr/share/R/library/httr2/help/resp_body_raw.html:/usr/share/R/library/httr2/help/resp_body_string.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_status_desc.html /usr/share/R/library/httr2/help/resp_check_status.html:/usr/share/R/library/httr2/help/resp_is_error.html:/usr/share/R/library/httr2/help/resp_status.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_encoding.html /usr/share/R/library/httr2/help/resp_content_type.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/resp_headers.html /usr/share/R/library/httr2/help/resp_header.html:/usr/share/R/library/httr2/help/resp_header_exists.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/secrets.html /usr/share/R/library/httr2/help/secret_decrypt.html:/usr/share/R/library/httr2/help/secret_encrypt.html:/usr/share/R/library/httr2/help/secret_has_key.html:/usr/share/R/library/httr2/help/secret_make_key.html:/usr/share/R/library/httr2/help/secret_read_rds.html:/usr/share/R/library/httr2/help/secret_write_rds.html R-httr2.noarch: W: files-duplicate /usr/share/R/library/httr2/help/url_parse.html /usr/share/R/library/httr2/help/url_build.html 1 packages and 0 specfiles checked; 0 errors, 17 warnings, 0 badness; has taken 0.1 s
Source checksums ---------------- https://cran.r-project.org/src/contrib/httr2_0.2.2.tar.gz : CHECKSUM(SHA256) this package : 5d1ab62541f7817112519f0f9d00d6a2555bab5b2da7f5c6d579b0c307d7f2bf CHECKSUM(SHA256) upstream package : 5d1ab62541f7817112519f0f9d00d6a2555bab5b2da7f5c6d579b0c307d7f2bf
Requires -------- R-httr2 (rpmlib, GLIBC filtered): R(ABI) R(R6) R(cli) R(curl) R(glue) R(magrittr) R(openssl) R(rappdirs) R(rlang) R(withr) R-core
Provides -------- R-httr2: R(httr2) R-httr2
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name R-httr2 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, R Disabled plugins: Perl, SugarActivity, Haskell, fonts, Ocaml, PHP, Java, C/C++, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com